From: Christian Brauner <brauner@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-efi@vger.kernel.org, Namjae Jeon <linkinjeon@kernel.org>,
linux-ext4@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>,
ntfs3@lists.linux.dev, linux-cifs@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Hans Caniullan <hcaniull@redhat.com>
Subject: Re: [PATCH 0/14] New uid & gid mount option parsing helpers
Date: Fri, 28 Jun 2024 13:51:29 +0200 [thread overview]
Message-ID: <20240628-diametral-median-bc0de7b68148@brauner> (raw)
In-Reply-To: <8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com>
On Thu, Jun 27, 2024 at 07:24:59PM GMT, Eric Sandeen wrote:
> Multiple filesystems take uid and gid as options, and the code to
> create the ID from an integer and validate it is standard boilerplate
> that can be moved into common helper functions, so do that for
> consistency and less cut&paste.
>
> This also helps avoid the buggy pattern noted by Seth Jenkins at
> https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/
> because uid/gid parsing will fail before any assignment in most
> filesystems.
>
> Net effect is a bit of code removal, as well.
Thanks, this all looks good to me. I'll have one comment about the fuse
patch.
next prev parent reply other threads:[~2024-06-28 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 0:24 [PATCH 0/14] New uid & gid mount option parsing helpers Eric Sandeen
2024-06-28 0:26 ` [PATCH 01/14] fs_parse: add uid & gid option " Eric Sandeen
2024-06-28 9:45 ` Jan Kara
2024-06-28 12:23 ` Christian Brauner
2024-07-01 9:34 ` Jan Kara
2024-06-28 13:44 ` Eric Sandeen
2024-06-28 0:35 ` [PATCH 08/14] hugetlbfs: Convert to new uid/gid " Eric Sandeen
2024-06-28 0:38 ` [PATCH 11/14] tmpfs: " Eric Sandeen
2024-06-28 11:51 ` Christian Brauner [this message]
2024-07-02 4:25 ` (subset) [PATCH 0/14] New uid & gid mount " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628-diametral-median-bc0de7b68148@brauner \
--to=brauner@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=hcaniull@redhat.com \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ntfs3@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).