From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008CCC2BD09 for ; Fri, 28 Jun 2024 11:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A1EE6B0088; Fri, 28 Jun 2024 07:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4524B6B0089; Fri, 28 Jun 2024 07:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A0D6B008A; Fri, 28 Jun 2024 07:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 127DE6B0088 for ; Fri, 28 Jun 2024 07:51:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 96046401D9 for ; Fri, 28 Jun 2024 11:51:42 +0000 (UTC) X-FDA: 82280132844.25.8482D80 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id 8D1E41C000B for ; Fri, 28 Jun 2024 11:51:40 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q2jLpdy5; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719575491; a=rsa-sha256; cv=none; b=I/rgyUsoWELa5WrlFTnY+jZSKO2RUMd4nZojBicd5wyo44PbL/qDHIcE63EtV38HiIWDxI ySpmE0QZpUEmUVpzWlYtwnZug9DC6UW8x3JBfZHBR+0OXryFi5CU3gCKjubhJpOLFhQ/JP eZJUIYwkcdZppluMKEyE7tEhR/7v9rI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q2jLpdy5; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719575491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A97/nUYGcl2vna6YE5DF2aAZ1lwFGkDJYO1Rsp1A9qU=; b=cRObG0yEVb4CHpiNgtPwoKVFsjD3m2JrSc1UC71kqdilAjSm6d/6x5c7ZBXo2kdbjJ6Ea5 GXBxiNFNDTkHQnH8LdfCOUYmOikl8HRq7TfLw51Pi0GJcH/6+yacvSUB2cHmRnI4TvRC7K lzL9of3cbga02bY4zKeRhM2SQem0+JE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2A56ACE3BEC; Fri, 28 Jun 2024 11:51:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42760C116B1; Fri, 28 Jun 2024 11:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719575495; bh=JnyH8SDEWZz2jLqqQ554GBh8tAQTx9UhgxFw8mc1sOE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q2jLpdy50pCPaHfk/GszVqzRn1dxuGFUFV41ggzgLtbd1vvd6VrftxXXj5LqcGYG/ +pQJxdEuZubIiMSV4G293Ux6TkZo2cO+CAnzKpbs1kjqRY/g4mKzBtZajMTMmymjvX X0U6KDa+sTVaDTxM0c+nMOnywNl0guwnWATROqr+G5ILAoco+6z8zYmEN/f1mdgEkO 23ce8OXwCMrCrxn83h7eI1IIYUIA73vAzjXsuKEG1gqrqIbp/66wXnc+GPnqRM3ffg ZP9RXaVoiWAJFSwqvH69hm+Y7TQ0j/RopxvwAYcMdw0SGuNRBkO5cVUZYfaWBHdHex Bf02GRW8AnyfQ== Date: Fri, 28 Jun 2024 13:51:29 +0200 From: Christian Brauner To: Eric Sandeen Cc: linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, "Rafael J. Wysocki" , linux-efi@vger.kernel.org, Namjae Jeon , linux-ext4@vger.kernel.org, Miklos Szeredi , linux-mm@kvack.org, Jan Kara , ntfs3@lists.linux.dev, linux-cifs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Hans Caniullan Subject: Re: [PATCH 0/14] New uid & gid mount option parsing helpers Message-ID: <20240628-diametral-median-bc0de7b68148@brauner> References: <8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com> X-Stat-Signature: r4kd7xcwfxw8pdesof1fg67pgs8rrydu X-Rspamd-Queue-Id: 8D1E41C000B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719575500-287601 X-HE-Meta: U2FsdGVkX1/jCzOgY1OJ4Nlp+tUiUaq+O/mgmDV3srpGs0bz5D4IGMiiylnxtQ61gvcUAXA1QKCgKi/aLihvnKrcDRwGHYfttciK4qKLx9ti/Mstc5chCwnDokwuzY29ZLTr5SqczuUJXZKJ89u88BJE1nxjmTSVXbihSvu9MRRCBQp0rzylQt13JPPfXdGlO57O2NJtlYIuH17V8J9b5sHIDekNTQ+6hCyxr6cq2/gZbKum/kOZg8mlA77FiwSK5+MJluHr7wCZRkMtdRfL4Hz/d5KIqQucDrCZkIJ9ssmj4aURLYNZTSR4rB8k7YSvRzC1oaulnxUF2ZRNd4qehiOFKEQv+Glj6KTwRXZG9UGLfypm0mlHXwNB9DN2tOB2cgOP9hehSUd+daw9V/Gsb7kAjy/V7KGzFyq9P4ZlcuwnEYX5DLKHITxznORqWbIWgGqItUu0BqQZVLB2INVX3VpmgVPYPAAp72NqV+LglakIg7CVVibwz7Okq6Y+/V0r3ChMEKPkSiCYS/fY0V+5De0rd8aME2Czgp9WJMo+LOd4sVpSiaYRla2zRXM+ainsL2h4xpWKb/NgEhLVQ5sLS/CyCGpPivOwzv+q8y50vgy+Bn6rMUL/feeW2b7cxbhcZxWs6SB1fDZv7YitbGwjvPTvAdk3zHj+vhEOXR5DNPdC0JiL9o4c9dleODAD8+uB+UTw7x0RjsdFrFz2AQDajSMTsDo3x6qlT07amM4+01juE1Vf3GTbyjTSArGUF3W5NXeWiihXmGulRg1a7S2ONn0jCCcyD5c8Q/9jeITLjDKI+vMP3dLQ99o5ktYHDttk0ZNZqDdrAJOy1g12inbKM/pgn8mBg5oowNAk/vfGD1g8J8w4Dk7Fly6Eziyl6S5jEZOWZsq37VyNIss+T6cgQt008i+ZF59e/A6fLWG7DfxaufUo0jrTRGDtsxxFKL47OQr4dgJ2ieQLbLJuGcS UNjRkLco 9F9h6vjDsycfLpM04LfRXu3+CbjGnGJniFMNYBJrvMq2kbs/3pA+1WunHt7kX2DHHga8UZMpML9r+B68gD5GBc4EpZ7Sc348Znt9ALjeyw4M5L6LGWFaPD0jp3fOsW0Kn7I344lXEkCKH1IAARGqXMK3puxLm38ALylDpL5f4+gSHFqSQ7YSgr5DkQcllqwgblnlBnteIoTYzsLH7ESJRRdBJ+I7OXaweqeQYal5QuBO+k0k1a+099pNJoXyLuM/TVTaKUloUpou79Cwtk232A/e2/MN7hR70PkJqkWaCwmFaoItKguKAvjvxigCiXO34TleURSKbSUxmFlZIWlwdoVRzEiI9joTgCKt96NyBZMeKMCf1V7TXDh8UKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 07:24:59PM GMT, Eric Sandeen wrote: > Multiple filesystems take uid and gid as options, and the code to > create the ID from an integer and validate it is standard boilerplate > that can be moved into common helper functions, so do that for > consistency and less cut&paste. > > This also helps avoid the buggy pattern noted by Seth Jenkins at > https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/ > because uid/gid parsing will fail before any assignment in most > filesystems. > > Net effect is a bit of code removal, as well. Thanks, this all looks good to me. I'll have one comment about the fuse patch.