From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014DEC30653 for ; Fri, 28 Jun 2024 00:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C3936B00A1; Thu, 27 Jun 2024 20:55:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 572BD6B00A2; Thu, 27 Jun 2024 20:55:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 413646B00A3; Thu, 27 Jun 2024 20:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23DE66B00A1 for ; Thu, 27 Jun 2024 20:55:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B3BCEA0175 for ; Fri, 28 Jun 2024 00:55:30 +0000 (UTC) X-FDA: 82278479220.11.20E452D Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf14.hostedemail.com (Postfix) with ESMTP id DE328100010 for ; Fri, 28 Jun 2024 00:55:28 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O9LczQ/K"; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719536120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4lJQzCRPoEPhHVSEfjDtIXs2Lfn884K9fgq+Lhgsbo=; b=4/91t+awgX2yLWW9Zr0Z1FZNQSiChk7cfSqEQWH2a9PII/UvODsR/6FmnnlWee+cT6dRao p36n09Nb8YwUXrOzuDPd07ZWh47lapaq5pn2QR6b+AiZxWf84x4brE/lrOn3XpoC2dyvKF JsOZbLeEmhYDLIs+09D7xSYlRkxeWDw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O9LczQ/K"; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719536120; a=rsa-sha256; cv=none; b=OJQRBsWmXpEJv3ppaXIkJrGXpFkw+XOUKZRlgcjMirn2rPQ5e1/CE6OueJW/aS9VsIN1BP vxNP6ME4a4weecWsUo23gjQRGTwLax+vECKeZ15m8OFL2SomaisL15ZJFelAdkI0JVuEjC aEHPPCRIIT/p8G4F0vFSwvjfU6ILnww= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-706680d3a25so88467b3a.0 for ; Thu, 27 Jun 2024 17:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719536128; x=1720140928; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X4lJQzCRPoEPhHVSEfjDtIXs2Lfn884K9fgq+Lhgsbo=; b=O9LczQ/K0LVfWVbGKYKFj6ykakMCHwqS3PeKZJsJntq7yIHkIwHgFvaAOFN2pX547U 19LWVwd305uFx4ZIXDMPvXpVGBIqPfouY5KvNrlKzpRKKWECZ7boESzCnRwWHv4djzWy uc++H2gY/rPx3JdArZ/H3nzeXCvnlSZS2b1t4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719536128; x=1720140928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X4lJQzCRPoEPhHVSEfjDtIXs2Lfn884K9fgq+Lhgsbo=; b=fQh+ejDq1Blo49SukSJyd/oUHnpX+VHyz3DuZtOOIPyUW9kAxmmby2EjR8i5oABvZh eFS5vlUSnwSJgYPciZne6Gq2avCEZsWT7KdaJI9iO8bIH6Z5KXwWBpbLQoViRkq/ryYU A0JclKhrRgE/kuF01xB2ptxFXtUCPR6s5/VjJIDGj1uevkU9kTiBHgp6/bRvY9u/1OZT HWDATFF+XUPiNxGuS5X8B8IrSQo+FFqgjb0KtdQ4i8h9XuO1TnyXSMhDoDDb8kqemzbb U7IjokuqCpoC3YaFpVVzgwimhQ/CEfRE9NT1cok5tFhQESkV9+P2bwJfSc3DwlFC1r1h pgkQ== X-Forwarded-Encrypted: i=1; AJvYcCVQU5uOnxO2UroCDmRVFdMFgis6bYb1q5ZWbjhj6uJL+yht2Ryw+G61hxRZ1NxXLznQTcI77gQIVjnvH2J4pH9oJBg= X-Gm-Message-State: AOJu0Yyddbx1oqUNSke7lrjMz3YB35p+K7j91cZOVJZLpj8ib7Ocg7d7 fw4JZITRQR/rbRPNYgrJ0zfrGe8ZuQKoPMnscXUFCLX8YpfStMlBt/86U1OSCw== X-Google-Smtp-Source: AGHT+IEOCloo8kkoRoiQKPVId5pLv0VtG6h8sTIAWnQGJ5/+CLOJodNeklIIV+t7oQQsWSdNQD6UWA== X-Received: by 2002:a05:6a20:8b28:b0:1bd:286c:b0f5 with SMTP id adf61e73a8af0-1bd286cb1efmr7445570637.42.1719536127797; Thu, 27 Jun 2024 17:55:27 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c19a:b9a8:4bd1:72c0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac10d1482sm3804625ad.3.2024.06.27.17.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 17:55:27 -0700 (PDT) Date: Fri, 28 Jun 2024 09:55:23 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts Message-ID: <20240628005523.GC15925@google.com> References: <20240627075959.611783-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627075959.611783-1-chengming.zhou@linux.dev> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: DE328100010 X-Stat-Signature: 38ckhs4qkzw5ma9577h7u14nq1bfqz8z X-HE-Tag: 1719536128-665578 X-HE-Meta: U2FsdGVkX1/Wv9yG9EdQlLtHgo0nFWET9BvzvbGoLNPHiJva/xy+2zHQ+H1zPCDOkH83SdQ1ZRrLbcUpOHI8BWQe3yguGGTpv5UtoWXu4OyhQqgBL4X3Tf5LH4KR0SGNZOPVGilaLbc9w/dTB7sChsbnyQic4KbKJwmxRpxJQSjejo4S4SN80krzwOJyP4D4xFqTmlLHxZZn54w0FF66t7L0wKUrFVYA7LR6mNTm1i+doDZ/B4aO8dWx5Yg4Do8uU7wM2S8ROHvtZqkWj3+6ey9cl4Lac24XiguPPivlzXixkm0Zh9YgtYMgEpEzZny6UyYDlxVEufQQLRID4C7vXtYqIzzoAqeFdE6KPTSqo4euLN25Mak4U2SbMABnOJjULAvEfpTXTRpCozJ65UZ6JUoh7x8fvVRnWSrO5v48SWcG1toOx/mlIunhe0DSFAxOPcyWvttPfYpLVLTOq25ofPZTYLQ0tuZSKMXlss7mFeaC8+jIu3EWTet/XfukDDBCqs0YjDYGH9lSxOglPcOx12KGw8ondg7QfgkWwAkrCymp4cvFfTT5DVIF1hU9wZLUMpnF6dJB/1HKiLpbaSH895YihdKm/FVqGM6xAV4SUZYlRez6gfweaQhYG5HQ8TUiBoT+A7LtD3SByjoC/R8M7YbfXUx5qGeeUhDFsk3/atr4HrjYn0ZlB6fUeYaURNeA846ur8JiToBT1ocecayd4UBpA2oAYHZQ4J1Afw3yn08mIy0WHfLASbuvOiMwVOI55Dh0w350f+htvD7wNmtkQpbz8MnEkVlP0lR87n6DNMHGq21GkkqZ9d6veyfEn0Iu7RAmJN/nzLapuCaexGAaK+Bn/IpLSHhZ2481Oq4YtQ8jJwZ2NpKK3TNnRKOngvm09UEepSy9buBds31EnMUgAD3ir2R51WAaTX20AKQ8iwApYtAzp3Pd836BYG0H8CPxZBi7hBKS0eVjc5Xs0kr YIgt1sEb u+OhhEhWLLfn0+vxAInTVxUq74wO9jXaPTGApQQS/uiSOHtoPfeSz/Q3gEZkBry1ksKhxX9aoc7bX5xVJC20PQYn864DimQVbobxwIX155UZH6Ctw/G1KaflOkYt/mEJB9WA4OrUNGRzG5izFoP3aWYO0IwSn+DNQG8lBCV/XZ3dSDbL8fpuy9zRbhdNS0gb1aKniWSmUjIpu1wxEag0UP+/U8fL0anmhWuGZxXcvzdYFNta444MPVmDGbpIKCBHWxp03AZEaobUs635g6AFUeotff+DdfIBNOmklhAgyzBB0fQTfLPT5RzPm5iFtGbwGRRvEgNYab9SYhZpIdAuduVjuFI/r6M6C0G6XzWC+ndc46Bw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.091212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/06/27 15:59), Chengming Zhou wrote: > We always use insert_zspage() and remove_zspage() to update zspage's > fullness location, which will account correctly. > > But this special async free path use "splice" instead of remove_zspage(), > so the per-fullness zspage count for ZS_INUSE_RATIO_0 won't decrease. > > Fix it by decreasing when iterate over the zspage free list. So this doesn't fix anything. ZS_INUSE_RATIO_0 is just a "placeholder" which is never used anywhere. We can land this patch, if you insist/prefer, but it's some sort of a NOOP, essentially (in a sense that it has no visible effects).