linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: alexs@kernel.org
To: Vitaly Wool <vitaly.wool@konsulko.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	minchan@kernel.org, willy@infradead.org,
	senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com
Cc: Alex Shi <alexs@kernel.org>
Subject: [PATCH 03/20] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc
Date: Fri, 28 Jun 2024 11:11:18 +0800	[thread overview]
Message-ID: <20240628031138.429622-4-alexs@kernel.org> (raw)
In-Reply-To: <20240628031138.429622-1-alexs@kernel.org>

From: Hyeonggon Yoo <42.hyeyoo@gmail.com>

These two functions take pointer to an array of struct page. Introduce
zpdesc_kmap_atomic() and make __zs_{map,unmap}_object() take pointer
to an array of zpdesc instead of page.

Add silly type casting when calling them. Casting will be removed late.

Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Alex Shi <alexs@kernel.org>
---
 mm/zsmalloc.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9835121109d1..cedd3dfb9124 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -245,6 +245,11 @@ struct zs_pool {
 	atomic_t compaction_in_progress;
 };
 
+static inline void *zpdesc_kmap_atomic(struct zpdesc *zpdesc)
+{
+	return kmap_atomic(zpdesc_page(zpdesc));
+}
+
 struct zspage {
 	struct {
 		unsigned int huge:HUGE_BITS;
@@ -1063,7 +1068,7 @@ static inline void __zs_cpu_down(struct mapping_area *area)
 }
 
 static void *__zs_map_object(struct mapping_area *area,
-			struct page *pages[2], int off, int size)
+			struct zpdesc *zpdescs[2], int off, int size)
 {
 	int sizes[2];
 	void *addr;
@@ -1080,10 +1085,10 @@ static void *__zs_map_object(struct mapping_area *area,
 	sizes[1] = size - sizes[0];
 
 	/* copy object to per-cpu buffer */
-	addr = kmap_atomic(pages[0]);
+	addr = zpdesc_kmap_atomic(zpdescs[0]);
 	memcpy(buf, addr + off, sizes[0]);
 	kunmap_atomic(addr);
-	addr = kmap_atomic(pages[1]);
+	addr = zpdesc_kmap_atomic(zpdescs[1]);
 	memcpy(buf + sizes[0], addr, sizes[1]);
 	kunmap_atomic(addr);
 out:
@@ -1091,7 +1096,7 @@ static void *__zs_map_object(struct mapping_area *area,
 }
 
 static void __zs_unmap_object(struct mapping_area *area,
-			struct page *pages[2], int off, int size)
+			struct zpdesc *zpdescs[2], int off, int size)
 {
 	int sizes[2];
 	void *addr;
@@ -1110,10 +1115,10 @@ static void __zs_unmap_object(struct mapping_area *area,
 	sizes[1] = size - sizes[0];
 
 	/* copy per-cpu buffer to object */
-	addr = kmap_atomic(pages[0]);
+	addr = zpdesc_kmap_atomic(zpdescs[0]);
 	memcpy(addr + off, buf, sizes[0]);
 	kunmap_atomic(addr);
-	addr = kmap_atomic(pages[1]);
+	addr = zpdesc_kmap_atomic(zpdescs[1]);
 	memcpy(addr, buf + sizes[0], sizes[1]);
 	kunmap_atomic(addr);
 
@@ -1254,7 +1259,7 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle,
 	pages[1] = get_next_page(page);
 	BUG_ON(!pages[1]);
 
-	ret = __zs_map_object(area, pages, off, class->size);
+	ret = __zs_map_object(area, (struct zpdesc **)pages, off, class->size);
 out:
 	if (likely(!ZsHugePage(zspage)))
 		ret += ZS_HANDLE_SIZE;
@@ -1289,7 +1294,7 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle)
 		pages[1] = get_next_page(page);
 		BUG_ON(!pages[1]);
 
-		__zs_unmap_object(area, pages, off, class->size);
+		__zs_unmap_object(area, (struct zpdesc **)pages, off, class->size);
 	}
 	local_unlock(&zs_map_area.lock);
 
-- 
2.43.0



  parent reply	other threads:[~2024-06-28  3:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  3:11 [PATCH 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool alexs
2024-06-28  3:11 ` [PATCH 01/20] " alexs
2024-06-30 13:45   ` Hyeonggon Yoo
2024-07-01  3:03     ` Alex Shi
2024-07-01  3:40       ` Alex Shi
2024-07-01 13:42       ` Yosry Ahmed
2024-07-02  2:39         ` Alex Shi
2024-06-28  3:11 ` [PATCH 02/20] mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage alexs
2024-06-28  3:11 ` alexs [this message]
2024-06-28  3:11 ` [PATCH 04/20] mm/zsmalloc: add and use pfn/zpdesc seeking funcs alexs
2024-06-28  3:11 ` [PATCH 05/20] mm/zsmalloc: convert obj_malloc() to use zpdesc alexs
2024-06-28  3:11 ` [PATCH 06/20] mm/zsmalloc: convert create_page_chain() and its users " alexs
2024-06-28  3:11 ` [PATCH 07/20] mm/zsmalloc: convert obj_allocated() and related helpers " alexs
2024-06-28  3:11 ` [PATCH 08/20] mm/zsmalloc: convert init_zspage() " alexs
2024-06-28  3:11 ` [PATCH 09/20] mm/zsmalloc: convert obj_to_page() and zs_free() " alexs
2024-06-28  3:11 ` [PATCH 10/20] mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for zs_page_migrate alexs
2024-06-28  3:11 ` [PATCH 11/20] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it alexs
2024-06-28  3:11 ` [PATCH 12/20] mm/zsmalloc: convert __free_zspage() to use zdsesc alexs
2024-06-28  3:11 ` [PATCH 13/20] mm/zsmalloc: convert location_to_obj() to take zpdesc alexs
2024-06-28  3:11 ` [PATCH 14/20] mm/zsmalloc: convert migrate_zspage() to use zpdesc alexs
2024-06-28  3:11 ` [PATCH 15/20] mm/zsmalloc: convert get_zspage() to take zpdesc alexs
2024-06-28  3:11 ` [PATCH 16/20] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs alexs
2024-06-28  3:11 ` [PATCH 17/20] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc alexs
2024-06-28  3:11 ` [PATCH 18/20] mm/zsmalloc: introduce __zpdesc_clear_movable alexs
2024-06-28  3:11 ` [PATCH 19/20] mm/zsmalloc: introduce __zpdesc_clear_zsmalloc alexs
2024-06-28  3:11 ` [PATCH 20/20] mm/zsmalloc: introduce __zpdesc_set_zsmalloc() alexs
2024-06-28  7:26 ` [PATCH 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool Alex Shi
2024-06-28  7:30   ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240628031138.429622-4-alexs@kernel.org \
    --to=alexs@kernel.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=vitaly.wool@konsulko.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).