From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF41C2BD09 for ; Fri, 28 Jun 2024 15:47:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3595D6B0089; Fri, 28 Jun 2024 11:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 309646B008A; Fri, 28 Jun 2024 11:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 183AC6B008C; Fri, 28 Jun 2024 11:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB0666B0089 for ; Fri, 28 Jun 2024 11:47:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85D9A1202B7 for ; Fri, 28 Jun 2024 15:47:32 +0000 (UTC) X-FDA: 82280727144.11.30A263C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id B026CA0018 for ; Fri, 28 Jun 2024 15:47:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ndOC9QN2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719589637; a=rsa-sha256; cv=none; b=HvxsOhHqWtbigcN90Lij1zNTVXd6P0vWxJ1dVclChMTEewyifMF1s3iLgEg63rQgNPUam0 nO983i9pLZkdsVkAY9s6OBGhtX4vCWulOJVp8bpAFAkJ8iikLk2bVaOiKr2ccYHIQhzKlR 8yX3gT7S3CkkmuwGbm9oIYNFyU+ZLEs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ndOC9QN2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719589637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oH/Bho/8R7Zeq+AymD+lHefju2WDp+bJxyQiQQH2o78=; b=8GDOucziXM9oWB2rI7kCnTPRQ3p2fqAp+piilJzVmD67AZ0tHCvUZrmPoJhWnBLpLAmRwP jc0frD+Rh06VhjN0i1GtOJXzcSixRClT+Bbrs1fEw7OFBrc7fXj3aHuusxPfvzyJiMluer 42YfdhCOzrcgCFuuh9vN23mBZLjz2Lg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 86CC1621CB; Fri, 28 Jun 2024 15:47:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34036C116B1; Fri, 28 Jun 2024 15:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719589649; bh=KbxG9woxasDlknjgS1B+YGJ+MgARRZPg7XNQoih444I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ndOC9QN2uTkhIO2OBDFw49MNzOI5NaFZY5RIY77D+rSuEiG9qdDoVLA8HOyqzMNmY FzHWUnu0kN7M8ugVO+fpdIA9znZ0mZ/xHDM9QcHDN2AtwFL66F4HB+12z4+gz3+vGG 06kYO3zSIMO4Nv1Hgs0QSGH94LluAMsdT7lK+i4uByVYg3YUFFjGQ9QmFx8K8ISmbL oZcKCAVfu4sDeY6HjpFxQOU+XIXD7yNO3dov7m7RnrCCR62xMd8LhKLRUY+K//RJL7 1m6gP0JAMv6/2r8YaPZxUOP6dYDgcoQ1Weh+IH5pXluUYDplnZpey+GIOTBDrybQ3H iCLumA1dKvRBQ== Date: Fri, 28 Jun 2024 08:47:28 -0700 From: Kees Cook To: Boqun Feng Cc: Vlastimil Babka , "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v5 4/6] mm/slab: Introduce kmem_buckets_create() and family Message-ID: <202406280846.205B57F@keescook> References: <20240619192131.do.115-kees@kernel.org> <20240619193357.1333772-4-kees@kernel.org> <202406201147.8152CECFF@keescook> <1917c5a5-62af-4017-8cd0-80446d9f35d3@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B026CA0018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y917rjsjgbcc8y5zhmzg7ty4ghas1ky5 X-HE-Tag: 1719589650-446673 X-HE-Meta: U2FsdGVkX1+vOc0bu6D32l4xTso13CQzkepD9sSYG6k8cgANecFcgBX/Nx9mVDlbSKJhzkz5gaOv3h0T/lYzNuDh9d0+GQHy8TTMxlwH17pW2m7wMeAMdg4TqzOyzIDmdbHc3xrscpFB/Nm0VrzkiBYmYQgPUmDLOYi2aqy15FNS/d7WyK8d4gsSD8YCYRXNvT5WbVu7OPZBquTB1TTK33JvCpBgboT9/4ncwOv8K2JQt98WmqFag5/dIYI9K/EQrvYuAJ+MmmMvMdQhTMutxP8wmKN0ZXtuE/AzWOPUkzqfQ2hdRsIRzU2/GlMd4Jd4HOOeyMSRpxjUNINH4sql2dd8tFFYiSjezqsRa7IoxaAmg4fmCFzNKFtlUv5Is9e4VtAkTOpPjua+6QoCl8bsGJ9cQ5TF4Jphx5h+hNTTfzfcIpeqAR1PPgqvl/15mPMtqFrqsG9EyYd0bIX40iQMd+V2iagOqyvY2P06gwkdA3yWP/oRyddwZe+1jqvO5G32x11o2z7S+EmcBC3/zHf/HequLS/LjE8sASxKe8YYWuSmJtRkOvpKo7519nqvgbPsNOoItXxAXHcqVVQSGpwCet0y9EtsPTh4NBdwdhtk0aJTd3i1KXsaLyR9kAUnNqdTBq4SYbjEhkErnUnTp0O4IwSF1gWhZWt34Yo27u/SUxj3wS73os+gPLNr5pBEgdFr7P423fBk98Ob6Gi8h9z2k8tL528NnoC/kK9VxpIBdT+/docVJ5nDJPY51honMhKtFkzfX8byISCJhcqHD022xal3UpLW2sbfgWj8aZITdCRz0qqJHMjXCloYhluNkfJ4YOCz0I5FSyla+8db2Sz3TdT42m20BGaGKKNGMkzgAbUZgRum1k+/ChIC+fidCpePxcE1d54Kanm+qyxwVfj5pl52AFOE94dMZfGdqpW21OBArf4TkGKdmltyPXKV9Jc0fQSeOSugbZ/G52dH8AC 1lHdgrbx w9sGq9abI+zSllONuND6V52S2wweU120X/buzY4Qjq/DoPbeWwKDIUexACKSLyq2zZPrj7EB05kFn1D86KlxDG+ufz9g8HG1JX5Kb71e4TzBZnqEx/IqyyIL2b2kf62+Dd+vXZQoKDlb+SL92kXNw6KmQ53wuG8Z8OubkEXZ2dgELBqoLpNgEqETTT3gJZOir6AlG73tSQ984HTZw7/ZxsSkO9xVvwCkGAs1nB9XtmyryTz7I1nk2uqwMPNCPd+Lt9RhEmwpYI9PVs201aeCWyqwi7i7b6SrmE2vpoNPLkscJ7KjhRtEpD0wbKjoAO95Zh+d0qvio0M3ApEIMKtg8kUr+tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 10:35:36PM -0700, Boqun Feng wrote: > On Thu, Jun 20, 2024 at 10:43:39PM +0200, Vlastimil Babka wrote: > > Rust people were asking about kmalloc alignment (but I forgot the details) > > It was me! The ask is whether we can specify the alignment for the > allocation API, for example, requesting a size=96 and align=32 memory, > or the allocation API could do a "best alignment", for example, > allocating a size=96 will give a align=32 memory. As far as I > understand, kmalloc() doesn't support this. I can drop the "align" argument. Do we want to hard-code a per-cache-size alignment for the caches in a kmem_buckets collection? -- Kees Cook