From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C5AC2BD09 for ; Mon, 1 Jul 2024 13:46:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 804666B0089; Mon, 1 Jul 2024 09:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B46C6B008A; Mon, 1 Jul 2024 09:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62DB06B008C; Mon, 1 Jul 2024 09:46:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 443D56B0089 for ; Mon, 1 Jul 2024 09:46:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E29A8141C29 for ; Mon, 1 Jul 2024 13:46:57 +0000 (UTC) X-FDA: 82291309674.02.B8416BE Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 09DEB40020 for ; Mon, 1 Jul 2024 13:46:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=PaWl9Wr9; dmarc=none; spf=none (imf11.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.50) smtp.mailfrom=josef@toxicpanda.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719841591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/7pK8M+T679Mr4Uw1+2PXZ/iLLD0jN5yzRREJHhd/M8=; b=nzB+XuC796YoaObe/yosFoVdiBS46lQDKfql8cKohyxQ9zuN9o+gTv/W5O0mniQ7M1J62G 3nv7U2zIQIHh17/5msrz1YzR0pGDMI6w0VtbuFHPQubhGmVcsM6Kx3p+RuJiCLFb41eL1X zQDc8dwnt4Ck7nl8d0IsCzSDjmc/V/E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719841591; a=rsa-sha256; cv=none; b=h/xwVgz4AiJVDrkt/l1NzRI6OMZoEJnEFI3Eg2zNmhmMF/4FTWTG8CWBd2kfQ0kHaubyo7 4enS7zx+uf7KTXWzrd3FIb/jsmr+nmowKzAsNPy+uPDSLDxby2+B9JvTSMRT7nVZCGsXGJ mV6LQ6Q0Qos6eqfOwICQ8Z0cre2pLnI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=PaWl9Wr9; dmarc=none; spf=none (imf11.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.50) smtp.mailfrom=josef@toxicpanda.com Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6b05c9db85fso14177616d6.2 for ; Mon, 01 Jul 2024 06:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1719841615; x=1720446415; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/7pK8M+T679Mr4Uw1+2PXZ/iLLD0jN5yzRREJHhd/M8=; b=PaWl9Wr9fXaFjLyalHPfC7pdHgo2a8IQgwckxW3HWCx0nCv3lwzif2K/UZ6kyf5rv6 cZWWau4VDQcg4t9AC4apaLplVJGKfiJsoTcnWvIArWrsCq2jyv5dU5We+H/QruVn4fYV GtqG9JMhoEkGH14ir9rGz9ksQ3ChdcUFt6qahM9872eBlsW8Fx5AHpJ4xFvJO/FiygoY QMZfp/jpcOn9SrKyXWadhbfxsdD8Dm39uMxD8sooMe6Ycp4vKebbhQgMqOgWW2QOGtn0 ZCAQRKwHuda+bLsLrnNVt66H7d1XGROQV6vpnLEcp8NYSl3Lh/+I/YD3HhiyTzGhSEHw CT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719841615; x=1720446415; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/7pK8M+T679Mr4Uw1+2PXZ/iLLD0jN5yzRREJHhd/M8=; b=eInzg35O/a7QYN7XQjDSk8kF3TDusiSpZw9/ST6pjDu6UZfLZB4I8CkSHS4HfE4R7E 4zu0WDyF7CXoGhdujFdzQRC6+bflMG4aPcPAhLTbIrAt0uZPwTJYFX8cFyXy5xMXS70b kcgOVCBcGzJV7Ks/DpOmi3wMEDH1FyCLuhxszi0Y1rAiVJ5Cbane6iH8dYCMdqAA7fRH yOXD0iKxd70i1X7cm0PLHQDIFagslf3IHponqgBnvY9GoAXbvxty7h5abSPTtF2mmgYj PWUzSEuy0scFYX11xKHBxf00Y4ja7ttdqolVUYF9N7OEnXvorso5qvXW7En2mogVVzBH nyzA== X-Forwarded-Encrypted: i=1; AJvYcCUmqjZ0aHDXZnwAOH82p38wPGXRV5vpmj/dlytUa82wPwAcpbq1ecEb/uMnl2rQobA5hJzE1jp2BoY+zVceJEvtlto= X-Gm-Message-State: AOJu0YwzF6Jsu8coe5GGAsxvKuxqrRT2kmAFBODOoywSnyR28QT954Hz 6RfPk58PrTNJQfbWezFRRNlbYbxULdAQM9dFYbVeTo5Rs4Au5nkbriHSN7HQEow= X-Google-Smtp-Source: AGHT+IG8OekqgNnErri1uZBaOEWN7EF2UDkAF5obMoo6PPyjxSiFbWfhXRMS/kv2BHuTbAr7oS5ICw== X-Received: by 2002:a05:6214:f03:b0:6b5:47b0:8f09 with SMTP id 6a1803df08f44-6b5b70cde0fmr83155356d6.36.1719841615063; Mon, 01 Jul 2024 06:46:55 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b59e5f5f51sm33227276d6.75.2024.07.01.06.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 06:46:54 -0700 (PDT) Date: Mon, 1 Jul 2024 09:46:53 -0400 From: Josef Bacik To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , David Sterba , Hugh Dickins , Andrew Morton , Andi Kleen , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 07/11] xfs: switch to multigrain timestamps Message-ID: <20240701134653.GA504479@perftesting> References: <20240701-mgtime-v2-0-19d412a940d9@kernel.org> <20240701-mgtime-v2-7-19d412a940d9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701-mgtime-v2-7-19d412a940d9@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 09DEB40020 X-Stat-Signature: aw5jf38i946j3p9engmz6wpcf67nfdrf X-Rspam-User: X-HE-Tag: 1719841615-278889 X-HE-Meta: U2FsdGVkX19xJ9N3cQq4IlSiOU3xhHYTytAGQy4rbUDMcbM9JtkVHuY0o+YgD4DNAe/cDqbxyGmDDxIAt6z3gn0aH9sDm6FQ/5IM5zGqezEVYSRy6xOsYmCZqNhhkkn0+XlMF8ZKJMJ4lpPrOlZpPffwr2Zhd4mPbmaJ8FAU7/KAazzvq2R3rrCKaXRks6TrMxvIiAj6CgPBo4/ZY5WY/YstB6oFlm14zPa0Lbq2ntQscV9W0CMyYWCTMzvhZUiKVTA5gO1TkWGukU0h8rN7pyiFYj1qXPNpzSBDWitVzNOgT/uzZy8bRgjhKAfZkY84c1MXWPxzMaim+2ewc/144ewdIZxDrntW4MJg5AG0RI6lBCW6jAx0ku4Fb56+m6AgeOffDmfbfys5dePzLqNoyho22dSHAya3L658Tt7yTY7E2/SfCY6eUQVzN31W3nZpWVGQyOpUdpggZbCGV8Nqeebh3XW+Vcf+WwwUFp4y+Yf0xmhYZzOz6KCyg1BNnhbbGXlE/fFBgJ844e5g3liw8m2u2y/VzqEWBqOA00fmouFAyMilNc+52EYv0WCdAO0q47XF6DlU8AWIS5QrHaKHumK9LJk/tGXy9AP0KDR9wZI5Wo4jAy0itknneggxU/w8gzHNb2OFS6ahhIV2GBIFCig6EKlxakEEipmAzJcNvUvt2L+l+X3QBqArE5bItne3gh1wmTeRUeikZeaUMSLS0uQ4KBkds7Q8xn7Qd2mSzuhmyadet7GbuVhbL8xYJ40WCs8gThEbZIK/qGPrGH+LX7aP/G7ajwhO0cDdfpOcCtM2b8X3hR95t6urhEqe0D0XvzNxhEmyhmIYdKIErPYqwTRGyVvnsHRf2PD4VVo4quj9+5410E/Bv4Ngb4wvR/C3amLjp+XkvkI/EFvcdzVo2/6JQ5mpFsmW24maQmf5doAxUGFCY14jzKtrj8DZfu9Kpa/VZuxYraVHImSdSgT f7NHtQMI 6u3pKsQnFqPQjpTypEfTOSv5o2IhV1Wi7DRFRDMerkAUjVU9VpC15JV4Xl3onQY4x+3/LKTUO9sc9AxClKN1dP9d/mDCu5Dihr0eOQ7rtyPlVuFusV80o0V9WHOElhpYAmw5R1O0yGELeSfz1UP4Jvs4/GwSFofVDCDe8x8IxfsmV0LHoT7Bsfc+T6h8dm55zn5F3jQzLOTuC131xGmA4fN3FIiL6OMq6AkJF82qM8kclusoCWgQYgwP/ezkQrtGWIt0xC0v/tzUwdA1sP/RE0Ddy7kqSEWBrW6YUC8I7P99UdXDezmZbbRITLmZpUI6ZexVja7mxr75PNof68GSoYKpPnHX59ueMB5GVb/rckzfCRZJ7vC3FG5pDa2rG19z9jwkc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 06:26:43AM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also change, and those > are now the only two options for xfs_trans_ichgtime. Have that function > unconditionally bump the ctime, and ASSERT that XFS_ICHGTIME_CHG is > always set. > > Signed-off-by: Jeff Layton > --- > fs/xfs/libxfs/xfs_trans_inode.c | 6 +++--- > fs/xfs/xfs_iops.c | 6 ++++-- > fs/xfs/xfs_super.c | 2 +- > 3 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 69fc5b981352..1f3639bbf5f0 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -62,12 +62,12 @@ xfs_trans_ichgtime( > ASSERT(tp); > xfs_assert_ilocked(ip, XFS_ILOCK_EXCL); > > - tv = current_time(inode); > + /* If the mtime changes, then ctime must also change */ > + ASSERT(flags & XFS_ICHGTIME_CHG); > > + tv = inode_set_ctime_current(inode); > if (flags & XFS_ICHGTIME_MOD) > inode_set_mtime_to_ts(inode, tv); > - if (flags & XFS_ICHGTIME_CHG) > - inode_set_ctime_to_ts(inode, tv); > if (flags & XFS_ICHGTIME_CREATE) > ip->i_crtime = tv; > } > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index ff222827e550..ed6e6d9507df 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -590,10 +590,12 @@ xfs_vn_getattr( > stat->gid = vfsgid_into_kgid(vfsgid); > stat->ino = ip->i_ino; > stat->atime = inode_get_atime(inode); > - stat->mtime = inode_get_mtime(inode); > - stat->ctime = inode_get_ctime(inode); > + > + fill_mg_cmtime(stat, request_mask, inode); > + > stat->blocks = XFS_FSB_TO_BB(mp, ip->i_nblocks + ip->i_delayed_blks); > > + Stray newline. Thanks, Josef