From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C86C30653 for ; Mon, 1 Jul 2024 13:53:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D11C16B009D; Mon, 1 Jul 2024 09:53:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE8A16B009E; Mon, 1 Jul 2024 09:53:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B89476B009F; Mon, 1 Jul 2024 09:53:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 99D906B009D for ; Mon, 1 Jul 2024 09:53:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D844BA1CAB for ; Mon, 1 Jul 2024 13:53:36 +0000 (UTC) X-FDA: 82291326432.05.E4A93BC Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf21.hostedemail.com (Postfix) with ESMTP id F30011C001F for ; Mon, 1 Jul 2024 13:53:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=JorMuHlY; spf=none (imf21.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.45) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719841998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iGkmZLClwxRQ5wYzCN604PWlDaKRDeFDexxSEzqTfW0=; b=8eoQd4aAmbFGhGh3su7YkxL++rQ3M2GoeRFS3wxb/2CZsKDdh74cIknpXwEYorwjGPrquf L7rKIKyFn84fpSt9IPL1qPGNum9OgJ4xqPmwlq+sNz/0fOOuVNd4XzxplpBtiPD+YSQmaG vPMjQBo3rU0xeUF0QEB0khqed8EQQmI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=JorMuHlY; spf=none (imf21.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.219.45) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719841998; a=rsa-sha256; cv=none; b=PfSrVvjJVIx4emJFmLG+ttM6pZiVDH6ZlSs4KLQbNmnzuCjCKL1PGph51QlL1DvLsBtgnk fAm5z5v9knohS6NmbN86mxJ5qdVgksbP7tVSC91imiLlTD0nfv28nSXWq505gLr+duL9oB 1vwxtgz3k6akBjmBrgd+jPJhzzryzgw= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6b593387daaso31036956d6.1 for ; Mon, 01 Jul 2024 06:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1719842014; x=1720446814; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iGkmZLClwxRQ5wYzCN604PWlDaKRDeFDexxSEzqTfW0=; b=JorMuHlY0B9peMLLQlE455ZUk+t5PdRmjfC1Sqv+RC1x8zAHBBWj66xZkxTCEGNPys jEwWV+nnIRic5YlwqlHvjfXD2sNZfZkYDRAstx3gz4voncbiUcAvbkyvc6mX/5VcxvXS GUEbvdArN5hb4A1/DiFUleuyOSgFkUBapAtLSYCc+GoVP4ptimqg7tLvmXEu9M0Zn6Lk uK2+oBq+HOpjtjfppM5NJRog9oIvpPAC/Wywqiq6XXLFEJ7cq6UqAkyXWiTU+iDLfJJR /uDYmyhddCI++36dG53Hwome5Hc6oszXWZuxkW8W26+Oyefuw8ZREEkSSnpUUaebMZG1 +ejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719842014; x=1720446814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iGkmZLClwxRQ5wYzCN604PWlDaKRDeFDexxSEzqTfW0=; b=Ot3bcBVKBYpSPOsaD6NhBxr0EAxoA0ruCHcRv5YR5x2BWfxMZT3EprnUB0T5/Gn0zi L4yRSJl50oAGtlfPXg2J5rjugbHp7ztaaYqT2qxkgP+IEb9thqs03ugpmoh33KbO8tbk sNclllBDEYcyetc3Cm0203VC3D9Y/pKosWhzWdcpxwOEM1XXP8VxQglhUj4VDwlIdI19 Qol8ljfCNVe2UbzzDziVHWrHhZeExGW4HC1Cu6DdVaUQav9Sya1I6w9clgDf5tXlrWxr oEaJtOTn/k8l2040+2bZ1O1+OCcudrXfrE9fDzMMmcyqmLgHQDdPXHkpyXHl2Ai13plt iECg== X-Forwarded-Encrypted: i=1; AJvYcCUT8Z4sKav3xeWcSh1zYrx+KwgxgZ9t3NnXD4zhK7EZzqV7LQNhLqHlLhpHwHtrXhtkQrzsdVwrkz8p1y2nrxcAtBI= X-Gm-Message-State: AOJu0YyjQNtgLql69BZv3IcR3DXnQwHL4nAgzqpeYTs2bSkThUT2QCH1 vDxnngBqxgHo4gffZ3QdvU746KQW9v9MA3e5MHeKWwRMKXIHQlHe+ALce3vzQv4= X-Google-Smtp-Source: AGHT+IHm2/95kxXclblhwH1XWI43VIUQy9+CryR0wDr5yVVClG9FOmbCdJsGBV8B1kk6bbVv/+DnBg== X-Received: by 2002:ad4:4ee4:0:b0:6b5:337b:da4e with SMTP id 6a1803df08f44-6b5a5483dd8mr141333876d6.32.1719842014105; Mon, 01 Jul 2024 06:53:34 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b59e564455sm33241616d6.42.2024.07.01.06.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 06:53:33 -0700 (PDT) Date: Mon, 1 Jul 2024 09:53:32 -0400 From: Josef Bacik To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , David Sterba , Hugh Dickins , Andrew Morton , Andi Kleen , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 00/11] fs: multigrain timestamp redux Message-ID: <20240701135332.GD504479@perftesting> References: <20240701-mgtime-v2-0-19d412a940d9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701-mgtime-v2-0-19d412a940d9@kernel.org> X-Stat-Signature: p4twnizqarufcp51484h77h7mzfjfgfn X-Rspam-User: X-Rspamd-Queue-Id: F30011C001F X-Rspamd-Server: rspam02 X-HE-Tag: 1719842014-504473 X-HE-Meta: U2FsdGVkX1/jt97JkKxIMxj4KTL/fHdwiY9K6SvkVkIPjRUM9VY+zJJhA3aGoHfwk4VAFNajo++HRCjEYOB3xrHLlsUAyIbHjt32NXXUukXGYzIPoW7VNvMrDFDiDRw1fmkAoDEvyiPz7ie9f/2YuYi6cq5voJXJm5cw9ooxxUePnR93lof4hGkepDUvVgt/mDD1mgHebu2cqKjsMm1TD0OG5di+VAgXTk74JhCM8RKlv0N9ZRQZqEBR1SYSQbDGq1VqlS+f1Dz+xuGlLvQEz1ZyWbD/quHB80m9SCNSIm5vkYRhEJExoNEivbo6YYRuF3uh/YUAljCwbevUqIRumq8NXpwEpRGF8fn8l4wfrJQLNkdMiGNQCnlaKvbV9IUq9+TPpgHByrm//ZKYovEY6hDjls9UGChRK22JNDL6159FKOwNQ2tyUpU6EDpJFGXP4bGXGcgmxz9ehEFZwp4FLKPN1QoVt1Vap5k+paNwmKj0wceT7wvd1cd95CVgwARj+4iBAC1eC1KA7XEZSmXHumDYI5yZ8vEbjnZ+Jpas/8jagwZ8eqOpHFGyDpiE+RIA2ujPplCXRoAo2m1fP9mrWtJqr2DY1zdMVvk9fSYs5noGkS+3XLWCAWuIXykMPGAtetf2FB/gnOS99ZwyUhHk2GhLmpSZCi0RKYfEfdOVNz+zzWLbfyvQbRq3devLfaaswYd11J0fEvHczUif4ndNWR+EKHkGQkNP9y0NnhdASjOfXSTi//EVGN9AhExcXnKKN7lK/z4xlrE/jHi3eOjlhbpYZUxy4bH83Xu3pGHavDzHDDGMSmMVTttER7o9UOWGfsMrr5j00S53Y2MyfHi9pCFgOMlEP3EW9Vfcw+Q9OEToORR+fkJLdxmYFgoBLvrXYyilPeDT3wKCNKND9U3dunXAYJwyXnhZqtOO0OHa+T/TztIXxKS0sQOGw01aeqYJXxmi4QicNwuwce5WmGq utNqU4P5 ZaE/7SXhrM0Q7t37sUTaTS/PQXqXM8Fj4hA2UNW5SGuZK6X77ZzeBQh1lircCuv2/sghSyN1MzkbsS99HiQfK4IKaBKxDFab5hwgVYy9Hn7QMrCIWaUUOpcN254mwE33FNrKApIEChd34/8lH52PcePieUYIWLfbohXqnRrNCIqsU6uE1yS9VY4KU/cEJVJQKqSmaZGnnNN6TlGxky8WSJ57X2BENJwJwIA2gV1tOO+ria1cxnDUS2SeixdnKNhj3Ash9KfSlVkWuU6IWLcytwqUthp1/gfrLcbQRGS5DpP5vUmvBkEyDDm7n3qifeRjIsclsowunJkMK39QvzGEDC60E1iXC5REKQp4t7QBpXGUYjhAJRJLkbHJR24t/BRGJxuY0ACxYrLyfgy3WScxLANj1yFPp/LCk1aL6fwoOZbVYqy55nwAIaI8tzkQYWEpvAO6N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 06:26:36AM -0400, Jeff Layton wrote: > This set is essentially unchanged from the last one, aside from the > new file in Documentation/. I had a review comment from Andi Kleen > suggesting that the ctime_floor should be per time_namespace, but I > think that's incorrect as the realtime clock is not namespaced. > > At LSF/MM this year, we had a discussion about the inode change > attribute. At the time I mentioned that I thought I could salvage the > multigrain timestamp work that had to be reverted last year [1]. That > version had to be reverted because it was possible for a file to get a > coarse grained timestamp that appeared to be earlier than another file > that had recently gotten a fine-grained stamp. > > This version corrects the problem by establishing a per-time_namespace > ctime_floor value that should prevent this from occurring. In the above > situation that was problematic before, the two files might end up with > the same timestamp value, but they won't appear to have been modified in > the wrong order. > > That problem was discovered by the test-stat-time gnulib test. Note that > that test still fails on multigrain timestamps, but that's because its > method of determining the minimum delay that will show a timestamp > change will no longer work with multigrain timestamps. I have a patch to > change the testcase to use a different method that I've posted to the > bug-gnulib mailing list. > > The big question with this set is whether the performance will be > suitable. The testing I've done seems to show performance parity with > multigrain timestamps enabled, but it's hard to rule this out regressing > some workload. > > This set is based on top of Christian's vfs.misc branch (which has the > earlier change to track inode timestamps as discrete integers). If there > are no major objections, I'd like to let this soak in linux-next for a > bit to see if any problems shake out. > > [1]: https://lore.kernel.org/linux-fsdevel/20230807-mgctime-v7-0-d1dec143a704@kernel.org/ > > Signed-off-by: Jeff Layton I have a few nits that need to be addressed, but you can add Reviewed-by: Josef Bacik to the series once they're addressed. Thanks, Josef