From: Steven Rostedt <rostedt@goodmis.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: <muchun.song@linux.dev>, <mhiramat@kernel.org>,
<mathieu.desnoyers@efficios.com>, <linux-mm@kvack.org>,
<linux-trace-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/2] hugetlbfs: use tracepoints in hugetlbfs functions.
Date: Mon, 1 Jul 2024 19:49:06 -0400 [thread overview]
Message-ID: <20240701194906.3a9b6765@gandalf.local.home> (raw)
In-Reply-To: <20240612011156.2891254-3-lihongbo22@huawei.com>
On Wed, 12 Jun 2024 09:11:56 +0800
Hongbo Li <lihongbo22@huawei.com> wrote:
> @@ -934,6 +943,12 @@ static int hugetlbfs_setattr(struct mnt_idmap *idmap,
> if (error)
> return error;
>
> + trace_hugetlbfs_setattr(inode, dentry->d_name.len, dentry->d_name.name,
> + attr->ia_valid, attr->ia_mode,
> + from_kuid(&init_user_ns, attr->ia_uid),
> + from_kgid(&init_user_ns, attr->ia_gid),
> + inode->i_size, attr->ia_size);
> +
That's a lot of parameters to pass to a tracepoint. Why not just pass the
dentry and attr and do the above in the TP_fast_assign() logic? That would
put less pressure on the icache for the code part.
-- Steve
next prev parent reply other threads:[~2024-07-01 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 1:11 [PATCH 0/2] Introduce tracepoint for hugetlbfs Hongbo Li
2024-06-12 1:11 ` [PATCH 1/2] hugetlbfs: support tracepoint Hongbo Li
2024-06-12 1:11 ` [PATCH 2/2] hugetlbfs: use tracepoints in hugetlbfs functions Hongbo Li
2024-06-20 11:50 ` Hongbo Li
2024-07-01 23:49 ` Steven Rostedt [this message]
2024-07-02 11:55 ` Hongbo Li
2024-07-02 13:30 ` Mathieu Desnoyers
2024-07-02 14:21 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701194906.3a9b6765@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).