From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2334C30653 for ; Mon, 1 Jul 2024 20:33:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF096B0089; Mon, 1 Jul 2024 16:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 036D66B008C; Mon, 1 Jul 2024 16:33:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF2DD6B0092; Mon, 1 Jul 2024 16:33:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD6F56B0089 for ; Mon, 1 Jul 2024 16:33:29 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2549481B4B for ; Mon, 1 Jul 2024 20:33:29 +0000 (UTC) X-FDA: 82292334138.25.D5D0674 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 0E60114000F for ; Mon, 1 Jul 2024 20:33:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=3fQNyBst; spf=none (imf26.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.222.173) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719865995; a=rsa-sha256; cv=none; b=k9GfCfdhoaiMd7PkoJmwDzE8K9Z9OInYrXJlIOIePtC8CYtGFID53VBZH3ZKViJRcD9ExI 3qao96uqT7xDUM1Rpez67I1isPWvzTNvN73qRJVd+US5843Rmj605GKBa/bufV80Ysvfax LGoTX+GPRQZNe7NzMgrgskd5JX7xQ40= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=3fQNyBst; spf=none (imf26.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.222.173) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719865995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eJWQ2aw4J/WLIAVkZzcuHyyU5owW6RRYm2ZeVPaEzB8=; b=XXzx1ZDnUyAvIXhsGUMgRTsLzEbObmy6iP85wg2Z1fpFMfPeqjTOvSxBV5ECKdrlWRIxfy jmE6xeg2EfT25iQ7eUsEBUjWjY0pAtfqTNR1IW7CLF6/Iq6OKjfiCyS0ehccREKLvnWh68 ugR2zVXeQ1puDukNEEu/OP15mqhkf+E= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-79c0b73b109so234149385a.1 for ; Mon, 01 Jul 2024 13:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1719866006; x=1720470806; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=eJWQ2aw4J/WLIAVkZzcuHyyU5owW6RRYm2ZeVPaEzB8=; b=3fQNyBstr/yrjZir/ceo37dUWvaryz+3XCZWIK7NdtO7ts7WVdMDmJnzorVVY2Z8ZB nrCK95Sq9hGMeSwNUHOz4XsYD4M5P3oWJXz5Xx+m97y/6+gKQpc381yZBigwCjadwdg0 6XkRD4ep2u6jX+HClVflS8fGkB0OCVMXRt3MFYXcXTqCNvcVYDE05PxGmeY87e3Q3Cex YHuLlkTGJYgxzh6ab7aVa5wx1P6iJ2WmemMyfKOLHWFlITnmkO4nEh4IFeM76NfjFD1w KxYonT4tKQ0JMIrwgunR+M0J7A8ZQlOpGEiZEcYxge0ozMkWvO1lYnE//jNucKl/bN7T 89VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719866006; x=1720470806; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eJWQ2aw4J/WLIAVkZzcuHyyU5owW6RRYm2ZeVPaEzB8=; b=BU/6Gmn9y/sl33P/voW6Nw3gfiHq3WIh2Jvjrt4kI8K7+m/CsRdZ7/GEE/sKrZNNl6 Y3C4unvWTClFEL/PsTHifZoxJKIWBOrmJ9aDvlZNNdC0wZfy/o6JevbygOHRXShwQKwJ /AxUFhcOjBQHz6fthmfheD44hOnVe4PzX88lk1D9KjCOinYbGDErnx83Qg0fI0qIOoR2 R6Te6WhzSiFf91cU8a6UNFP3t3I1g2l12xuP5jHvk3jELNomCnez4mhs3C/yxzeBrBU1 YXzXIzo8NrVRVHfSFsuvOgo1QPATQEBuYPE3148Ieuqo2LzpheRJvr1oYbq7KrteowBy oo4g== X-Forwarded-Encrypted: i=1; AJvYcCWs79p0+VexlpFk4ZS1pX1wz67+3zrmPrwSeZc8osQSr4PN2v6BNlvi8wjFPQhJ6rtVrch8qBWspZkuu99pR7KSm34= X-Gm-Message-State: AOJu0YyPr2HBuV86WkO3cpnmZ52z0vSjWanEyNbFx0dTva2FrHhNkdXA 1fuJV2TG3JejDU3RjgXgp8IqbQHSbAoI9hBHPGM2Kf+/zpYxRplHxQYh+AZZQmU= X-Google-Smtp-Source: AGHT+IHquiezZuh7KYAcKV1s9Va0xkaeqQinyvX7/0dTMvr1KCMbQie9WJzy87YdgytxI01W/IdsjQ== X-Received: by 2002:a05:620a:2683:b0:79c:f0e:f793 with SMTP id af79cd13be357-79d7b99e142mr1064186885a.14.1719866006069; Mon, 01 Jul 2024 13:33:26 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d692600b6sm384373985a.20.2024.07.01.13.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 13:33:25 -0700 (PDT) Date: Mon, 1 Jul 2024 16:33:24 -0400 From: Josef Bacik To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , David Sterba , Hugh Dickins , Andrew Morton , Andi Kleen , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 09/11] btrfs: convert to multigrain timestamps Message-ID: <20240701203324.GA510298@perftesting> References: <20240701-mgtime-v2-0-19d412a940d9@kernel.org> <20240701-mgtime-v2-9-19d412a940d9@kernel.org> <20240701134936.GB504479@perftesting> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 3i5mmfp74bek8wqren98gid1kzmwzdak X-Rspamd-Queue-Id: 0E60114000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719866006-387784 X-HE-Meta: U2FsdGVkX1/WtgRVsCWODOjVbFVE+naqEr+Kbqb1YF9YG7RcLYrQ3ltv4Xgwlod5JaZUb1Xx1CCQ38Y2O+c7o2nSwQAmLlvwqjqCC2vbONYm4BbAe0rOu86dpMTDOm5EFA6orvmF85gqmfxtGpFgQBsldBmncbnPvo13Zlf0DtDnMw8fSslh++He2G36mOicQCBEuuqTTPTjiWcTMZOpJMEDCoLW5ymSrRUQIbqT6bIH4IdJQ6FDHomnxeKwwF+asLt75AJ8MQoCOA+ZC1TZ4NSRCJg3eJB5Ycfqn8AzhfEaJyzM2KFTDHcuNuoxy5vPuZIKNoqc6K7KYIKofXJ37KKzdcib7W5hyRezrdKgva6rjQQmdhgAZS48y5kREgY8TK1TAXk8rYnLOsPZzDe+y8I4hFAihF+qJcjg43uCLMtMFPVggwhZl/pPNf9SOvYYULKZyYngivT2FJF3PbCbjwynUDOwUHb7adoQ+p+JivR0BgNcIso9EIvtL9QkRpioPvB4tbeSH7Omb5y6y3ykSMyApEsGOnxCWwkmLXWCe9raZuOFsDa21DdN8Z8KJ+P5nOPkc+bfixW8E2kUPDXkPl4G6wvG92yHY10GqEBEKgDK/AqhJ7+y24WURlsu7nIgUhPsRGNPS9ys8LFBvWhDYF065DBE7rfD9UMkfBZTmjqg8bHf2oEmOp/WOly/eh5nz2iDePZit92JJL4/PW3YPeqtnX7mqLGaNMKog6emozvsn76Ou5JqLVw82fNrxUjNJFIyJryrxegfxpMPWmtNCPx7bTiJkka5tUOFp8zDGqLhAl+ozTqOK6V08smTUrF+fbRrGNh1013TgEqbe/Xa926JIYyYg2J2hWhFNDKSgge9C8KLEgvFu9khuuRGUjQ59yXwhAbPAiLvlpZrwyRHDSLSBn/sSZTnq7fIBhZrXjpKCMPm3T6tdspEDXoPlIyEjcUbb4sUHraFAtYbi2/ W/NBgBWe kmsbYTkihTrLJ6dGMEz8RLuJk0XqU8kubobSrLTYYifZVPT2Nd3AwfBNj3OF73ZhbOi1KsVA2q0to4M+V5LeSuX/S2LAGV1Opw2wEdAh11xgjwNhdBa7JtGVc8Il05/jzoJSt4owXiLGr8BFQliGEY4NmY08Vdb4uJX2cm2hyUJaAU+bz1/f8Bhdmxh2Qj8t8Ti7vgncUCN3md4W+7Syyg3u2Gx1pqT69CXfvlXAhvcyhl5IpopyFRx+BdABcJHP4L53WWqTbTDPrAfDoUQpglVtrwxi0Gbgwo+4CO1T46EU99nM19zgBxrvsY/mwdtzXkoo1OoUQKh2b+fV3l2ZUwAjGnKp/zSls9L4fUGncift65+zUBxl+O2PjYossv7q9vdB4K7sfqZzXHgAKtW71o1nFsQieP/wWt2Fl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 09:57:43AM -0400, Jeff Layton wrote: > On Mon, 2024-07-01 at 09:49 -0400, Josef Bacik wrote: > > On Mon, Jul 01, 2024 at 06:26:45AM -0400, Jeff Layton wrote: > > > Enable multigrain timestamps, which should ensure that there is an > > > apparent change to the timestamp whenever it has been written after > > > being actively observed via getattr. > > > > > > Beyond enabling the FS_MGTIME flag, this patch eliminates > > > update_time_for_write, which goes to great pains to avoid in-memory > > > stores. Just have it overwrite the timestamps unconditionally. > > > > > > Signed-off-by: Jeff Layton > > > --- > > >  fs/btrfs/file.c  | 25 ++++--------------------- > > >  fs/btrfs/super.c |  3 ++- > > >  2 files changed, 6 insertions(+), 22 deletions(-) > > > > > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > > > index d90138683a0a..409628c0c3cc 100644 > > > --- a/fs/btrfs/file.c > > > +++ b/fs/btrfs/file.c > > > @@ -1120,26 +1120,6 @@ void btrfs_check_nocow_unlock(struct > > > btrfs_inode *inode) > > >   btrfs_drew_write_unlock(&inode->root->snapshot_lock); > > >  } > > >   > > > -static void update_time_for_write(struct inode *inode) > > > -{ > > > - struct timespec64 now, ts; > > > - > > > - if (IS_NOCMTIME(inode)) > > > - return; > > > - > > > - now = current_time(inode); > > > - ts = inode_get_mtime(inode); > > > - if (!timespec64_equal(&ts, &now)) > > > - inode_set_mtime_to_ts(inode, now); > > > - > > > - ts = inode_get_ctime(inode); > > > - if (!timespec64_equal(&ts, &now)) > > > - inode_set_ctime_to_ts(inode, now); > > > - > > > - if (IS_I_VERSION(inode)) > > > - inode_inc_iversion(inode); > > > -} > > > - > > >  static int btrfs_write_check(struct kiocb *iocb, struct iov_iter > > > *from, > > >        size_t count) > > >  { > > > @@ -1171,7 +1151,10 @@ static int btrfs_write_check(struct kiocb > > > *iocb, struct iov_iter *from, > > >   * need to start yet another transaction to update the > > > inode as we will > > >   * update the inode when we finish writing whatever data > > > we write. > > >   */ > > > - update_time_for_write(inode); > > > + if (!IS_NOCMTIME(inode)) { > > > + inode_set_mtime_to_ts(inode, > > > inode_set_ctime_current(inode)); > > > + inode_inc_iversion(inode); > > > > You've dropped the > > > > if (IS_I_VERSION(inode)) > > > > check here, and it doesn't appear to be in inode_inc_iversion.  Is > > there a > > reason for this?  Thanks, > > > > AFAICT, btrfs always sets SB_I_VERSION. Are there any cases where it > isn't? If so, then I can put this check back. I'll make a note about it > in the changelog if not. Ah ok I'm dumb, ignore me, thanks, Josef