linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: unexport vmf_insert_mixed_mkwrite
@ 2024-07-02  7:23 Christoph Hellwig
  2024-07-02 10:13 ` Alistair Popple
  2024-07-02 13:10 ` David Hildenbrand
  0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-02  7:23 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm

vmf_insert_mixed_mkwrite is only used by the built-in DAX code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index 0f47a533014e43..feb55b1d0cd6b2 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2487,7 +2487,6 @@ vm_fault_t vmf_insert_mixed_mkwrite(struct vm_area_struct *vma,
 {
 	return __vm_insert_mixed(vma, addr, pfn, true);
 }
-EXPORT_SYMBOL(vmf_insert_mixed_mkwrite);
 
 /*
  * maps a range of physical memory into the requested pages. the old
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: unexport vmf_insert_mixed_mkwrite
  2024-07-02  7:23 [PATCH] mm: unexport vmf_insert_mixed_mkwrite Christoph Hellwig
@ 2024-07-02 10:13 ` Alistair Popple
  2024-07-02 13:10 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: Alistair Popple @ 2024-07-02 10:13 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: akpm, linux-mm


Seems that way to me too, so feel free to add:

Reviewed-by: Alistair Popple <apopple@nvidia.com>

Christoph Hellwig <hch@lst.de> writes:

> vmf_insert_mixed_mkwrite is only used by the built-in DAX code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  mm/memory.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 0f47a533014e43..feb55b1d0cd6b2 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2487,7 +2487,6 @@ vm_fault_t vmf_insert_mixed_mkwrite(struct vm_area_struct *vma,
>  {
>  	return __vm_insert_mixed(vma, addr, pfn, true);
>  }
> -EXPORT_SYMBOL(vmf_insert_mixed_mkwrite);
>  
>  /*
>   * maps a range of physical memory into the requested pages. the old



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: unexport vmf_insert_mixed_mkwrite
  2024-07-02  7:23 [PATCH] mm: unexport vmf_insert_mixed_mkwrite Christoph Hellwig
  2024-07-02 10:13 ` Alistair Popple
@ 2024-07-02 13:10 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2024-07-02 13:10 UTC (permalink / raw)
  To: Christoph Hellwig, akpm; +Cc: linux-mm

On 02.07.24 09:23, Christoph Hellwig wrote:
> vmf_insert_mixed_mkwrite is only used by the built-in DAX code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   mm/memory.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 0f47a533014e43..feb55b1d0cd6b2 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2487,7 +2487,6 @@ vm_fault_t vmf_insert_mixed_mkwrite(struct vm_area_struct *vma,
>   {
>   	return __vm_insert_mixed(vma, addr, pfn, true);
>   }
> -EXPORT_SYMBOL(vmf_insert_mixed_mkwrite);
>   
>   /*
>    * maps a range of physical memory into the requested pages. the old

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-02 13:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-02  7:23 [PATCH] mm: unexport vmf_insert_mixed_mkwrite Christoph Hellwig
2024-07-02 10:13 ` Alistair Popple
2024-07-02 13:10 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).