From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CEDC3064D for ; Tue, 2 Jul 2024 15:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0149D6B009B; Tue, 2 Jul 2024 11:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F06E16B00A1; Tue, 2 Jul 2024 11:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF5846B00A2; Tue, 2 Jul 2024 11:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C34C06B009B for ; Tue, 2 Jul 2024 11:42:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 70A84A0358 for ; Tue, 2 Jul 2024 15:42:23 +0000 (UTC) X-FDA: 82295229366.15.35E67A2 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id 6E651A0020 for ; Tue, 2 Jul 2024 15:42:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719934916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rmhnRDzOiOoE2+hEwbEsrwmZwoSFQvUchGPs5r1DTi4=; b=7f0W6Jc2uXgCayFU9nGoPt1ow2zgrTi+3/itsUJpbNQLJkawBqlt1UV5kVj2aVdMOPdq13 gDTYQVL/K3H4N1xh372ZDC6aAbnfyx3tUdeOM03d7MyT0hz408CtJGeWMg7Of+ZeDk649o U5s6IGpEQ6+E5n30y14f1i85Q2X/Wq8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719934916; a=rsa-sha256; cv=none; b=Dkju8022FRucuM/lz3y/ONY5TG7L5Q0jl1RMGXyJqbMMNSxINZasOMDsDj/6LRKY3mLXbD 4VFN7EgSasFl10PAo8ZTqHXWW0NSHvjhPgkLdp52SYJ5j6wpGBWAHKlXpDpNvx65WXQBBm 8qj5koTp8K8Mn/I6AcjkoYwqErJ32Dw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 77F3668BFE; Tue, 2 Jul 2024 17:42:16 +0200 (CEST) Date: Tue, 2 Jul 2024 17:42:16 +0200 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: Christoph Hellwig , david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, Zi Yan Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240702154216.GA1037@lst.de> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-7-kernel@pankajraghav.com> <20240702074203.GA29410@lst.de> <20240702101556.jdi5anyr3v5zngnv@quentin> <20240702120250.GA17373@lst.de> <20240702140123.emt2gz5kbigth2en@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702140123.emt2gz5kbigth2en@quentin> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6E651A0020 X-Stat-Signature: wh3jagffcy7c7o5ifk7996h8qzmb6xo1 X-Rspam-User: X-HE-Tag: 1719934941-908174 X-HE-Meta: U2FsdGVkX1/UfYoBdchvAXFkQck7+lgUvhDEBf8Rv2ZDMWKkRnH0Lsp4ARuBiWuX+BJZ907G3pcCdNeEd42+rED6qCPMVhap6bST2hdknfzSMQSmZrHMF5VShjUtx958nrQM/B/27JFHTne5M6+/S7/hGkdEE6Cu5Qcx1ruAoojD1debU9Eb9GImOdiJdQFX310d6LF4LShmQLYic+RvVUiJYZH3lAH9x47DTgzaF3vrOsB7jB77/OAXW3pxtOClGe1N0SkHbR3JRtEO/2nsPUD3lh2mvaGlS3n/8VvTRrmDFSSra9Aa7mBTy3+7JdrOjdQfG/NwDjAhdLa6oNHmrT6FrsjjJfMd+QIzkK9vpP9RXF05CBRrpg55PcmKd0HJW5Ryj+BiqGW7OVqT86C7XoOXnt1WRmm/Y0mboJ6NCAAdhcTj4/tpDIi0RCWcWikFn9esweh7FIyh/4cRQ8aVWy4mYpOS8OC3TvPNc7QYWNBCbjQClwRiJnKu+LPf3Sdi04+tBVrEM879TgDPPuakTcT2m+HFJwfuGhxAI0FMTqteOz0orjhHXXyYMlq2KdlTK35HOdNbWoJVuaRmo/88lD57Dl9NuACGz2Hv7Nld2F3bQdhr6PR44DyypENvHie0O8qrHOCBnEthMCy6ki0h7mQdCdNIk9zi0/jqjgyqmUGAPQdC2kK3U/5D0wqR8YsTJyaGy/e9lJCYkSUlgdnHLNEMl3Y3w869gnsaMUNjI0twjvL9QttW0DrkIChwWI9imnLC5dK1SqXwSuqSojOUb7IT5+oEvv2fH1eF2tj9Bh+xd0tmEYWvSwO/ct2RFVC+whoNsJ20/8oazdeBbUdL5OTh6xJYMbtMeUgX7E97uFEyKXFJOKsDam9yC6u3XdCJfOLuNnJ8nA9IcePgCXot4ejKX4PmcorFPE3qRDqkZYW85Hf6RRBT7U9ouG3Is3XlQVdTLmpMsJkU11oYBtL KTukuTvo u/ukbZT+8Ls9lMoGJjgUVgeu6qD/TUUgMZiTzM9+6+y0FX9rWIA0fqp3OtsW/VcQvhHq1qHolGP097A1GFf/DiWCkTk6BhSRB49GAk4oH+pC8KUMBGGSlGjp7tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 02:01:23PM +0000, Pankaj Raghav (Samsung) wrote: +static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > loff_t pos, unsigned len) > { > struct inode *inode = file_inode(dio->iocb->ki_filp); > struct bio *bio; > > + if (!len) > + return 0; > /* > * Max block size supported is 64k > */ > - WARN_ON_ONCE(len > ZERO_PAGE_64K_SIZE); > + if (len > ZERO_PAGE_64K_SIZE) > + return -EINVAL; The should probably be both WARN_ON_ONCE in addition to the error return (and ZERO_PAGE_64K_SIZE really needs to go away..) > + ret = iomap_dio_zero(iter, dio, pos, fs_block_size - pad); Overly lone line here. Otherwise this looks good.