Re: [PATCH hotfix] mm: fix crashes from deferred split racing folio migration

David Hildenbrand
2024-07-07T08:29:00Z

> [I guess this is the wrong place to say so, but folio_undo_large_rmappable()
> is a dreadful name: it completely obscures what the function actually does,
> and gives the false impression that the folio would be !large_rmappable
> afterwards. I hope that one day the name gets changed to something like
> folio_unqueue_deferred_split() or folio_cancel_deferred_split().]
Fully agreed, that is absolutely confusing. (and I thought for a second
that the folio would be !large_rmappable afterwards!)

--
Cheers,

David / dhildenb