From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85525C3DA50 for ; Thu, 11 Jul 2024 13:53:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C88436B0095; Thu, 11 Jul 2024 09:53:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEAD16B009A; Thu, 11 Jul 2024 09:53:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63C16B009B; Thu, 11 Jul 2024 09:53:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7D46A6B0095 for ; Thu, 11 Jul 2024 09:53:56 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C5651A0659 for ; Thu, 11 Jul 2024 13:53:56 +0000 (UTC) X-FDA: 82327615272.25.F9194CF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 62D3D1C0021 for ; Thu, 11 Jul 2024 13:53:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kBffDW30; spf=pass (imf20.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720706018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7e6ltjzkRi00iCNIapk4UNSH8x4s2oZWxEjzTm6xxis=; b=4WARMnG242MgAQYe3FXVjt+X6TvPN4nzCAwBCmmGLxL+9Uoj/Za5WNoFmKYmczvQ4zngLP WpT1jlVpCShGAU4orsusxmLQg2N6Sf3tlXw4yEB7xtLo7Imly4ZbtnmA26ybGPs1m3Z9i7 CiYYEyHoOKpYT9nbrpsquWQHpH+eSW0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kBffDW30; spf=pass (imf20.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720706018; a=rsa-sha256; cv=none; b=s3++tdgU1xVlyHmv0GTOOppt8ldeuqzAha8eDkvlmG+uuyZ8OAafD8VjeqIlCxbtUrWZP3 wxEUU6aeLvcdp80ZLpPTa2IREdROs4p3LKawnwCvbs842tMpU+QlOLRtXxHqajkxd2U1hH WTKK7O58hLb84rot+lWZWXBcegrGzYE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1475861D43; Thu, 11 Jul 2024 13:53:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23420C116B1; Thu, 11 Jul 2024 13:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720706032; bh=d7eUnvpmqA007vMePeAhiRZGhhclqfU3sA2rSd2dSGE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kBffDW30SyBlZCqOGULzop3FoMuyN+QQ5auURLJHQ5kfGcoTU9L9BiiUyfwL0TSaQ 9FyJbO7q3Taqqe/b01urzCCS7eNXube/zETixa6xqPWAxNw0y2W8zPBksMpugkp3Xh LqCNUaKK+sijkltj6+6l3z/RDT8/JrIY4cY7mpsMXX8m9k3JFDhWxB7BPzXudK9MYL QXuBppwEKWmEaJnzivH29zNXl9lYQi4m0+phrN2TkuSEQAdR6LufjZtHVNOyNZhskw 5T/LmEct54eHM00gSnnslvBpv1DEFb/gsyCCQQ8a23/HuBXF3K3hL+AVQeIDVE8YMR J6BbIo9b7etPA== Date: Thu, 11 Jul 2024 15:53:43 +0200 From: Mauro Carvalho Chehab To: Tong Tiangen Cc: Mark Rutland , Catalin Marinas , Will Deacon , Andrew Morton , James Morse , Robin Murphy , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Andrey Ryabinin , Alexander Potapenko , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , , , , , Guohanjun Subject: Re: [PATCH v12 1/6] uaccess: add generic fallback version of copy_mc_to_user() Message-ID: <20240711155343.3729bc30@foz.lan> In-Reply-To: <20240528085915.1955987-2-tongtiangen@huawei.com> References: <20240528085915.1955987-1-tongtiangen@huawei.com> <20240528085915.1955987-2-tongtiangen@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 62D3D1C0021 X-Stat-Signature: dmtxcwns6y4qztht5oo7ts45y1ztn4hz X-HE-Tag: 1720706034-356971 X-HE-Meta: U2FsdGVkX1+TT0RKW68OInR3z7+K1/Kh5qwAq/skwgptCJdnwBy9GsB/PVKjjJ8cNmNx/JIi6ylwc97YYWr6oUX63pAUAMn2IqQl3AatGZMzxhZVzP1NnmzZwkg+aQBdGfKY9LicWRsyrMD4vEvkbocoAXFkECeKs7GYMssVtto1Sg6jWolsCFujtijJWejGD3heOxf0SQYOsqjZZ+BdxD14eTmFDVKfFwOZ5Fi/0mQW3FH3ARO0u0nQI+EbG/oE8bmleHLoeAcis+fraFWQ23nXy88Sow5hiZj/GEw0MJzkZqquPkhzhtKoMYFFHowV89kGw9wM24YpC+3VoNPPMH8SHA3hNPxu41QkyykMmYE8CjNjt7gStweyMA9o+1mvK294W7bfPQMyVrtBRfKiQ48L49FpSdcSSdCk0l7PFY7EGAqeQ35gYMCK9qK+W0qKK7Ek+jajg3TpuF3056ohoq5tF9EjOTocngl4NEZ0UnJGe/RhDt5xvAKsjWynSms3JaZ8fEntk28C5BFMbLqSjEvw5gdQ5QltvjmGNtwUdci6llsrThHJzBxFCHDUUjP+8zvbPU5gVwNHu9V6/JhP6ZC4jslHUuVUXHfoxHEFyCGZwssfKupRtT6lNJrQ+IgT9iCkg0xWmdV6yCalm/TD18G8cYR2X2mfC1ecBE8Yw2gB5wfKWyfPbswT9BkogoK2Z08/sAPzCh6sdfAow/svDMh57z3VgMSrFXLEP2OgBz/bScqkfjs2akzMYkOJze0LW9ppb0db2hymr/pAWjBFtapasl6NWeIaraWYraasZ2qutS6HTs1wmGaBMJUQyq3s0865st1ERPUVRHRFpq0uDxlPRYkMLKWyc7ZFmrkAUwQxWcPKgpLSVSpqxHzyc54QYcfAXjxQb1vrJSbSlpNFGG+U6vrQjJsxdLwEgAzxzl95nbBMlU5g8/g7bCsdonhzhDZ9k9yQmYv4ZZs2dgc IOR2gGuX 7fOqKbzq++pBjrEske2pOzZx9pJOLm0vssKD5u0GEjEsxkGbRbd3t0T9RLyg+qDqxShHi7ob5AYQcnDxmwZ8yoEswwDkn9PQK6RJ8Ci/05JWulaZaodvK0K6ikKu1uuKi9+iegynKxtnvX1lT189OjnNObDcBDC+Z95CM3/NyaJ4xsaUcjCtMSnKEA4K3z5PypGitT8y/rDydlSd5ikM+m/2YbaQYa2O3lkvIyXvp9f7Zf5yRF2wZRbnJFZZ+/fea/XdVgmFCfOl43vhr3IrBv7KBkk4XkuHfTZYRRUnMq+fiF+SOfoxfnqBa9xgY94vvC723sn5MpU3Qd/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em Tue, 28 May 2024 16:59:10 +0800 Tong Tiangen escreveu: > x86/powerpc has it's implementation of copy_mc_to_user(), we add generic > fallback in include/linux/uaccess.h prepare for other architechures to > enable CONFIG_ARCH_HAS_COPY_MC. > > Signed-off-by: Tong Tiangen > Acked-by: Michael Ellerman > --- > arch/powerpc/include/asm/uaccess.h | 1 + > arch/x86/include/asm/uaccess.h | 1 + > include/linux/uaccess.h | 8 ++++++++ > 3 files changed, 10 insertions(+) > > diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h > index de10437fd206..df42e6ad647f 100644 > --- a/arch/powerpc/include/asm/uaccess.h > +++ b/arch/powerpc/include/asm/uaccess.h > @@ -381,6 +381,7 @@ copy_mc_to_user(void __user *to, const void *from, unsigned long n) > > return n; > } > +#define copy_mc_to_user copy_mc_to_user Such define looks weird on my eyes. What to do you want to do here? > #endif > > extern long __copy_from_user_flushcache(void *dst, const void __user *src, > diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h > index 0f9bab92a43d..309f2439327e 100644 > --- a/arch/x86/include/asm/uaccess.h > +++ b/arch/x86/include/asm/uaccess.h > @@ -497,6 +497,7 @@ copy_mc_to_kernel(void *to, const void *from, unsigned len); > > unsigned long __must_check > copy_mc_to_user(void __user *to, const void *from, unsigned len); > +#define copy_mc_to_user copy_mc_to_user Same here. > #endif > > /* > diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h > index 3064314f4832..0dfa9241b6ee 100644 > --- a/include/linux/uaccess.h > +++ b/include/linux/uaccess.h > @@ -205,6 +205,14 @@ copy_mc_to_kernel(void *dst, const void *src, size_t cnt) > } > #endif > > +#ifndef copy_mc_to_user > +static inline unsigned long __must_check > +copy_mc_to_user(void *dst, const void *src, size_t cnt) > +{ > + return copy_to_user(dst, src, cnt); > +} > +#endif > + > static __always_inline void pagefault_disabled_inc(void) > { > current->pagefault_disabled++; Thanks, Mauro