From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0733FC2BD09 for ; Fri, 12 Jul 2024 21:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13E336B0085; Fri, 12 Jul 2024 17:09:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EE246B0089; Fri, 12 Jul 2024 17:09:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1EA86B008A; Fri, 12 Jul 2024 17:09:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3EAA6B0085 for ; Fri, 12 Jul 2024 17:09:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44A7BA2E07 for ; Fri, 12 Jul 2024 21:09:30 +0000 (UTC) X-FDA: 82332341700.30.C0F7A83 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id C15DEC0006 for ; Fri, 12 Jul 2024 21:09:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Z5dFQlJE; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720818530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SKcrxb0sb8YK4AdzuMU9z74CgiVPq/rDrzTn2MHUx5g=; b=KD12384hR7gWLwplSR2EXq9yY7MrPR1Rq8mTnJ1+aQJ0aEYAXl6RWVmbkAFhlTvXbPhlzh Miyx+p6d1UexrI8EVT0Jl/3aqfbf/z++ldX4fPjcigCXEH77VYDd+GMrPbx9TY4MV9q/uj d1TvrSFN5sBdUAZq36pTbub42fiLnzw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720818530; a=rsa-sha256; cv=none; b=Ak6pTIcXxY3AH5OmPnNdeB3Z3xoBjeHpaWivHas5nTLZ3vHWpTf5mQWejn7V3glbQeaM9f NmiMUI5TiGnjQ0OjXFLmiOjuqOaQreeSBFsb0ewpU9XPwI76xcQ1p4/WxsG/E7M1Jt9G0Q N5bYOYojFBM9FXjBIieb7jUb7qnRWX0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Z5dFQlJE; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 09117CE1381; Fri, 12 Jul 2024 21:09:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2976FC4AF09; Fri, 12 Jul 2024 21:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1720818563; bh=R274oE0i6C8f+zj2r4ya+8raQGqMtavQcoAxIuhk+o4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z5dFQlJEQZ5wQfYBl99RcFCGNf/3DQY5ic+0EOdONPRQp3/avV6RRICnHA2x8mMAE 8u8dWV0GEaFuWWgbsTkl3oJ2kNTmzQ0dDvrfvlKhliDGb3mhAMJjLInZ89U73JSaSg A9MHPJTwJG375Y/ixCHg/rAppIhzvJBEP0COpoAA= Date: Fri, 12 Jul 2024 14:09:21 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , Subject: Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory Message-Id: <20240712140921.9aa90b18d22e67417d59dfc1@linux-foundation.org> In-Reply-To: <20240712064249.3882707-1-linmiaohe@huawei.com> References: <20240712064249.3882707-1-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C15DEC0006 X-Stat-Signature: 6db9kytpykcd8arp3umjbdmzykfpmdnt X-Rspam-User: X-HE-Tag: 1720818567-95595 X-HE-Meta: U2FsdGVkX1/VmCpfx41RTLb5JELYb8qg9WBzlMryLtYpwzYAkcnWjw3CT9Mphn1Z+jqSziCtAe6uG4G2aHCAHY4t2WTPWK55mxdANqdRo7RwHLZdgcMb30kbb+IO+l8ITnr7Qi4EJBOP1JyEM4a0ZWvxJnKSW3v4ZuIjuymeblfvlfq08yG33LLZqyDhxmwqXi0fTQ3ILR314AveUFlLLbphnvsdj09khuA/CndG8zU/vsku8rxw+I+zexF8Lwk8x+1lbTLDETGJXiYyWLDUF+Eqzw5EYXk1N7lC7mfmeUu/wej5vub8i4l9T1U2FRdAuZOv2JYj8okmk8AqcWFEzbP4Y1oUt5rkV7Yugiop9wuhISLRF+JtXTaP06k7r6HBHICKeGwa4KqMUACrrOfTNnQUBQZiFV1ubxOxUnMc1IPzsRPAYy8B5u4TCLEnJTxg7jzC+N/UXrk8/ti5HLJ9mYVW0+hare9WIf2VuPHDF1keMJGBDXl/rkR55mU8Oa52n6VAlRFqJtjSGY+ozGgeVohlnZFG39gwrRrBycJIDyXRP6vjmVTzLV1EZvRsw2067TPJXP4AmaH6cx1cZmNIgL31FW94UbGsJEoo2vqeDTNBDVbZG1fxoFXwVqrI8L5CX+Kd061Q21l+4oxLeZuwd5uJaRDEqx6nJFLHJ1MwgwyCqCErXMFVGuBLryVjhbffE0YuIu0UezCq6FqIIhVTpsnJasgdaA/uvFBxRvC34akRynkE4q8dQAefLHZ85aJCtfcz5Eqi0nAf7c22GDd4+LvB37ZIOP+iT187jjGNyOKHaf9mWsq/MP0umV3zFLimmVtN/gDvX8Rm5sXBy+R44K9csyv750qmooZ+mApWKE0ZfxIF2zkqdJ6Mzwzth/80mH9Z6MCE6OWbKqI4tkd6T3WzVVZbX5ZVdGlOLXpbLvhx1cxD/69RZR6UohXevNnm0kX62Nc+UiSwImwLmqs k0p9zR/g O6Hi5X7THrl40njqZ+dQ496mMLXlYBaVNB8tw4uzmtC1My59w0VK87D82fBZHle22SNy0LbCsnQ09iP6ImSU3pi1yORTwolfmtVkF4HVpBmwFdhZTwcZYGd4AfRFnmPByDDSsN1bovNhzFMlrNikiGSQ2qNgTaUSYpAPJQJ9Tm5wGMzdnMFMMHLw4ZTEz6wK9+QQrFbuZJ9/tcVu7H2N2L+RSD7xaA0ZaxtLqYwnkEnddvFVxdc3eCXVYfV+ApeIbC4zm8mBP+p5a4heVmEaLnkn6p0SCFlzqy+t6VHqOgZDobQbrd7vn4a4xCoSc3nDnln7SIvp/8vuWQpTn2wYoybrtlaFiA83Jg3B3L4kAM0Rs010= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 12 Jul 2024 14:42:49 +0800 Miaohe Lin wrote: > When I did memory failure tests recently, below panic occurs: > > page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) > kernel BUG at include/linux/page-flags.h:616! > Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Call Trace: > > unpoison_memory+0x2f3/0x590 > simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 > debugfs_attr_write+0x42/0x60 > full_proxy_write+0x5b/0x80 > vfs_write+0xd5/0x540 > ksys_write+0x64/0xe0 > do_syscall_64+0xb9/0x1d0 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f08f0314887 > RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 > RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 > RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 > R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 > > Modules linked in: hwpoison_inject > ---[ end trace 0000000000000000 ]--- > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Kernel panic - not syncing: Fatal exception > Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > ---[ end Kernel panic - not syncing: Fatal exception ]--- > > The root cause is that unpoison_memory() tries to check the PG_HWPoison > flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is > triggered. I'm not seeing the call path. Is this BUG happening via static __always_inline void __ClearPage##uname(struct page *page) \ { \ VM_BUG_ON_PAGE(!Page##uname(page), page); \ page->page_type |= PG_##lname; \ } ? If so, where's the callsite? > This can be reproduced by below steps: > 1.Offline memory block: > echo offline > /sys/devices/system/memory/memory12/state > 2.Get offlined memory pfn: > page-types -b n -rlN > 3.Write pfn to unpoison-pfn > echo > /sys/kernel/debug/hwpoison/unpoison-pfn > I guess cc:stable. It looks old? Can you help to identify the Fixes: target? Thanks.