From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B60C3DA59 for ; Mon, 15 Jul 2024 20:03:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 661AE6B00A6; Mon, 15 Jul 2024 16:03:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9766B00A8; Mon, 15 Jul 2024 16:03:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 464916B00A9; Mon, 15 Jul 2024 16:03:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 258786B00A6 for ; Mon, 15 Jul 2024 16:03:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C58261201D8 for ; Mon, 15 Jul 2024 20:03:30 +0000 (UTC) X-FDA: 82343061780.14.DE4A273 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id 72245100025 for ; Mon, 15 Jul 2024 20:03:28 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aRzfJmjH; spf=pass (imf14.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721073789; a=rsa-sha256; cv=none; b=CJiNGNK4inz36kosed+3E1AGjWw3SMmevxj7FQiY3BTXj0kjzgdu3IiJ45j1oPaAFOFzOg 03DnQPhCC12OnCRWgtOXPmyiAfGWejoTLlxYm5k0jTSvdSMTZHrSo8SF+eYoVvXGjOpNQU FlyaHnsLePcZo5DFdnM/tglIbRMh8Mw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aRzfJmjH; spf=pass (imf14.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721073789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rrp5+2a/xTj/X/nvw0rWct0kGYRLxgnozQF7q9iOQ3Y=; b=nBA6IR8kg0XzcP0+XedYgkB7+y6MjCamqFLtJyurXGy+WFtKMeOd2CbcZbwvjx1ZIUkX9J IE+vb6hQBXlYaIU65peKrOJjbh5sHN4SW3Wjpl1t2UjuUY4qFBKvmqKw1WVNpNonIh3NYq l0PBrj4P+GPaRoH6LGO5RJ0QdQM622o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 13CADCE1084; Mon, 15 Jul 2024 20:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F086C32782; Mon, 15 Jul 2024 20:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721073804; bh=/Zg0yBVbRvz4OSY+5LyFA6p9wzvvYuCeQk25LMcp3jM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aRzfJmjHdW6qNA3cyoNXUTnfj2hs34xZMKKVQRqAffGztJrQz3hrZJVcIoixD2v0/ DeIUro2JZTHRlqZ1+/vX9EWgh0gPSNHomHXtt3Ywkx3rjes1cifADjfr55jctIeEO8 9stXoG1gYIKekPuFgjTbYS1Q7j2/sI1Ed3ZJ36JJLtIqH0vHCa6XYT42TXUyJXY9yb pPAGa4KVCTFJMlgdfmPypPI+cNat7X5DJS4TyMDXQUg1DE2NKeCxKeYMgD4UhM+mkW 75PGYES16ARrDrvIGTr4cp2Syxyd0adIbc9lG17rdW30cG9zazH70KDxdDYKnqsrCZ YRpXUX8GBGcsw== Date: Mon, 15 Jul 2024 13:03:23 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 3/9] fs: add percpu counters for significant multigrain timestamp events Message-ID: <20240715200323.GA103010@frogsfrogsfrogs> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-3-48e5d34bd2ba@kernel.org> <20240715183211.GD103014@frogsfrogsfrogs> <7bb897f31fded59aae8d62a6796dd21feebd0642.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7bb897f31fded59aae8d62a6796dd21feebd0642.camel@kernel.org> X-Stat-Signature: z9w8ahjygamrh5k5rn7gus6gsqr49tsd X-Rspamd-Queue-Id: 72245100025 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721073808-310202 X-HE-Meta: U2FsdGVkX1/DUE8RweDcf2d/aS8XnhFigZS2oyWfxGtMQhkyWctm0trjHwgbkhALc9JL1IOVeENo5m8I44Qwqo3TrMKsMJ591WTazz09nnl4d6a57HCkLqPYiyqAI4c3ioJckpwNeo3ZSBkSijR1dQPeh1qpkQcpj0XLwPGj0gzScqFgpg4GZ9uoxz/Gh8imL55xCMGZaDG3x5yYZ4Rsm56mQ1poMkZbG8NNWZuEVMuZJ3vVjgHqdsjEW/Irm3KFqyddSzZxIqMXnlxdRec3S3iN1+d2E+5QbCapYeW+1kIhM8wTr/lDNRlJR4qSP3GDnUM4mKvlr+vztiJJ0mGmeXvCgTgaYAJAREBQOI9lvSFNfi9LsWaTnyTl56bmTF4dSjCaJQLN05OkwpX50flH45F2CQm3TG9W2rJ3/e89+IrS4v57H0Lq8bybhf+K+pP+T8ZB95gCL5PUzdCqkxPz39t32MkkrWbg1lyDk7xkOdfWan5P0FoiZMs8ODscydkvioSTQAkrgZyk2fqCV/O+d57Yd9pPwSYU7/uZLNt05AT04FFIXGst50UlEpj8VMDHouVYOiJW9Wf6IcJQoz/6/4KhZbwgjAs/Q3YjPaR5exuzNUOvXHXG2wU88A2D94Gr129GsybXoqmA6g6axkJ+5QpOpdwsh1QKoTROOjCs/vbwaflIY9I2X5QeDEkIqsKP+wVRBfPHuy4FDN0uQffbUgN2W9diKLznunPTfMOC9NEXsKcmGiu16hTyA2JGGu37U7SC4MLzd9pz5METTCIPHLgy2ey2uZPBesRPsQpXm/OeeWrRHHBWNavAuieoOxRjCA827/VbSAVDkXKY/TlNtRziqbaRTfHHP/GCG6QrqWs9iimKoasCh2bxD2mWznQh5LTtSh30isU08r1tN9wFXQI87FtljijMYtBeUL7iHopC6C8MwnsO45kNnV6tPxt6fViuuwZZhCAD5QXbNIb mFJVJPSo FTyAdKOrqhMj5lZWybX20wbq8oetbR1yWoc1spFo4bqBAzg7tgm3tyvdSC94BlvyDH+48SI3GquYiS77PmcrK3m3KooTnclfWypLbli1mg/31FS/5W0zy9SSM80jgJy6EUdFYjNHNwNpOrOPc/0VaqOjn/T464H5wi7Fvuqn/vlqRJjjRT1yo9cpUQaBn/nkK6IuVt0pH5wF7asJ/FU5Dj3xX8fQ7uEikO4AQohMAXdx5Xa0YTy0rUc0BeoM0yVJ4omxxEK6swuVdk5c9KLTxGIt3z9IXjBgGUy86uAlK+f4hJQJH20Kx12jJg9PgyNg3oscVoXZP7li5suBd6pd+2FYLCf+wqfCAx32aw5m41kK0j1o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 03:53:42PM -0400, Jeff Layton wrote: > On Mon, 2024-07-15 at 11:32 -0700, Darrick J. Wong wrote: > > On Mon, Jul 15, 2024 at 08:48:54AM -0400, Jeff Layton wrote: > > > Four percpu counters for counting various stats around mgtimes, and > > > a > > > new debugfs file for displaying them: > > > > > > - number of attempted ctime updates > > > - number of successful i_ctime_nsec swaps > > > - number of fine-grained timestamp fetches > > > - number of floor value swaps > > > > > > Reviewed-by: Josef Bacik > > > Signed-off-by: Jeff Layton > > > --- > > >  fs/inode.c | 70 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > >  1 file changed, 69 insertions(+), 1 deletion(-) > > > > > > diff --git a/fs/inode.c b/fs/inode.c > > > index 869994285e87..fff844345c35 100644 > > > --- a/fs/inode.c > > > +++ b/fs/inode.c > > > @@ -21,6 +21,8 @@ > > >  #include > > >  #include > > >  #include > > > +#include > > > +#include > > >  #include > > >  #define CREATE_TRACE_POINTS > > >  #include > > > @@ -80,6 +82,10 @@ EXPORT_SYMBOL(empty_aops); > > >   > > >  static DEFINE_PER_CPU(unsigned long, nr_inodes); > > >  static DEFINE_PER_CPU(unsigned long, nr_unused); > > > +static DEFINE_PER_CPU(unsigned long, mg_ctime_updates); > > > +static DEFINE_PER_CPU(unsigned long, mg_fine_stamps); > > > +static DEFINE_PER_CPU(unsigned long, mg_floor_swaps); > > > +static DEFINE_PER_CPU(unsigned long, mg_ctime_swaps); > > > > Should this all get switched off if CONFIG_DEBUG_FS=n? > > > > --D > > > > Sure, why not. That's simple enough to do. > > I pushed an updated mgtime branch to my git tree. Here's the updated > patch that's the only difference: > > https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?h=mgtime&id=ee7fe6e9c0598754861c8620230f15f3de538ca5 > > Seems to build OK both with and without CONFIG_DEBUG_FS. LGTM, Reviewed-by: Darrick J. Wong Thank you for your work on all this multigrain stuff. :) --D > > > >   > > >  static struct kmem_cache *inode_cachep __ro_after_init; > > >   > > > @@ -101,6 +107,42 @@ static inline long get_nr_inodes_unused(void) > > >   return sum < 0 ? 0 : sum; > > >  } > > >   > > > +static long get_mg_ctime_updates(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_ctime_updates, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_fine_stamps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_fine_stamps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_floor_swaps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_floor_swaps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_ctime_swaps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_ctime_swaps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > >  long get_nr_dirty_inodes(void) > > >  { > > >   /* not actually dirty inodes, but a wild approximation */ > > > @@ -2655,6 +2697,7 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   > > >   /* Get a fine-grained time */ > > >   fine = ktime_get(); > > > + this_cpu_inc(mg_fine_stamps); > > >   > > >   /* > > >   * If the cmpxchg works, we take the new > > > floor value. If > > > @@ -2663,11 +2706,14 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   * as good, so keep it. > > >   */ > > >   old = floor; > > > - if (!atomic64_try_cmpxchg(&ctime_floor, > > > &old, fine)) > > > + if (atomic64_try_cmpxchg(&ctime_floor, > > > &old, fine)) > > > + this_cpu_inc(mg_floor_swaps); > > > + else > > >   fine = old; > > >   now = ktime_mono_to_real(fine); > > >   } > > >   } > > > + this_cpu_inc(mg_ctime_updates); > > >   now_ts = timestamp_truncate(ktime_to_timespec64(now), > > > inode); > > >   cur = cns; > > >   > > > @@ -2682,6 +2728,7 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   /* If swap occurred, then we're (mostly) done */ > > >   inode->i_ctime_sec = now_ts.tv_sec; > > >   trace_ctime_ns_xchg(inode, cns, now_ts.tv_nsec, > > > cur); > > > + this_cpu_inc(mg_ctime_swaps); > > >   } else { > > >   /* > > >   * Was the change due to someone marking the old > > > ctime QUERIED? > > > @@ -2751,3 +2798,24 @@ umode_t mode_strip_sgid(struct mnt_idmap > > > *idmap, > > >   return mode & ~S_ISGID; > > >  } > > >  EXPORT_SYMBOL(mode_strip_sgid); > > > + > > > +static int mgts_show(struct seq_file *s, void *p) > > > +{ > > > + long ctime_updates = get_mg_ctime_updates(); > > > + long ctime_swaps = get_mg_ctime_swaps(); > > > + long fine_stamps = get_mg_fine_stamps(); > > > + long floor_swaps = get_mg_floor_swaps(); > > > + > > > + seq_printf(s, "%lu %lu %lu %lu\n", > > > +    ctime_updates, ctime_swaps, fine_stamps, > > > floor_swaps); > > > + return 0; > > > +} > > > + > > > +DEFINE_SHOW_ATTRIBUTE(mgts); > > > + > > > +static int __init mg_debugfs_init(void) > > > +{ > > > + debugfs_create_file("multigrain_timestamps", S_IFREG | > > > S_IRUGO, NULL, NULL, &mgts_fops); > > > + return 0; > > > +} > > > +late_initcall(mg_debugfs_init); > > > > > > -- > > > 2.45.2 > > > > > > > > -- > Jeff Layton >