From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27B9C3DA4B for ; Wed, 17 Jul 2024 07:05:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CA156B0085; Wed, 17 Jul 2024 03:05:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57BB46B0088; Wed, 17 Jul 2024 03:05:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 442056B0089; Wed, 17 Jul 2024 03:05:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 248116B0085 for ; Wed, 17 Jul 2024 03:05:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9AEF5A2676 for ; Wed, 17 Jul 2024 07:05:17 +0000 (UTC) X-FDA: 82348358274.27.A748DCE Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf21.hostedemail.com (Postfix) with ESMTP id 8321F1C0020 for ; Wed, 17 Jul 2024 07:05:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dgVPs2+6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721199883; a=rsa-sha256; cv=none; b=apnN07kh1fk3vL/VLaBd7tTDdn2eBafqVT8wcP5NALNfdniHOW4pVz8kVj62eguhYS+cqj LoZYJDdmiufsfnOriXSS2JZMByhNzZEOHki+fytsA1ATbBbZiISXZNKHaN2cTSFa5wyS5+ h1JM7DTsioc95FrMbo8uQQgsjLPuYs4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dgVPs2+6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721199883; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rrgfH9uGZhNUaTrMN9wIFZhnhyzJTPeVjbV2K06nS+k=; b=TJGoSsCXImnJSI/cZzVB2ScCCbkI3SP19KD1E4wjuwpk/QnnMLSdAC39XYHbV1g+bdbVKC QV3APBMYRfFj5+9YAC8vDzHRoTWKNHxF1QEq7NcB8B0boeIF4ZY6V8hatXZpwQtVYHnzYP s7GnOn8wT4QJICsP6C2Ssa6FUdmr+48= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52e97e5a84bso9140604e87.2 for ; Wed, 17 Jul 2024 00:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721199914; x=1721804714; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rrgfH9uGZhNUaTrMN9wIFZhnhyzJTPeVjbV2K06nS+k=; b=dgVPs2+6FtIWOryBZe0HmWvPCoPbl7W0OqVgpjrUgIb7EtB6ug/Os1n9GSPUVoAXi2 USvbOo7CO6BqzJzmd6hFIzj+PAHfkyFPKMcIQ7STlAEF0gVtLONeDnpQkJeOebueRTNy dzsuLULz0c4TZwVLWWjaEQZtG4ggZGpqdu0UfwYjIpWVqTicAk8BA/1VK/3sXI12w2NM EoUdBl84gYAwHf9Y0vdctwbVuHUyVIsBRDc89ok6e4yZ2TK/OfYDVUtU6YYKx4le13Yh ipV8il3qUuc5/y99O2Nr/DENdztwP4Gmr7nPutj9VJ/+W/FBvSYHAaHtQLHcycVYKg6z x30g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721199914; x=1721804714; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rrgfH9uGZhNUaTrMN9wIFZhnhyzJTPeVjbV2K06nS+k=; b=t/KEq+uy1SNa76vK+Csh8hwizpSNybIQ8ONavAqyqOtyRWftLFK3w8d9cJp2xsdOSB QaJ4QgajhCeeE9kMSOu35hWAXDUbqUgrOixqqEl5A1B64j9kMiUJJ9tA+fDodppxTc/i 2TK6Nj4oy/PtLUrjXb9RnhYuCwZVIsEb7gerUNSkM7g77+ZyJn/ZCexEZebNYdZ1QrFS P9rV0jVrdRy4kW1+8fOAeLsdcyLNstPHvTuMC6gW/xdoNSzs7XIc6OBINnxxjsqlKXJ9 2SCRGabaywdjrSSCPUmxTlrrUGk30wF56zQWl/J0XoFR62NdA3s+SBAakUcBVp244Cp/ TEXQ== X-Forwarded-Encrypted: i=1; AJvYcCXVWajAEB8t8ZggYEiYfMORduZERdMps6LHsk854yf54wP11F1/TS4T89IT2hX4PKi6WGXUIW4Q0M0bWOtJZ49gfIk= X-Gm-Message-State: AOJu0YwyQakKa7LgxeY5ECKWlxYcFldJfnFMe2dg2ZjpmqD8LZ71LrZK QecaSGmTN3aMnKjg/FiqpR5fMmOqMrvcckEcXvKZZQUHBxM3iTBK X-Google-Smtp-Source: AGHT+IHmUzr61BM1sOehiwVYrvAMjorQPMg768dvSuHeA3gefjtYEOSb6cOgo5GsetU7aCgPLl6mrA== X-Received: by 2002:a05:6512:3f18:b0:52c:deb9:904b with SMTP id 2adb3069b0e04-52ee53d7fd1mr630735e87.38.1721199913230; Wed, 17 Jul 2024 00:05:13 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5b8366sm405817766b.61.2024.07.17.00.05.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jul 2024 00:05:12 -0700 (PDT) Date: Wed, 17 Jul 2024 07:05:12 +0000 From: Wei Yang To: Matthew Wilcox Cc: Wei Yang , Liam.Howlett@oracle.com, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] maple_tree: fix the comment on maple_arange_64 size Message-ID: <20240717070512.giyxesbkbxdseb5f@master> Reply-To: Wei Yang References: <20240717014142.24263-1-richard.weiyang@gmail.com> <20240717024126.vwxgfnnposadxpsx@master> <20240717030313.olbztunrksqh6azh@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8321F1C0020 X-Stat-Signature: 47ihkh8gt1d6yhiz3dpkxxusjsp4kewm X-Rspam-User: X-HE-Tag: 1721199915-490902 X-HE-Meta: U2FsdGVkX1/GlH7sWL0EUn9fWjfumcyraDwLkC2mFKMKeEBPnXJiwGYUrCHa92EF3+94bP7cucDF8elWTMFDF2xautWsg8mJ7DX7LxMnRl+QkUJ+M5oW1eWvidE3A/izEF2/H5rWyQrqhDV1W/kwt1UDOpMubQREgcC3m5QXT2tBTq192fEsKtXmw4obudg+EkcRpSiMC0/ARACSia2s750eq5vam45gil6mHQlmvNOw03YHGLwPObhA/1TSfsvgA0viCBa4fDimIO8sG0qIL9W8urNMTM/2LeI4mQI688jdf5weDnN2aHGpsYI4f2xs5YOaGTqrVDb1674MIHasKR3BvLwUthfiX0f/5WFzU9ArLQ8Tj4Z1lc1v+DqHc0QG3l8w+Fp0XBvGU6v7FzXHpeQ2JppQ5gTestMJTiuMeb02dWa8KncHQtyhxvUd0q6es7xcTqpB/4w+uFzJzRRehJFIIUbu2QsD4CMydQ1v2ei3Z7CKuqK/kbnQnDiIoaDvUzkMnrn4rKkmcz0hK5ZfoR2b4Qn5tj5jVN+0Sval8Npj8/c6DEgM+Jysqp/5LHEoR5BAEHm/QLY1pkvnmosD4Lnga+XgPTAZU5aUJL+eEvSJLUV1sCBq7DuHUULi2y2FbPEJeKFbDoiOxZmsXKkknzUkfqWrrsPdP9P8y86zhe14Qp7ViuDxfuU0WkRULfIHtrlaJV/ShJ40EacEXvfo38CxDzR2ccNTgOIXnYswfA0DCbCPtCPI2ID6p/mke2cjDKfPljX3uCmI37RTEw92F1sPXkryBfulrCqe5R77+EOZkIJsHZAnB+damdJId+BfEd8MfJqKGNsWBGx6vUHemzT1Al/I5Dy0sIU8E40IAUaPQ8q13tbrv6ENpX+5NdvBmLke0yl58ci77YR1B0UCbz1m8S5ON7P8l/7YWfrh6MeH8VegSeBbX0eaIQdLlKu6F4yNGLHQth4w69f+VUL e2mDMvp2 hgOMS+k0t2DdjyIAV7xFS3+J2OAp9s4WHWmYzQZutNojlo0TGrdSLY3b8MTiJtOb74HKDZbJpT/du00YcXIfd9ejQ3d2qfgbUH8bY6xXoVK9DYMKHKU4Z/cwPA/FtTbPI3LJbE8XiF+aZGDBNuE2hoYWyq0qPXexzTwuwxIPoV/rM0fEJs43lkJ4WrJ0RsWjxqagU9HwJ6ku2Yvlozn2ezP8J4pPLZHmFRFi/8LNHzVw4VXMPuMtE6KqQOM7DsIPn5MxuMNC+cSkXa+WGs4p/Ov2aFn7TPhzIPqH8SBRy6OZ+pQSkyHXmfemoYxOIdjV+rZ/dbUzHMQUH+loN2M7JsZ3j4G5bgo2BdoZmqFmy2z3gc56OqMdx4Yqwzq8LFIJNzWYfYe3gKH9E88o8rSXKFGp5TAozVVfKSYNLuh6ksJImpcq3rVZYKW6n0RzYtSL37flcySGWC05+x7l+ZcCeZZOS6DhmUS3+a6fzNjTH79WYKmER29Duw7n2tY/C2DjWrM5MGWywEuFEpVqcIkbyMHmpE+CafVXyqCMk1ThmgMhPAT5H3JyQu+42AcXeKDXKoK5INu2UHwy4QVxEIWZfgPv1vX+zrYHu3eFW6vXObux2pKIDzIuRScBUAZS9ijQKq4NrzTx8rKEQh/c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 04:05:35AM +0100, Matthew Wilcox wrote: >On Wed, Jul 17, 2024 at 03:03:13AM +0000, Wei Yang wrote: >> On Wed, Jul 17, 2024 at 03:45:40AM +0100, Matthew Wilcox wrote: >> >On Wed, Jul 17, 2024 at 02:41:26AM +0000, Wei Yang wrote: >> >> On Wed, Jul 17, 2024 at 03:06:01AM +0100, Matthew Wilcox wrote: >> >> >On Wed, Jul 17, 2024 at 01:41:42AM +0000, Wei Yang wrote: >> >> >> The comment here describe the size of struct maple_arange_64. >> >> >> >> >> >> The value here is not correct. Fix it with the correct value. >> >> > >> >> >You are wrong. >> >> >> >> You mean the my value is wrong or my understanding is wrong? >> > >> >Yes. >> >> I don't get it. >> >> Would you mind sharing some light on what 240 bytes stands for? I don't figure >> out what size it represents. > >You first. How did you determine the new value you used? Sure. My understanding of the comment is to represent the size of related data structures, eg. maple_node, maple_range_64 and maple_arange_64. I add following code in test to the size of those structures. diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c index cea050675da2..93e77dea7f0b 100644 --- a/lib/test_maple_tree.c +++ b/lib/test_maple_tree.c @@ -3645,6 +3645,10 @@ static int __init maple_tree_seed(void) 5003, 5002}; void *ptr = &set; + pr_info("\nsizeof struct maple_node %ld\n", sizeof(struct maple_node)); + pr_info("\nsizeof struct maple_range_64 %ld\n", sizeof(struct maple_range_64)); + pr_info("\nsizeof struct maple_arange_64 %ld\n", sizeof(struct maple_arange_64)); Then insert the test module. $ sudo insmod lib/test_maple_tree.ko [ 152.152382] [ 152.152382] sizeof struct maple_node 256 [ 152.153043] [ 152.153043] sizeof struct maple_range_64 256 [ 152.153561] [ 152.153561] sizeof struct maple_arange_64 248 The first two is the same as in comment, while the third one is not the same. The 248 for 64BIT comes from here. For 32BIT, I copied structure definition to a user space source and compile with -m32. The size of structure maple_arange_64 is 256. This is where 256 comes from. -- Wei Yang Help you, Help me