From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEF0C3DA60 for ; Wed, 17 Jul 2024 17:17:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB6BA6B0093; Wed, 17 Jul 2024 13:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D675F6B0095; Wed, 17 Jul 2024 13:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2E7D6B0096; Wed, 17 Jul 2024 13:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A6BFC6B0093 for ; Wed, 17 Jul 2024 13:17:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1E34B160B9F for ; Wed, 17 Jul 2024 17:17:02 +0000 (UTC) X-FDA: 82349899884.04.1ACA99F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 9AE93C0020 for ; Wed, 17 Jul 2024 17:16:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THGtgR5V; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721236600; a=rsa-sha256; cv=none; b=Aqn5pGju49+A7QrzydzZpEBSiTazyJqdVN5gXt1ABqzyvU0mvKiEiG+vbMFN/5swhbmeI1 kcvbr/O9C4eAjdf+/DTbf35r31NZ5dqbaNBvidL+GDjcQu6omFtydrLyl082X8tu3K8jaZ 0K5/dMX4zxpF4l+0EuPjm3Dn+SneYuM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THGtgR5V; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721236600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2b8sJmSZMA/oYCAb20tBnSwyfirDtKWiQa4h0VWjCcA=; b=dZTAfiNIk31Mi2RvNct8hkTzntY99YDeFHG39Jht2GssHCNVRkZVOYK2GNZHmbEdDTtF93 ZhLdv4jlFk/WWJQI/m7AQKHFbYlLCRqPFFeovUUsRFzGjA39NVcLnW6TqZp0oaCGZEI9VE gWPCOZwz3PsxqE6gMCy4NlnmfIDvnMs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 844DBCE17D5; Wed, 17 Jul 2024 17:16:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25625C2BD10; Wed, 17 Jul 2024 17:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721236613; bh=yBRi4wphUoMe/4Zy6VzuKVwA0LEFrw39GK4vniN0oPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=THGtgR5Vlyrids+YPWcn3NUkai8KXh6dmNQet1PcEEn/3Aj7VIMCMsVb0ELsT53WR KhxXdkDEuf2rAwT3skCTBPCj/Rlj3DMmiPodOtyOacWmkqjVw8PI51q6OAfgqu4y6i CIPDJSg2uW8ABw/XwsQ2RKDS8qmVsMXmH91TD6ROHhQiqwRjdzMNLctiiRFAykULTz /k0g5UgWEDtt8XfLrsQi/eiLIr+R95V76NtI2HCx7kZAhvGAx/4quyvulJvuc86VJn KwSnj0pl/wa+psNh8M78DNjG/hsNk8P2963m3gWolN1ko/tlMSxEFrWr9HuReZRILu q/FjeneGOUa9A== Date: Wed, 17 Jul 2024 10:16:52 -0700 From: Kees Cook To: "Balasubrmanian, Vignesh" Cc: Thomas Gleixner , "Balasubrmanian, Vignesh" , "linux-kernel@vger.kernel.org" , "linux-toolchains@vger.kernel.org" , "mpe@ellerman.id.au" , "npiggin@gmail.com" , "christophe.leroy@csgroup.eu" , "aneesh.kumar@kernel.org" , "naveen.n.rao@linux.ibm.com" , "ebiederm@xmission.com" , "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "Petkov, Borislav" , "George, Jini Susan" , "matz@suse.de" , "binutils@sourceware.org" , "jhb@FreeBSD.org" , "felix.willgerodt@intel.com" , Borislav Petkov Subject: Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files Message-ID: <202407171010.DC51195@keescook> References: <20240712094630.29757-1-vigbalas@amd.com> <20240712094630.29757-2-vigbalas@amd.com> <87plrhshdl.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: d5edu1bf9dgmg8u7a4yfng5gm8koopmz X-Rspamd-Queue-Id: 9AE93C0020 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721236619-706336 X-HE-Meta: U2FsdGVkX1/1HYQ3hfINvhMHxrgoXqndHhasyyuPXeG5T2G9Cqmermy60+5fYHlxGm2kFqTnyxkXY7EEXg/ggCYeOomz3ne4bZ2LaGFdjwkjfysGoG5F2JBZwH36RjhGm5OdlnF1ruOh2FlsRHi5/40X3n9VrlmPRMM7D1FAWCLDdafpAighM7BAkLQJ90L7bwMLTUFqCj0t0Zv9VVQPrjgn4elMmT9JuONFQioeR8/xIo0k07Ru3gIAuBsuI543+L1GVxfjw4eX8ri93LCd5xbpGvbZNoa583XdyM/7IdwdwTjMCbnk8ZpTy+/3Zl4xkIktre+k184KFfqZ9dU8e81hPS/lM0msq4Pz+8N+KfI70ikN7letqGAPoObJN24N2COz+jjlj92EuPGjm6zzxJrUCbhs/frRy+hozyvsxTbYMG6QZyo3uGObXWwJAXTNzFhckfQM/N8yhENJ+7FLxkkJNtGrJLWiw95hmB5izf9y1LQFo9wGnYkiExq4GiKzNMhecye+VcoiRCASZbGjKxjsh7N5D73TabcEwpZrlm9LHUTlLPfK5iRF1Z6imbZjZ1ggKg+XSWpy6KjVQ4cOqGp2bdmzSxfEz2SM2SpyJWpeXSToSzg+klbTpLpX7/5x9dT0yBZBlveh+bAHZQD9eSq0ZQJS+kkY95SVrlPxnvdT7140ibQ5Em+J6XlwsNqrbaZ/XTdWXTKnJWj5jdLir9PHTYI1j/f2cavHFHj9b11wFkoEpk5f8MfvE2xooiQLYLYiCaE4KSWl+DMMRMJUUU4gIs6BWl2tr55mnoj5pkOoVklQVEzVbEqNu2GdLpiwBdd1ZBNANAL+sPTL7OZsFubQXh19D3J3ACVhYuGTtoykHrHOPatPME8nA0PgKsm9UrT9GEzmfjmu+TQkJK7P+uKrqMwlnMWH9zQVtGJYYlc+mA2frB6IwGhaXFilL8NErAWXftviVJkvJeaA8xy PIpWT5wB UWDOdpdyLLnLuhS3CF+/tiFOQlVi+lONBcKONTe8GAgNqs7kdiZ2jnfd56sTZjKg/xZqBMrpkK0lKGZDCjxkd98zgPTrM+TahhLDp6BQbOrKr4JUY3c+onfqQwQOcq2T6b0oRlpyvYkvs/Jo8fLBK4KZqdMBRhoETCSdPlwUCaHtsYytUFIXbIoLt1IFhwjN25In3O6L+ljGgik5lHs0lGqDa1r7OrdpWMdN0loIB2L42kVA/QonVbezA9S6WEaLiqxrfVxGWinAgDgtIDDL98bjdIoMwxAKKeiah X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 03:02:23PM +0530, Balasubrmanian, Vignesh wrote: > > On 7/13/2024 4:12 PM, Thomas Gleixner wrote: > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > > > > On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote: > > > diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h > > > index 1fb83d477..cad37090b 100644 > > > --- a/arch/x86/include/asm/elf.h > > > +++ b/arch/x86/include/asm/elf.h > > > @@ -13,6 +13,15 @@ > > > #include > > > #include > > > > > > +struct xfeat_component { > > > + u32 type; > > > + u32 size; > > > + u32 offset; > > > + u32 flags; > > > +} __packed; > > > + > > > +_Static_assert(sizeof(struct xfeat_component)%4 == 0, "xfeat_component is not aligned"); > > This struct is only used in xstate.c and asm/elf.h is not a UAPI > > header. So what's the point of declaring it in the header instead of > > xtsate.c? > > > > If this needs to provided for user space consumption, then it want's to > > be in a UAPI header, no? > Our initial idea is to pass the "struct xfeat_component" through "glibc". > is "include/uapi/linux/elf.h" proper header to add this ? I'd rather not put arch-specific things in the main UAPI elf.h file unless there is a good reason. > I couldn't see any proper header inside "arch/x86/include/uapi/asm/". Other architectures have arch/*/include/uapi/asm/elf.h, so it may be time to add one for x86 too. For this to be UAPI, I would want to see more explicit namespacing, e.g. struct x86_xfeat_component, etc. -Kees -- Kees Cook