From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123B2C3DA4B for ; Wed, 17 Jul 2024 10:45:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AC026B0099; Wed, 17 Jul 2024 06:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90E466B009B; Wed, 17 Jul 2024 06:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 739256B009C; Wed, 17 Jul 2024 06:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5274E6B0099 for ; Wed, 17 Jul 2024 06:45:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 07553C0A4A for ; Wed, 17 Jul 2024 10:45:34 +0000 (UTC) X-FDA: 82348913388.14.CA04284 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 6064D14000B for ; Wed, 17 Jul 2024 10:45:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NXEoNWIr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D2s2Mus8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NXEoNWIr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D2s2Mus8; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721213112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Adt/6cBqLwRHyr8UQVS3UnG6hzRhRyNq17HOAaUZaBI=; b=ezU3gLyyO2qYYYE3yA7Kvezn8UJ3jvXT262H7UqdRiTxzV1+5mAao8uZ3EzN/vzWrpt7jF bIv4H1/hpVSapsz413vAV0bch+hdA4kGv43YPusIt8wzBHUY0YE47iR/SCJdvZQoTxR4nu 3oTv76PIFA0nMNhhReoD5QJthOzxlac= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NXEoNWIr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D2s2Mus8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NXEoNWIr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D2s2Mus8; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721213112; a=rsa-sha256; cv=none; b=H07CVr9oeR0nr3VTyUua65zobiqNBumjnTX5cPf87z+G2fJkMk/JQQH3XX93yPvPOdHyc3 TM2L8iX1VTVK7lUMcGDC2ye1A4LWqNU9DbIfIYiIW0vzc442s9/LflRQXWkqDunqX5/CUm o8QW37cmQFWi6elcP5XlWKNbN6JlzVA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC95C21AD9; Wed, 17 Jul 2024 10:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721213129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Adt/6cBqLwRHyr8UQVS3UnG6hzRhRyNq17HOAaUZaBI=; b=NXEoNWIr8RJn9ENN8tA+q+U4jDUQbtD6U5C8lZQAYPclxqaKnGMlAc43QDjZJOFBx3scJG gtop9XeixSUysfF4x1FulabpRQQH/QKKDiGVaTxZe4EqZSBsLFnvW19kH+DGetWN0d0IIn QPzPBgiT5mgwTp5q9CnlZXIblylU68c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721213129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Adt/6cBqLwRHyr8UQVS3UnG6hzRhRyNq17HOAaUZaBI=; b=D2s2Mus8uWJyer+c/zFjhkdFHl3yM3Ha3PQXE5bASzZExkNhY3xoZENUpRI0HFLblJJ0Wp gfzhUTvYU5xoq8Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721213129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Adt/6cBqLwRHyr8UQVS3UnG6hzRhRyNq17HOAaUZaBI=; b=NXEoNWIr8RJn9ENN8tA+q+U4jDUQbtD6U5C8lZQAYPclxqaKnGMlAc43QDjZJOFBx3scJG gtop9XeixSUysfF4x1FulabpRQQH/QKKDiGVaTxZe4EqZSBsLFnvW19kH+DGetWN0d0IIn QPzPBgiT5mgwTp5q9CnlZXIblylU68c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721213129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Adt/6cBqLwRHyr8UQVS3UnG6hzRhRyNq17HOAaUZaBI=; b=D2s2Mus8uWJyer+c/zFjhkdFHl3yM3Ha3PQXE5bASzZExkNhY3xoZENUpRI0HFLblJJ0Wp gfzhUTvYU5xoq8Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB2181368F; Wed, 17 Jul 2024 10:45:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZULCKcmgl2YdPgAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 10:45:29 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 091B0A0987; Wed, 17 Jul 2024 12:45:25 +0200 (CEST) Date: Wed, 17 Jul 2024 12:45:24 +0200 From: Jan Kara To: Jeff Layton Cc: "Darrick J. Wong" , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 3/9] fs: add percpu counters for significant multigrain timestamp events Message-ID: <20240717104524.tqlz63tsrdfixmxh@quack3> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-3-48e5d34bd2ba@kernel.org> <20240715183211.GD103014@frogsfrogsfrogs> <7bb897f31fded59aae8d62a6796dd21feebd0642.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7bb897f31fded59aae8d62a6796dd21feebd0642.camel@kernel.org> X-Rspamd-Action: no action X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6064D14000B X-Stat-Signature: cms69u3y9hp8xfo5o8bph7hrkraqnjxn X-HE-Tag: 1721213131-50446 X-HE-Meta: U2FsdGVkX1833F6Hy7shoPFLewrMRyuGWGLRMMSt0cAp2htURQGoMUpOsn7cPDBxUWUxMWskwKscmoKh+z+lOyAPG4YzpjY5FWBs5iMJ+pqPdjb+O9yKrUbRXFVQQ/xGeJfKG1Lk+q7U5fwv3WFKkxQK1W6CbUGRFij/ptxeL2fy+zCW8jB1bI0JduxaSKXstQ0AuNFMR/Dcbt8MhbpiWaSO3PZ2bdFYfHNmFhaiuPOe/BwC7gwJNWyrzCz09picIP9npdRsHZJkj9+8N5A0JUkppm4nWXnD6iNZHVyO1wxWexQvP58+1xfMkT2aYgL7NqK9A436ZTyPJYhgangw4j7uk5XVzrpRbKxnXJq/Fu9jaNKMDLYR9GTjkckKbkazMeMeJNqzKRS8CG+RwMXeUu7K8hZotG/syhf8aJxHOqV1Br/gLWc+jVXqozwl8pWiB8OALAzLNX5WXfWalBaZ0Qf1U2kHN+QHVWHOp8H9qSZLgbWM0RgeGlf7NwbNVe9BT2TLXF6zua28YhVkH3HwGu3Xecyb3n3ck1zXfMkCIBUkrfQccg7SHdh2MGZGN/qduN3P12juBBtjOLZEUCV+k8Dyqk0HrxQ4cmw6hQl/a+dfV7sMaRfuWGpjLxY4VHp+kBO3T7eldqBEIJemdPDkfNWFkOacv1yulU8ujXjAm3kl3TuQzhaDdXqlYiw88lCEqXvQ4IEKaoN/hFbfwwPywesCq8+C6mK/2kmAo+RaottlR3lZoevE6uMlT/91WTry4vnTUCs+K+GOY4UeN+acP91A/GfCG4XUFk/nDFDKt6MfL6OmuQKHQusv/a85EKs6TaUUiT2qKz6ssOuKf10oTxdbjBnJyqRmhmqQWa3nIg6hHTIFeI0x9Qb0Dkd4RgsE8MExvMYEolaY7u2xZwvd69SBgyKAxe039TEg/XQcl0wgZ7S/yjujic8K83MGx+FFu/WhYrO4xrUdE3cNPcM kQsJn292 wXkRzOv+NalNwXYS+fFENSkBBjLj0MK7jTjoYyvJK0sG4OUZ7u6CTvU7Hg0yzftPW1PfY38psP3xmnvfZ7Kt8zaGrOYrsp/Z75qrX23zotbpR3T+663LjWL63IjLkpVTo1QzHea1A7i4CdNuBFwvsIeL3embUKAr+Zaeev8qSmCyiZxNtghfHRL1hZ5Wc7GIjawfN1jGQ1xoxRj31yVyD+hSNgNAGh4+IqPcu6tsydowL3zqImug1U6soylThGU7vTA2YJJOjjWYILWFAaiRpjOck8qeG86ScjqeGOs5IZLlTmzuK6UqprFYwJAr7ggGGdHsascYBJZnkPb+dcukT5pBDzGckG2JHanS/D3wDMprTdmirTR7f1gzDErOu/M4oW1FRmXqPna658TYfI/mbNZAqSwbAGWryWAuBRdH5c3Tmdn4pc0qhKQPfqQcpXnctwrVgB4IHGsniObY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 15-07-24 15:53:42, Jeff Layton wrote: > On Mon, 2024-07-15 at 11:32 -0700, Darrick J. Wong wrote: > > On Mon, Jul 15, 2024 at 08:48:54AM -0400, Jeff Layton wrote: > > > Four percpu counters for counting various stats around mgtimes, and > > > a > > > new debugfs file for displaying them: > > > > > > - number of attempted ctime updates > > > - number of successful i_ctime_nsec swaps > > > - number of fine-grained timestamp fetches > > > - number of floor value swaps > > > > > > Reviewed-by: Josef Bacik > > > Signed-off-by: Jeff Layton > > > --- > > >  fs/inode.c | 70 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > >  1 file changed, 69 insertions(+), 1 deletion(-) > > > > > > diff --git a/fs/inode.c b/fs/inode.c > > > index 869994285e87..fff844345c35 100644 > > > --- a/fs/inode.c > > > +++ b/fs/inode.c > > > @@ -21,6 +21,8 @@ > > >  #include > > >  #include > > >  #include > > > +#include > > > +#include > > >  #include > > >  #define CREATE_TRACE_POINTS > > >  #include > > > @@ -80,6 +82,10 @@ EXPORT_SYMBOL(empty_aops); > > >   > > >  static DEFINE_PER_CPU(unsigned long, nr_inodes); > > >  static DEFINE_PER_CPU(unsigned long, nr_unused); > > > +static DEFINE_PER_CPU(unsigned long, mg_ctime_updates); > > > +static DEFINE_PER_CPU(unsigned long, mg_fine_stamps); > > > +static DEFINE_PER_CPU(unsigned long, mg_floor_swaps); > > > +static DEFINE_PER_CPU(unsigned long, mg_ctime_swaps); > > > > Should this all get switched off if CONFIG_DEBUG_FS=n? > > > > --D > > > > Sure, why not. That's simple enough to do. > > I pushed an updated mgtime branch to my git tree. Here's the updated > patch that's the only difference: > > https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?h=mgtime&id=ee7fe6e9c0598754861c8620230f15f3de538ca5 > > Seems to build OK both with and without CONFIG_DEBUG_FS. Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > > > >   > > >  static struct kmem_cache *inode_cachep __ro_after_init; > > >   > > > @@ -101,6 +107,42 @@ static inline long get_nr_inodes_unused(void) > > >   return sum < 0 ? 0 : sum; > > >  } > > >   > > > +static long get_mg_ctime_updates(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_ctime_updates, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_fine_stamps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_fine_stamps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_floor_swaps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_floor_swaps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > > +static long get_mg_ctime_swaps(void) > > > +{ > > > + int i; > > > + long sum = 0; > > > + for_each_possible_cpu(i) > > > + sum += per_cpu(mg_ctime_swaps, i); > > > + return sum < 0 ? 0 : sum; > > > +} > > > + > > >  long get_nr_dirty_inodes(void) > > >  { > > >   /* not actually dirty inodes, but a wild approximation */ > > > @@ -2655,6 +2697,7 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   > > >   /* Get a fine-grained time */ > > >   fine = ktime_get(); > > > + this_cpu_inc(mg_fine_stamps); > > >   > > >   /* > > >   * If the cmpxchg works, we take the new > > > floor value. If > > > @@ -2663,11 +2706,14 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   * as good, so keep it. > > >   */ > > >   old = floor; > > > - if (!atomic64_try_cmpxchg(&ctime_floor, > > > &old, fine)) > > > + if (atomic64_try_cmpxchg(&ctime_floor, > > > &old, fine)) > > > + this_cpu_inc(mg_floor_swaps); > > > + else > > >   fine = old; > > >   now = ktime_mono_to_real(fine); > > >   } > > >   } > > > + this_cpu_inc(mg_ctime_updates); > > >   now_ts = timestamp_truncate(ktime_to_timespec64(now), > > > inode); > > >   cur = cns; > > >   > > > @@ -2682,6 +2728,7 @@ struct timespec64 > > > inode_set_ctime_current(struct inode *inode) > > >   /* If swap occurred, then we're (mostly) done */ > > >   inode->i_ctime_sec = now_ts.tv_sec; > > >   trace_ctime_ns_xchg(inode, cns, now_ts.tv_nsec, > > > cur); > > > + this_cpu_inc(mg_ctime_swaps); > > >   } else { > > >   /* > > >   * Was the change due to someone marking the old > > > ctime QUERIED? > > > @@ -2751,3 +2798,24 @@ umode_t mode_strip_sgid(struct mnt_idmap > > > *idmap, > > >   return mode & ~S_ISGID; > > >  } > > >  EXPORT_SYMBOL(mode_strip_sgid); > > > + > > > +static int mgts_show(struct seq_file *s, void *p) > > > +{ > > > + long ctime_updates = get_mg_ctime_updates(); > > > + long ctime_swaps = get_mg_ctime_swaps(); > > > + long fine_stamps = get_mg_fine_stamps(); > > > + long floor_swaps = get_mg_floor_swaps(); > > > + > > > + seq_printf(s, "%lu %lu %lu %lu\n", > > > +    ctime_updates, ctime_swaps, fine_stamps, > > > floor_swaps); > > > + return 0; > > > +} > > > + > > > +DEFINE_SHOW_ATTRIBUTE(mgts); > > > + > > > +static int __init mg_debugfs_init(void) > > > +{ > > > + debugfs_create_file("multigrain_timestamps", S_IFREG | > > > S_IRUGO, NULL, NULL, &mgts_fops); > > > + return 0; > > > +} > > > +late_initcall(mg_debugfs_init); > > > > > > -- > > > 2.45.2 > > > > > > > > -- > Jeff Layton > -- Jan Kara SUSE Labs, CR