From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EF5C3DA42 for ; Wed, 17 Jul 2024 11:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842646B00A7; Wed, 17 Jul 2024 07:34:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F29C6B00A8; Wed, 17 Jul 2024 07:34:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 693226B00A9; Wed, 17 Jul 2024 07:34:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C4AD6B00A7 for ; Wed, 17 Jul 2024 07:34:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A7B39160987 for ; Wed, 17 Jul 2024 11:34:48 +0000 (UTC) X-FDA: 82349037456.12.F077695 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 5A6D5140029 for ; Wed, 17 Jul 2024 11:34:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YhsCRW6Z; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Zj6IerRz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d72abmdr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ALb3YT/i"; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721216047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F4CWV/sF7x1WiYDVW9W02BKIWQSYqQruBo2Yq7ZKPbA=; b=r9vr6aVXCgWge+e2oxcGWNGVjm4BJQ5OQ/xGkHEwODjtKXIpAnAu3LHT2vlUJrT/WBUXbG xhF6/hfBuAvHi0cQ0h3kwyZIIpn4j7k1l08uWLp6Etok2H09SbryavU61xTfmCGWxRkv6n yyNDiSiUsnWPl+njG0LbI4ZaSsskABM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721216047; a=rsa-sha256; cv=none; b=KgBuMA8uBHp9JnO3XcofWSzbd+qWOyrywmxvWlfEp+zga0aktYFKGetIyxv6EFGMkoCk7d Bd0kA+34SFoBx0KnGdXPdaMlQFHIM8Anrgibn9/fIW4xOxj2mukYpI+zgGy4FyeiSHkuv4 5hN9awjkVl9Fujy+g96002hE9+wewMw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YhsCRW6Z; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Zj6IerRz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d72abmdr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ALb3YT/i"; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D734F21AA2; Wed, 17 Jul 2024 11:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721216085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F4CWV/sF7x1WiYDVW9W02BKIWQSYqQruBo2Yq7ZKPbA=; b=YhsCRW6ZxkN6p9W0vuSvNmlZ3E9YL7XMLvS+/D4ncqTFIG7jYHVDhAzaRnX7VB/I0eZUy4 HWQQ3i+/bfvoxViHKG6jSj74A4smED3ZEXyralXeXc7Jeen5+3QfsG+7vuw9Bw+XSlbCxb eVeNZC4WVwIBqVuQCjf2aK0lwrlYLNQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721216085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F4CWV/sF7x1WiYDVW9W02BKIWQSYqQruBo2Yq7ZKPbA=; b=Zj6IerRzPp4LCY871cyDBCxeE2n2QICTjI14FtRBETbfBY/8zjZzwZWYJY0QfZVw9hYyx0 XJP4uCgEE3el06Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721216084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F4CWV/sF7x1WiYDVW9W02BKIWQSYqQruBo2Yq7ZKPbA=; b=d72abmdrO78XCt+6wamD0te92HjEklMKI3bQ6x+I18OQiXkaSgdw/4MEX5EzNLRrRlMWda MRPh809gx5r9rV6KUmMlG+eiOcoysPF8ceme+2dy3TSpmvP4U3eIzaT5pTYv0kIZrti7ha E2fJLlrLOBx7wzxb+3mfi+nvKzuy74w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721216084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F4CWV/sF7x1WiYDVW9W02BKIWQSYqQruBo2Yq7ZKPbA=; b=ALb3YT/iNrhcoAS9WAJbUBenaiPxqkHzsykltMlOOcIeWWYDvAu8CaKiVy8sdv8I77ifo8 L6PKcqEGWRgcBABg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6C51136E5; Wed, 17 Jul 2024 11:34:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Y0OFMFSsl2YBTQAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 11:34:44 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 77750A0987; Wed, 17 Jul 2024 13:34:44 +0200 (CEST) Date: Wed, 17 Jul 2024 13:34:44 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 9/9] tmpfs: add support for multigrain timestamps Message-ID: <20240717113444.imq5hru3sh5cyw2s@quack3> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-9-48e5d34bd2ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715-mgtime-v6-9-48e5d34bd2ba@kernel.org> X-Rspamd-Action: no action X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5A6D5140029 X-Stat-Signature: 61phbczwum3f9ddbsr835roszkucnjop X-HE-Tag: 1721216086-625779 X-HE-Meta: U2FsdGVkX19m8YQTYQVjimd+lOsPvxxCSVNygLpSVulP+3b5uRFNqpuLth5hw9lwjMjCtrYmovJWs9BFYcE5L1Wo4y+jrPv7YjpCf7mXK9hNl4jzI2qveWe9zoXA6sgfgRQVzIcIj0YswGlmN8/ZoTJvP8L9k93611EDV2H+LE+qhmnJ+eJ9KqcyxXLaPkFOgXU5Ijx9Ih1dhDQqXL6KdD8U9tJnqdxCYB0xuvJQL9i+QTzVD6Zk0qYjFW13s6qf0U/TsofGtbSjgZ87DqWHWPx+xBniS9qmr111c5lxGOBWWcyIJiXDiyYdJDg4K27a3pTAesBa39TBZ8C8FxU67EP14ewZOl6j3vz9M+LTQGdV0kEr8CSYtLtMcT3xWJDF9/Ra5ZuT6PW6H3SY1ykM9xQAtItqVrlSM5gV1ORYr67m4bClIuWHhKJ5pbWnmTVM4QLzUXtGOdNghTvUqGz4frLPH+7TCAfY0I8vZKYXrr5iApxU2mrJNl0RKkrsgvD4hRpNsVY3wPAB7N7A/MZ+Znhch8ncwm2UI+qanGhU9IoEycaRnb1ECqJfOcyWEpx7pplq18jxKSVfzinB4C08irfwrKaL8/pRNe26qxTmEFOPbYE6cbg6k7lC/nGzckb0maHnsnZgYbu11Xzr1wF4dOnk13TQhE1wU5j1DnKTXYPPjuZAnJLESs+FU+Ql3L9sA8p+KROZQiEb/rG5ODUU91Ji+Wuq8uqb6+ykofG09AbZKauBIBhAqL+OTzgjWNkRHlF4zH0hnXnqvrwtQcmbAt3NqTs1pIN24iDRDeE6+yvcJXtz2xG8r4ir27jzbOWK+gkef7o0vJh4nfPeCXIHCKfFRcHVptikTJkVFNPTe+toQ/JPnIjnn9KDJ3qyki/KCeOHcVvG1ZrlQV2xCaySCOccOV+6hrn/ZOyluDqAFHrSSBOuOprvHt+949Od+sYl1Xi0uTka6GgHbuP7eOA et1ZhXGu n+h9trmjR1U53IsSLC0+tXT03m6Uso6b9czdNWPjK2DuSEyen+lHu6PynC8QfA7rA5fRym0TF+/iZs/EsVNuVirZLOftds/j/ehm7Vv5BpyaB71fDHpcKFwnh1mSN3Mj7RjeEESlk8tp670mgVK7gxVBqwoPfFY3p79ne6O18R7Zr2JVhKVcRLxcxtg4YrCzr+8u6Ok6C7I/yoMbqARZ5GKW8fyX4qE+m92nDHUlLAA6u2N//VsHW5o4fz/VyT4YGlO2CLVo/wPAdepepySfkiIyruYPyvBav17Ol2CNFIolbtnTnwDmilzrvciCoWuf9W+TtAdlfxc+TKVN1Q1g1/JWKbvszX9Gu1xX+HNb9SgyWpcApTzFug8rB9xKqdfpSihglAP8FymyKWTzmG6w8YhCy+/Ccoye1q6FDXzMfJBMgCF/gsN7e0t4caA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 15-07-24 08:49:00, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > tmpfs only requires the FS_MGTIME flag. > > Reviewed-by: Josef Bacik > Signed-off-by: Jeff Layton Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 7f2b609945a5..75a9a73a769f 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4660,7 +4660,7 @@ static struct file_system_type shmem_fs_type = { > .parameters = shmem_fs_parameters, > #endif > .kill_sb = kill_litter_super, > - .fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP, > + .fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME, > }; > > void __init shmem_init(void) > > -- > 2.45.2 > -- Jan Kara SUSE Labs, CR