From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6905EC3DA59 for ; Fri, 19 Jul 2024 16:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDCF16B0083; Fri, 19 Jul 2024 12:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8C536B0088; Fri, 19 Jul 2024 12:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B066B0089; Fri, 19 Jul 2024 12:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A9A466B0083 for ; Fri, 19 Jul 2024 12:57:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5ABBC1A07C6 for ; Fri, 19 Jul 2024 16:57:31 +0000 (UTC) X-FDA: 82357108302.03.3BA3149 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf08.hostedemail.com (Postfix) with ESMTP id 726E016001E for ; Fri, 19 Jul 2024 16:57:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721408202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQgF48NxOTzj99XL2/iadbS73zCb4I2J/SWCbjyMX+k=; b=WEPLJRq9cmmP/oqrqfn1Z3Ve3s1zuCTBoFTwQH3HwpXed7E/l3Lfw+iNC++wAFt9aKwWU+ xAiS/np33yHods58bbhLy31oa8oQGha4PWNXje8kHbmpndMs3F3SEm1iY+8gJHlwQojLO5 WHFFCFneA3espVzbFP/HMjLM0HbFves= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721408202; a=rsa-sha256; cv=none; b=J/PYfStTJKof32DOwIEo9T+g14qe1Z3Dxl3ZDO5LBqpjROKGU4kdC0uSLBfFDDwirbc3R1 2aPX1+GtGmf1mCCDrOBCWsH+iucg0n+FKbq8Siv2LkCy/5dOEPZAmmEzHjLStWQWcw1MJM 7E2odQunenoQl0v8KhxemgP4LlCl7jE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WQbQ30Sw7z6K8lH; Sat, 20 Jul 2024 00:55:07 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 84DA0140A79; Sat, 20 Jul 2024 00:57:24 +0800 (CST) Received: from localhost (10.48.157.16) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:57:23 +0100 Date: Fri, 19 Jul 2024 17:57:22 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , "Thomas Bogendoerfer" , Thomas Gleixner , Vasily Gorbik , Will Deacon , , , , , , , , , , , , , , , Subject: Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned Message-ID: <20240719175722.000016f8@Huawei.com> In-Reply-To: <20240716111346.3676969-12-rppt@kernel.org> References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-12-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.157.16] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 726E016001E X-Stat-Signature: tdtadopruie8eh6trq1xxgbkf7kieo6f X-Rspam-User: X-HE-Tag: 1721408249-714040 X-HE-Meta: U2FsdGVkX19jZ6a7RrckdRpdzBuBSnH0XeF9ZkCjKCs3p453/UE1rH8Hlb+Xa0hWPuZapkIECRFobnEOeH3eRpIFM0HsBRUJP/nFnwqksDMeisaH89id12p1KcOW1zcljFMDGslDwbfLDeysPCG6FzTcXEjX46FyiOXJ9kGFpsb4F3KLCM4idCJoYBXzCPQNuvP+J6C4JJTaq5TkAF+beWlXMOwSzn8LicO+kAL5xOJTo0QD2kwRkW5Ba/xudAOy4ALiIk3S5g+bCBOYuAMOLlbeJwrqlfpfh2YGIR4Lo+ymgDy9iu+VGSighGHG7pSenzpRkyqPpgDW+/VqScsbpZdGya6YTnA6n7enpUhNPh4ZrekiAwOu221j12hLZCVK9cx8cESfWoM6Rce4LeI+0fTUlCc2nqDLePv1B0OttC0gtY+mOimLKqxwTn+71Fn4IW0l1yc6BapTD4sLDQQqDBZMJuhJ7mzXoHzO8btTbAXvF3yFDYqUl2CKqpExywn1f37x4bxRncgAbjxng50X9q4VWqjclKzqKYdHlUZvzCuo5TMQPz1QJj8LTQ//yQrMkQzC5XNkKJ0oETObrlpoA4xErsFXK/ciyn40t9CVEu8nrBY6wB4Qf44eAocwbSINvi+w0pcy+Pj//VsXU81psO4wEA9nNfr0RA22uR49liRb48dY6AN/J352t+9v6VufpeEdp2it9AvH1No/oU2BHJqNnI+M8ohxLjarYWxDxs8OQSyW3wbHOZV17Y/j/Mpwky/Gatq0u1cnNL9bkBe+rkEQ0r7EInKg+AdynaophAI0bmA1u5OVvAJaZZAseAxZNpnbCWJe835oMd3EgmBn2NlmbUXsiqMCMfKJzCWK+t5tMWZwiAeNDIgzLwhHhUZ+dWU/NW2z6LfQFGH3EVNSbPz7iRAg244izbqB1fsouZDHWqbE9AhA9aTFUIebljjur1fz8ZokAgpElx535rz Ik/6gfvK x5glIX/dNwQCat4ovjGUjq3VyNJc7Lg0lC3/mJX9p1g/dazLufz0dPyIrxR8S0WmuBig7OvpZb7MzqI8Ao6pZ1iCnEISld62vcR9+TMtx1KzoQxWeNmtgWwPo2G57lvERzqY6C3RS7bBbEklWEI0e0DFQJnZB4BTotvrbHMTucpURPGzzrAJhZq/Ef4zs4jrNQotHcanCTst3U45q1QwmgWInc0KwajPbg7KrCE3BcL7r1DaUIrRvX0L4V9yDdHUkbSeeB5KaL40mhAEV1iZVeHhgq9FpQL4Y+tnDi3P1QXY9iXjZ4Sc68HzU5w8WioIDI0u5lCxPPje2vFjGb6Qy7LsENw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 16 Jul 2024 14:13:40 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > CPU id cannot be negative. > > Making it unsigned also aligns with declarations in > include/asm-generic/numa.h used by arm64 and riscv and allows sharing > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron