From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E92C3DA61 for ; Tue, 30 Jul 2024 09:34:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 693596B0085; Tue, 30 Jul 2024 05:34:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61BFB6B0088; Tue, 30 Jul 2024 05:34:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 496B26B0089; Tue, 30 Jul 2024 05:34:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2B4E76B0085 for ; Tue, 30 Jul 2024 05:34:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D56501C0950 for ; Tue, 30 Jul 2024 09:34:27 +0000 (UTC) X-FDA: 82395908574.20.924677B Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf17.hostedemail.com (Postfix) with ESMTP id DB3C740021 for ; Tue, 30 Jul 2024 09:34:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HbI+dK9O; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.160.41 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722332062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WlIH/Z9lg65usVJ6Q+sWdgJtNwPdkT/vb1dBLC+klJ8=; b=eRR58541+HJ3X706ynKjgT1ztwU0b8sqAYIm3gxhx2jbKfDOBGBQLlY257AmFs9p062Dxs Qe9pWiqj3pL9ufgGbQSa1o3wKX8kzWzAdn6DrBWZvdPB3+watIUhKnguYE0t62scUZctNR 1YLW2GlcqC68mmQPu1dpMpzcWuEVKBU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HbI+dK9O; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.160.41 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722332062; a=rsa-sha256; cv=none; b=mcuRwRfw1eMpWCcuv0ONTzF/rxS2x4jIaukHZhIsX5LqiA6KXbi94T7kMVRojv8O4hbQ+i j/XjNJvFsUzEa2KU3CW006RjHawB5uB2FQtXB/NurARNIapZ+MiR8Au/QEIhDEUimrQMpY DiPRFs+9a+jZ8jx81Wawwtn+qZmjsrg= Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-260fed6c380so2671932fac.1 for ; Tue, 30 Jul 2024 02:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1722332065; x=1722936865; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WlIH/Z9lg65usVJ6Q+sWdgJtNwPdkT/vb1dBLC+klJ8=; b=HbI+dK9OasZucBiY+6XtryU5NOcGTYSwBKhm73NWZM4VW62tvvlna3VsJ27YdoGVx0 GwyAUoDbzS3GYu6PCijG29VuLrYExd6zq0sNxWOc+9DYHcLGfMfpgGhlDfsJGvVWqqaJ IwqJtXplrd7cLunrQhYb7bsD0R/y/ARuCy6Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722332065; x=1722936865; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WlIH/Z9lg65usVJ6Q+sWdgJtNwPdkT/vb1dBLC+klJ8=; b=LLTVOwh+PGC1hYcsQNOpOURB1UWjNAUK8mNVwhQ7eC+QcwzgPDox3C9FQLDJ6ayBQ+ nC75fmjJg7UMkbTg8wnrWSiRKfzd6s/jXIBZAOuCOcFI1B+WQynFzdmZKXqFcrVTmD60 w/zptilUrrguP6MpMOPzlfhyCya8pjtgRP9t1FQPqr06mDKFc4S+PnMrzJe8FA8zBCrF fyZdN1tkxGzv/gRQZQ9PPHdb/nL1gGVEt8Vp/qaS0P1AcRks17nR7V1Mb7fDv17VBwcU MxSWymvuQXuFqeyx/NfaTwJj5y8kyZPqh6MHyLwGaoNkPcjSO4hWPM0O4eUoNlTdyo8G 7B0Q== X-Forwarded-Encrypted: i=1; AJvYcCWW40QHMCKB/LHFeXn1LSMhRc0SXUUiBbhZsEOyjfLTew6fT8Auw8h7QRQeTwas4nIjFySmJuHNUuihDvyRybhgKzU= X-Gm-Message-State: AOJu0YwH7nEAdJivhEPZCpCnCLiodInFO1GIkIMcUu3oSGQonYQTfY9L WMAP3y9epsVc6q+EyngL8yerE0RAFngPDCzA5D2MzkywH4ohLixns3P4GpgQhw== X-Google-Smtp-Source: AGHT+IEtpTNelSJsHuUJQEyjsPuC4VppOP9xG/HQ0SY22h82hmhZkLT8BMI401j3xIJhPhh6VNieAw== X-Received: by 2002:a05:6871:3325:b0:25a:eca3:6b59 with SMTP id 586e51a60fabf-267d4f21ab3mr15030469fac.40.1722332064777; Tue, 30 Jul 2024 02:34:24 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:a51d:b844:f0ff:3c91]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead89e53fsm8099158b3a.187.2024.07.30.02.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 02:34:24 -0700 (PDT) Date: Tue, 30 Jul 2024 18:34:19 +0900 From: Sergey Senozhatsky To: alexs@kernel.org Cc: Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v4 18/22] mm/zsmalloc: introduce __zpdesc_clear_movable Message-ID: <20240730093419.GA16599@google.com> References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-19-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729112534.3416707-19-alexs@kernel.org> X-Rspam-User: X-Stat-Signature: qtxpf1dzi6nkjo74ywbe316xgdoamue7 X-Rspamd-Queue-Id: DB3C740021 X-Rspamd-Server: rspam11 X-HE-Tag: 1722332065-737739 X-HE-Meta: U2FsdGVkX19aoQw89rHmvUbpRvoDUGhZ62nQMy3XrNWv2ON/zrwK4gwr1aYYLwJdH6p5aKBBKnTeaCT3W4kaLEKoAw9ucTTN7o299DnJWL6mLT0Fo93f3gIB3wVCx2vo+51GOt3DXrC5R8B+ECVU9qZURXDmLfmhkKWHFeQWDqiEGbzs15pn1EnPs/5U0fz01mS5HP2Fj4hTr+wxyZAdQcA68bmKN3ZHcXK3NTb5VKhJngDOSCbg2+imRB4zquxwqjVNAc0O19RSEG2KTDR+Xq+kSKJnKrKllKbqJusYMx5wSg2/2s95pYIMMhaerI1Tl63Ex588SiCsurYfUv+iYL35sEnByCRpIOpgVome01ZF7GW8REXeyam40XIlXmaj/T865b05h1eAPudCi6tq6rBB39mt8JZ2w2SOf4ylT+iKWtdMDV6HjKarJeMVxhzUMFXWozBBjR1qMlV2AkvAgVS1zrGCb9Ur4ToX88uyXNgJPcVT767zKpHpB/9TNYUti7sSHInaQrcTkaXN3aW1Iy4UcbtAsaiitWf++oE6N129DtK/Toe/2M0kRdQWnXg48qqLfjZgJB3lmtOVcqAbyHJL3TgbtUxQVOrRV4hL4ntW8R8ucopDbb/PtxTUlK4ipthM/G6wwtscRNtmGa+LuTqnTkixRzKr8Np/Ub9N7ZsjTmPBWZ78poRbfkmSF0hT8tFm//FJVkX/VtQs58zA4h2DrnkkOHw2uHmKLdTeUN9REd6VCmlTSaX1/oI7is6UtfkRLvkNGKE+Q4tFyhvA5TTgYC7xJJ8Xd3BBOmdcJSulaVOQNefwGHTRzioIUkyAp03sxHrj14/gdjF+GuFdQCf3JdugXc2zJEaBMCoo3gyEkDZ4HQv4McOCPzr0veDyF8sIEp68pcAJbxv0kK/Hqgu5iy+vYChlCiW2zyFPpUo/mkhh3A+2jAGCiTl8ESQzMOoH7p+cp7wySFX2U2k rbr7ZD+Y jrnSAVUhDhnE9+s15oBT1zTraRqkfjiulNgqcQ5FRPPkuel6hzOc20l76jpeTUrFMqndAowJKeGL5WsLtAnClfcvzu1x06e7vfLPLU/zpcdDID6QMyjh6kOhmuNEvAXQKXXmTjY0958/kyDY/0Je6nvtM+Zwo0YZzgC9PH251QjHzYbOHwFoo8Vl7RZlJ4oBQRhGThgYVVINnYEJzrEUf/OQNZhHXHn0VBsrn+wH0WUxJV8eIT1KmQT9gnUzqYT5WFhAZFwmEPHCgSMD7yIm9IurSlvusucnnwgRKsSZrJog9NmCjCVbmQDVnM+TH0bQfZIkZ2Gkd12CZ9r9ITICl5yx9tG58N2o4N3/bE2ukq42DC+QTTDqaoWmEP2YgEe1R4nFOB3vLW7KNGtPhyDFZKB6JBgGsVyfWHIt901YYQLCGswVTkiSkbPZpKfsmnlwdCBLddoX9zS/REAOqJ6yU7lzdzfnuBvj/mWhnzCnSLkUoEGVmZtlnk14k7xzuqontrYxv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000432, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/07/29 19:25), alexs@kernel.org wrote: [..] > +static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc) > +{ > + __ClearPageMovable(zpdesc_page(zpdesc)); > +} [..] > @@ -846,7 +846,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) > { > struct page *page = zpdesc_page(zpdesc); > > - __ClearPageMovable(page); > + __zpdesc_clear_movable(zpdesc); > ClearPagePrivate(page); Just a quick question, I see that you wrote wrappers for pretty much everything, including SetPagePrivate(), but not for ClearPagePrivate()?