From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713FFC3DA61 for ; Tue, 30 Jul 2024 09:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02D3D6B0093; Tue, 30 Jul 2024 05:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1EE66B0095; Tue, 30 Jul 2024 05:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF636B0096; Tue, 30 Jul 2024 05:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BAC186B0093 for ; Tue, 30 Jul 2024 05:38:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7C4B01401B4 for ; Tue, 30 Jul 2024 09:38:44 +0000 (UTC) X-FDA: 82395919368.13.48D71A5 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf22.hostedemail.com (Postfix) with ESMTP id A4A0AC0026 for ; Tue, 30 Jul 2024 09:38:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OpV+Ztv8; spf=pass (imf22.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722332280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gNel8wBgzZxeqPt37Zzi9jufIa3B1AS0eleyuj5OMgA=; b=fBGjxHRsMS95XF8/iEsKkYNP7dUHzujITT2LdLHgcMCYgmKLo1YfE4HpPB45BGDSP6g6oQ x128T4zBScon0CuSYSbIR7czGxcdiY5FvOMK/VkBZVNtaaqf1R1VdEsrFTFl14Q5CZp/jd R5pERzAIIcIHBdAQkHyKYvDRWpqHV14= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OpV+Ztv8; spf=pass (imf22.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722332280; a=rsa-sha256; cv=none; b=DMhHAbMcIYGPDxDDjCOrZsqmQQtJPi8BmDTtKd5aXcsQvRu/+nnpaxXqnClResEABXZsm6 BTg1iC+jXnGKulQWlMhJw9wXdDD06q1hhtX+1FuofmsVb0Yv0ckORgI8P/i/2WDY0sySTY 8f08XO6iQreAbQvSmekQ5P6Xqwn7v5w= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1fee6435a34so26014405ad.0 for ; Tue, 30 Jul 2024 02:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1722332321; x=1722937121; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gNel8wBgzZxeqPt37Zzi9jufIa3B1AS0eleyuj5OMgA=; b=OpV+Ztv8w9hSjs8m0OZdYN6BmvKhTbR/dwzETc1Yi21Owhw2qetYcoKQBUciRI5WRg UIOIcODkyfzXTmw8rkpvI4ntnFGilyuKxXx5yPOIxkV0AqGp34tkOgrBGXv0yOlvv462 qjTebPTP5KJgfXQH3J3eZ9UE9NXP+kO2L7oQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722332321; x=1722937121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gNel8wBgzZxeqPt37Zzi9jufIa3B1AS0eleyuj5OMgA=; b=BugzfHUYauVpgb7NRq4eh+NM6QKXXNxiSE6usgpkVhPHh+AV00O2qdFJoDpLyQL3ap zd7JZzZr8mSJ1fR+aeM8Rps3IF7LIZAuHRWh4vYp24zRhYIpToA1Ok2bFaJkZ/bS4ouS GGLHlZzWcrIyH/ooUfX4uXefd8HvyAFh8w6LKSQsnCdi+1HcCeXa1DijDymmpw5IvxD3 TYH+beOc0j+5JjgWbSMKMBVZdJsFWmbdNrOs1eGtQ68QjaDXTTI/M7Imqj9TOX9FACEM 0RZMic/5ACQ+GiJMQlDMv/7eQXWf/OCNSI2nHkuTlZaKy4DaHyPvnWRl8jONKy2hRzaF lHyg== X-Forwarded-Encrypted: i=1; AJvYcCWOq7jDvD+NAiWsiUYANzYzQr3zuK9ZOzZam3yTzAQVGQO1YxnwHriiOvj6sthJFlatgw6AdUe9AXssoX43+nd1oeU= X-Gm-Message-State: AOJu0YzklSLYSF1g/+U3I7i/q4V2w6s++dRDuoMGA9+0DARESdrNmwEG wnEL7ADL4IetDIqrMxzqBtjnN4FClpYczeBNNsrkA6uye/kXdKrVHFl7TXWa8Q== X-Google-Smtp-Source: AGHT+IHmvw9M9mYHlmCHrEHJHZFKj6cCVhL/T7ZPTzDotMkupEzWsb2qP9z8ZR2AYu2+3UGC+Sacfw== X-Received: by 2002:a17:903:2289:b0:1fb:37fa:fedb with SMTP id d9443c01a7336-1ff04805bb5mr87312615ad.10.1722332321341; Tue, 30 Jul 2024 02:38:41 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:a51d:b844:f0ff:3c91]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7ee13easm97345305ad.130.2024.07.30.02.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 02:38:41 -0700 (PDT) Date: Tue, 30 Jul 2024 18:38:35 +0900 From: Sergey Senozhatsky To: alexs@kernel.org Cc: Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v4 03/22] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc Message-ID: <20240730093835.GC16599@google.com> References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-4-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729112534.3416707-4-alexs@kernel.org> X-Stat-Signature: 7zcq9u8a76aub4md63upt11u1ghwse3i X-Rspam-User: X-Rspamd-Queue-Id: A4A0AC0026 X-Rspamd-Server: rspam02 X-HE-Tag: 1722332322-760214 X-HE-Meta: U2FsdGVkX1/kUs+oZ+lZToItveqt3yW7k16zuxWTjtk/V00d830FjYuji8XyQSuINzCQmQk0gF4T1Qnf32ArRJlnSNldb5NKDespQUdB1sZ5HVSqNmvItOVbX3UpTRnQZCF4rKAoGTTDz9YtuNUp2e5AKVGf/2gdpf6huHRoP70W37PYEJjiegkRMw4pmFyHl4t1aY4gG9uGoUx15g6yMXjcmV+kUOOQzIuzoiyd/mynQq3+G49O6B+4AYWdpxV1jaNMXssy/tdbOqSJu25F9Qw2OIM9bUQw/7Flee7eOYamd/iMV5Z9yy5Rsh8/hBOZR3h7MTMlFG9z6qE+iFC/f3W0hugrwG1F5e30haaq6e6bZijpLtSxTF3MU4obdXYuoOfX+IwKsCdL3YbPB5Ufuv7O1hBRXUTFDaIznQrJAj+8ZVSc/7QP5041g+TFfb50cNMrFtxw0hHM2Mys4eGjlOP+7GZkfVGVCpQV5oYkXgBwxpQ4yQaVowzbrgOhAj+kjPb5u7iPev1761xggGUfGYIWI7X9xHBG/SKTtf2qkXogYgmA90+3WcGdG+f9OX6ymEmUbN4VUtm79eCsmRG/qBPGMGAqhxgS3LCVsLM+Uz/83TcTWXvYPsmK5TaxejtXG7HNe2nNRvXIE/0u2hdSEXcCv7AzzJ1rBYlAlIerTS2tkMoiu/bvicTCBfPq77jmrBsvobd0myHhFRM6XPXy6iyyk6+VppXwKax084RfFZl+EC/cW1Lfb38CIT+cAFCMALpKCyHpD3NE2ppRHkd2z4cMjqNQlaFf6oqjk8BlMuduxQ+pXG2nFgpf7/TPSmwqJd5MeY30QGa6feZTPjuqJGm/Y2BC4/ym084pyCFnSge0skqWIjcq82rqwig00YAyBGqpp0MMnb9RHlVROlu2bX6OmrSha/kcG62t89gj+mABAVitI0Z9VR7y9Md6Qo+CiV6dIQNRYG9RFFSYXIn n1uRKtEG zwHOoGjsBtR/EGpWJR+X9SCVPXZ3vg4n5IdbN0Hh9EZb8ZnhSdGFX+kSSoC0yWGpFvRML/2QzlDlTSBxvjnLUMIb8aZTJAHycnLStP/0W5C/1pTaCNjJGgY1nNsa9Xe0hO2JZd9XAoc7ZwyShiCwi0EKbRXGwyXu/ojPONBdzwPlWNyZemHvrLDDNyH7jSwvjrGKD8vbn93lgIX/CCma4cRAjQgDlhsEz/wG/vKgiCV30lrhQieT527jyRE9/dMZj9ICyS2NJzj86Raw+VYlHF6SD55AtwX268Q19nACvFOHSHRQx7VkuH6kXKtUT9NiqsA0viXNae2B8pc2U61Lqv/tGw8p2RMwp4ZmFV+DnZiayRpQg0RPgxgS7F5L9OOgP+0EkXSkWDWtlJ1fiipvgkufhsdeJeJL/UMeoZ6x0aZoLv8ZTuonIUgjGqhx9s1Zgdwp19qKHvSK0PMaACYTRY+Ql5dZvoMtQNNtX4bhUe+GbxWYOSLSwWYxYJx1H+sFgz5vs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/07/29 19:25), alexs@kernel.org wrote: > +static inline void *zpdesc_kmap_atomic(struct zpdesc *zpdesc) > +{ > + return kmap_atomic(zpdesc_page(zpdesc)); > +} > + [..] > /* copy object to per-cpu buffer */ > - addr = kmap_atomic(pages[0]); > + addr = zpdesc_kmap_atomic(zpdescs[0]); > memcpy(buf, addr + off, sizes[0]); > kunmap_atomic(addr); > - addr = kmap_atomic(pages[1]); > + addr = zpdesc_kmap_atomic(zpdescs[1]); > memcpy(buf + sizes[0], addr, sizes[1]); > kunmap_atomic(addr); Don't know if kmap_atomic() wrapper buys us anything, but okay.