From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D19C3DA64 for ; Thu, 1 Aug 2024 03:13:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0D8A6B0099; Wed, 31 Jul 2024 23:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABDC46B00A0; Wed, 31 Jul 2024 23:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985156B00A2; Wed, 31 Jul 2024 23:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 79E936B0099 for ; Wed, 31 Jul 2024 23:13:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0AB2BC075F for ; Thu, 1 Aug 2024 03:13:13 +0000 (UTC) X-FDA: 82402205466.12.C3B62F9 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 263EF20019 for ; Thu, 1 Aug 2024 03:13:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Tp0aucoX; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722481934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IDwVKJLacT/8W+BOY0Lh73qJbUqMV8nEA0zMYmTJMpk=; b=bknrLI0V7y/aESq2gbcQPl7sj6W8QV1M8q/nobsnXcpgbDuChrJOWwES5oFzlgXb85t0XK Rmhn3aUnozE6Vwy+LRxise0j8W0YD/twRPa+HaHSHTCkcYM8kvT08HNYEzUmtVVzUweXxf 8kQmUYoXFOg7SQyFKGBtCgX7GscN6q4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722481934; a=rsa-sha256; cv=none; b=jIGl2eO5taVYz/GMUcUXm4Wsc+aHPigNgA25CXf/zGs0wLmcr2Ptoq180XGFtXYI++9tyF akIMJwinJernNAZSS6O0lFCPYL8m7v43qFx2l82yNd8Nl60+Q60Q0XeEW80AljL6kBiVG4 u/U7wYJsdQ07/zWMv9v/GTLsSIvU7oI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Tp0aucoX; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-70d19d768c2so4958360b3a.3 for ; Wed, 31 Jul 2024 20:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1722481990; x=1723086790; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IDwVKJLacT/8W+BOY0Lh73qJbUqMV8nEA0zMYmTJMpk=; b=Tp0aucoXDYxEA9wX4COAGRqRxrO0bWptHcx050g9pOD1MkhBHhs8WmNvltv9l7KeUI 1tdqypI88DGNAVtZ1zJOAZ/gVd4TVgDA4WvvVjNpS6kHRWHQxMrZr7Yg6dcN/EHdp1cr FyB41LGNn50K5dN/mVx7q2Y48Tg+eKWJkF8DE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722481990; x=1723086790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IDwVKJLacT/8W+BOY0Lh73qJbUqMV8nEA0zMYmTJMpk=; b=LGs1qth9HMKvto+k9piaNP2tWs7qBxJyqDQn8hLSALuHnoosN66b5uZKy11DUo2I0U 5Y5RjE7q9Da+c4+3knx/m6XkhDAJ1K0L145qE9nnDVSH1hT+RUzQE5tI3zJUoR99onU4 ISxPUy5xiFmPuxw4QMHgjwTxcYxWF5hTcNITss/5Uf6JV07Cu7KmPlwo42ipMM9+kJ/m 9+EON6L5zuPikRnTF24mDP+rTYlFbaK9uU8MomCLQJSBx34M9REN1Uujbcfo8AkJgEx9 AbtnPnBPbYBDuSql/KD+y5JUJkHFP86ByWmlU/HgoQwlMgdMwJV11TS3p2odDQUcBkAA +DEA== X-Forwarded-Encrypted: i=1; AJvYcCXcaf3GehxNyde4aQxlQhk8K4UtkMwlrf1OQgUhu/gi/7keO2x2+Hvhjcjn96wEBpeJdIxHDRb2jGn+raPPh/olNSg= X-Gm-Message-State: AOJu0YyeT6gCIcVoVx77lu9P3Iz9SEN4ayU9G/d/vcqLFumiMD+He3ee 3nEnZTsMUkilq07KQkPEo4ARjFBCewuia9H8hA5tHOwMZqxMwYJHql4FJuA0pA== X-Google-Smtp-Source: AGHT+IG61gMvEEw/hJLHJWg4o4hHvYkubdgaUu6RT/iNCsNthhAqCrYIclJxF2FpWoLrdEwXgzwYbA== X-Received: by 2002:a05:6a21:164e:b0:1c4:bf4a:6c0e with SMTP id adf61e73a8af0-1c68cfa47cbmr1414800637.26.1722481989728; Wed, 31 Jul 2024 20:13:09 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:153:1133:6aa8:dcc7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7d15e98sm127934545ad.99.2024.07.31.20.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 20:13:09 -0700 (PDT) Date: Thu, 1 Aug 2024 12:13:04 +0900 From: Sergey Senozhatsky To: Alex Shi Cc: Sergey Senozhatsky , alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v4 22/22] mm/zsmalloc: update comments for page->zpdesc changes Message-ID: <20240801031304.GF16599@google.com> References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-23-alexs@kernel.org> <20240730093726.GB16599@google.com> <8fc7939b-416a-4328-9df2-488f17783543@gmail.com> <20240731021619.GD16599@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 66rexd6jaz1h9ji89xqoky4tbjtp55f5 X-Rspamd-Queue-Id: 263EF20019 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722481990-30700 X-HE-Meta: U2FsdGVkX1+W2KF7jcqKCnBdn0bKMMGMjv0AZyhcCrYL6dZU5gkD5rtwwzijODXJu+23WyCzotdfUmscQD7DJqsTid4nXvSHMI8LygmZqTyDpo7BtPH079iu28s1gK7bZcMGfGNbELEeiLs1bAzDJRBLrC/ItO/nlEz5EGboxSApHT58lS3EOw0aNhcrfCOdPBPehCepwgOse1/pESg4lygxviQMcznTjVInBOVLAr2C3UffbY9FMjAXk2dUUs7zriz59LlBCYhExyD7WoqMpwBb4Rjjeep4Pl+DGULF8aKu+sDDsp5s1zFfuItjNfpKUj7mtopDIEpxFEhz8YqNWi0+5zEmcxywRuwnr6IFxRb62J2bLmDSov3ddIyieWk8+b15NLs5cXI3bI2dKu967a6CG+ea5XxWvdLmL0N48oCEgx6el//HTUXZ23z+qvAo12Tpv2OL5yLh+o2BXY9uBnfc/2IHF/fQq39AC5FhR7yFAl1TN+7CtM6bbXU264D1IURUIVeeQsoKD7BPZ5qUBU2w2aF7ca4vNFRlWgrrKDdz2+R6D0hYiQ1UoHTuAiHB0hVX6BHi7Ql1ZR3YFTnl+cq7uKYIlodyz7BNT57KiIFExj47IytmraiS0TDesX1BRszOsuJBCXNxUtAC5+BcBbWgxyv7ODWfs2m5aXzDzlfjp1ZJ5tnc1QTHsXH5lSQYrJmEbsJCO7Wsl8A0DYNNyhKJrVvVO6dtPiErvilH0EL2HGJBrZuXoagz83ugnZ+mG1NYqawBODHjSjkMwA8zERFE8UuC0uOB4uL8VHqRP3JIF4Jry49uIaOoP8/j+/nmt3MOoWeueYXipziGcLZY6FBP0hxGOSOQ0udQHubEHBKodoSYUAqVHHExjaKTlLgMSl5NeFcG4kPjXMSLWuC6P12CqCDZu9HWnNOvNXMevhVFMktcgBbDBCuJ/F3jmdvgl4jYrbd1NKb55A3xBnQ 0kFaQEUL EgLRK9JO8pdpOSykFQNWlTxCeoUXsD0L+lT2CFP19zYVI7YO/MrEx6MCmJ/4HSeU4HfE5q+TmKadJhlbq76YeG6rpSHBHDKgsY0N1VRKExwL7io3MlChrnDFiUb61Rl6wFhRLspwQsmRGFw69mD2MjQBgAMf3DTP17iV2WCBnOpyWsDB206owj+VFo5ie2Eh8rizE7tW1Kwqn9H3zwUNLxvteiIpdRaHQATWFhKvvDgA6XhhZY8E7IULLPPgUPgklc0xBWeMs/gm6TVh0J1vOSgYiwGHu1/YDrW3GfwgqyoxJoJA+XzHDaZpZ6V5ngmzSYexp290CUVtKUk/zlrIyWLVGgDQw7t820/t4GuIEoCAbaKk7uBlz0BHqPaF6MX/uA4Ge9v+4xjQOhEI5Rnyl3lrCrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/07/31 12:14), Alex Shi wrote: > > A bit of a different thing, still documentation related tho: do > > we want to do something about comments that mention page_lock in > > zsmalloc.c? > > Good question! > > There are some comments mentioned about the page_lock in the file, but missed > in the header of file, so how about the following adding: And e.g. things like `The page locks trylock_zspage got will be released by __free_zspage.` Should this (and the rest) spell "zpdesc locks" or something? Or do we still want to refer to it as "page lock"?