From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D56C3DA64 for ; Thu, 1 Aug 2024 14:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BFCF6B00A1; Thu, 1 Aug 2024 10:07:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 048B56B00B3; Thu, 1 Aug 2024 10:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8E236B00B5; Thu, 1 Aug 2024 10:07:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B90E16B00AD for ; Thu, 1 Aug 2024 10:07:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3ED7EA0E01 for ; Thu, 1 Aug 2024 14:07:44 +0000 (UTC) X-FDA: 82403854848.12.2602DB6 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 24D66180029 for ; Thu, 1 Aug 2024 14:07:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=YxoabSSJ; dmarc=none; spf=none (imf16.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.128.175) smtp.mailfrom=josef@toxicpanda.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722521198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ySdl7cV1sMC+f6fyOoZuuvhfWYrH1jWG25mq2cl1h0I=; b=YvXqFJaHr1rlESbrDnh6NiiaYm9iIBuPLeUVGK1MC/utqq1FkyuagNM36V6fD324G5qfl2 lFceZVsjAddS/b+ioNwHSbD69JSLJTMF969jOGS/zAoZVAbJfz2RJEfue3S1NFbe0wLlWN 7e2W5jKklHX3UkR6UaoDg9IsudYk4CA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722521198; a=rsa-sha256; cv=none; b=f+pWnvQBt09sqbfX3eZqrbVcyT8m/mVlhzzc+JIAuqUBK8pNnpBHg+dfZ+Y6hHXxqINy5V cXRvlCLTSkppvt83BfQG4tDOiDaVxe/OARq60sE8EHx2Pwn8jJqPYOrUtEA8DaRaglcBJr IlNjbN4ICajRJPyZ7XKpP4wjr33PXQo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=YxoabSSJ; dmarc=none; spf=none (imf16.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.128.175) smtp.mailfrom=josef@toxicpanda.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-664b4589b1aso17646817b3.1 for ; Thu, 01 Aug 2024 07:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1722521261; x=1723126061; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ySdl7cV1sMC+f6fyOoZuuvhfWYrH1jWG25mq2cl1h0I=; b=YxoabSSJoohWYSj8wT0+v+lCCyAD7cfeKKjhNEaADNZxkHqTfEF16W9TUvgrJmAaew yr+LnKeoMA1K+AyMQpCzRY0m0IjWjduLCWoUR10DpWr4+MtupOVoqmJex8CGPwY4wLj2 EUIMtFllXiZJPLztDFYX0Xjhrm1cA+hMPt8NCHNxTJnWWrUKBY9KyywZDIUqY8EsSvmL D8SkVbWGW1AL+bn1x6j7Do65H3rt6i+0qcOR/DdivJjZcW/hq6vzBhTch6cJ93uMl9s7 bgqdr6EzP6VNfeWVo5E7UFqE1n3I1UFtyNZLhko7TcLS6r2X/Le3IGHXt0C+5uQbMl2C Ih0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722521261; x=1723126061; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ySdl7cV1sMC+f6fyOoZuuvhfWYrH1jWG25mq2cl1h0I=; b=vqzxIiiOumpEfYz+0lBoRsvoGcv8UiqgnMZIeoJuqP1zEh0QYXtMqw9l/KNqhLYLF0 0f7GoCana8empGrVoFpVgMvuUZA9Qb9eVGLbbZuMJMvPgkC1LiOZ6e2Hxs2lXY0ZVwcy 6REZz3ZboldL72MB7qlGmLt3Lcn+Rf+TG/rTphZWQHK4g8ZfD880ZyA0Uajfwr+wjk4N 33QCkNh7mM1wZ7bIygUiXRagaBBo5KTYnc7SyuVvYNXmswkCHhIXOZ7h0iCiVTRtRbiF FmKjcIhQpwo78GruHINVy9hpINXNHveGPL+LB2Wr0SZDtl0VYNDCwzAbg0DRBgj3hKG/ k13w== X-Forwarded-Encrypted: i=1; AJvYcCWoI2gnwdigosUCp6opjYKfCXNUUz4owNvkhpC0DYq15idLrFUIFhJu5wOuqH+2rb2G9IFIfJ0STEmkDOo03SLaY7M= X-Gm-Message-State: AOJu0YyS6PgYgWa5PfLX5GjPzTnrWlBMuTm11xk4Wglj9aZlbheuvb66 q/CWtYwcxbgO+w856ltwQU7rYcmkWKqAr3ATncjiKZmvvwsvSZY47J0HHanGwlk= X-Google-Smtp-Source: AGHT+IFqO6la4nVOpFgnsMqcwdnRljSzCYeEa1I3zo/c1Q5/y+I5cm5d7JvT7/VkK7ye+J990oMgpQ== X-Received: by 2002:a0d:c383:0:b0:64b:16ed:7c86 with SMTP id 00721157ae682-6895f12132cmr1193407b3.4.1722521260890; Thu, 01 Aug 2024 07:07:40 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6756bab3d6csm33405877b3.110.2024.08.01.07.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 07:07:40 -0700 (PDT) Date: Thu, 1 Aug 2024 10:07:39 -0400 From: Josef Bacik To: Wojciech =?utf-8?Q?G=C5=82adysz?= Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, kees@kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/fs: last check for exec credentials on NOEXEC mount Message-ID: <20240801140739.GA4186762@perftesting> References: <20240801120745.13318-1-wojciech.gladysz@infogain.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240801120745.13318-1-wojciech.gladysz@infogain.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 24D66180029 X-Stat-Signature: 43xafqnj5begbmnurgynxax98q1efw77 X-Rspam-User: X-HE-Tag: 1722521261-236185 X-HE-Meta: U2FsdGVkX19WIBOxnoQ5xW7zyvLxNll7+fJgeiA75YIckyD+fskHkyKW4/xu3eeQUwruQLzO0C48F4GSn4kr+67HEvlbgbrDTcTxxG+p8y33AJbButHFQKNCz5gfzakPeppcPbW00TRg2oFJag+QLJ0E1DFyZxSKXr8nHUcfkO4glABJ/NKbWDyVUE7BtC5O7cJjq6VSBsydNI0/oDCiBbtHl79XnMdU9oig9AoEXiK9y1poIIxrt6ZDqzIzZLHGWHlNee9NfYrO7yvqi6lT6KSPywQ4yvm+m0PWg6SIUsGYryMR/pJPrvp5sjpnkj2kBWUxIAHeIi3HsLY4VRkXHyNPWdwfjRu90El2Fm2V3wHvSwVLxmCQuRgdHHXccRvsJmGt5+Ra/drCTOJnrE0kN/ZMWwvWngoUof0iBkPFJmkts4J81bm/8uASCzchaW4FuuF3ekcVbO7T1VlnZ6Jf10v3vUquPvpyXEgINoBnJU8VRkbFsecVqMexrEIqvA3ty7J5JKXthnHOOv5FslHGEwcyQ7jfA0Snaf4ifB68iiqF+v3tsubQREw+NBPSgJunbpbA+jvBozH/+a+YixfrYKPybaVQKmiX7zv9ZKdkqaZPumukmqkgEWkPdKFfJGSfMtaGuxF/SSTY3wL7aAQGf0ltR2lF/yqzsOInoysgdDpnf2A2wzA/YpB/O9mesoUxrDCVrkvORgAHwZ3ViAPxQXSVm2Xb1t/5DVOsvVMTAIwRcNbWX+rqLz771EgRlnw6gp54LQzD1FgjgVKjHYLu1CYFTtHdqKFpUze788ia8m16g5w+WAb8sP2ZSlwP8+IaYYD189Hab3ldre4h52t72wZ90/K6CruHmKQNzzIk9WLYVFkGVS0gIdjWgGU6vUJmKRmQVLFPt5FecRjrQINMSqTZ0qnah0x+QB6SeIIf9SRxvoHriWjc3qo0iU5Sw0n/iAxWjxTh0OGEruREbp2 mljy3xTr /sOtUCQsv+lYSTtbuBHoNpD4pHNphEiq6q2F8SXbmlAikrTOXpbhHT6UEb4sgRE3FhBKt3jiaGf+7SUOcDj06gaPusPEkMwmAEiaCLWNJ3vbmusXrwA/UuIBm+hCmgx/EZiECV4eHNJ/eVCJc0OAXSvagF2pwPkT5pztZqRhk613p1TPOTRXhRl+GUYz/zZan0ByDNq8YV8CSM6ljMldbk8CzIbmFDpHoqcrHMrfRFDP3behCB1YuHFkGIDvWn6/yO1l74YhrWK99wsCCYyqNxSFyynbSRWP/sxpCQGEy6oQDUiHS+GASDvZZvoap2iz+Zeaeb567fYB6065PPVPwm1tAcGIA3sj44fPPH0pJmokEPQIJT1VZVy/uDzPLXm1fVtPPxzmZjjl+1rEB3WgPGYWjbJqwyl03j2g0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 02:07:45PM +0200, Wojciech Gładysz wrote: > Test case: thread mounts NOEXEC fuse to a file being executed. > WARN_ON_ONCE is triggered yielding panic for some config. > Add a check to security_bprm_creds_for_exec(bprm). > Need more detail here, a script or something to describe the series of events that gets us here, I can't quite figure out how to do this. > Stack trace: > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 2736 at fs/exec.c:933 do_open_execat+0x311/0x710 fs/exec.c:932 > Modules linked in: > CPU: 0 PID: 2736 Comm: syz-executor384 Not tainted 5.10.0-syzkaller #0 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 > RIP: 0010:do_open_execat+0x311/0x710 fs/exec.c:932 > Code: 89 de e8 02 b1 a1 ff 31 ff 89 de e8 f9 b0 a1 ff 45 84 ff 75 2e 45 85 ed 0f 8f ed 03 00 00 e8 56 ae a1 ff eb bd e8 4f ae a1 ff <0f> 0b 48 c7 c3 f3 ff ff ff 4c 89 f7 e8 9e cb fe ff 49 89 de e9 2d > RSP: 0018:ffffc90008e07c20 EFLAGS: 00010293 > RAX: ffffffff82131ac6 RBX: 0000000000000004 RCX: ffff88801a6611c0 > RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000000 > RBP: ffffc90008e07cf0 R08: ffffffff8213173f R09: ffffc90008e07aa0 > R10: 0000000000000000 R11: dffffc0000000001 R12: ffff8880115810e0 > R13: dffffc0000000000 R14: ffff88801122c040 R15: ffffc90008e07c60 > FS: 00007f9e283ce6c0(0000) GS:ffff888058a00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f9e2848600a CR3: 00000000139de000 CR4: 0000000000352ef0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > bprm_execve+0x60b/0x1c40 fs/exec.c:1939 > do_execveat_common+0x5a6/0x770 fs/exec.c:2077 > do_execve fs/exec.c:2147 [inline] > __do_sys_execve fs/exec.c:2223 [inline] > __se_sys_execve fs/exec.c:2218 [inline] > __x64_sys_execve+0x92/0xb0 fs/exec.c:2218 > do_syscall_64+0x6d/0xa0 arch/x86/entry/common.c:62 > entry_SYSCALL_64_after_hwframe+0x61/0xcb > RIP: 0033:0x7f9e2842f299 > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f9e283ce218 EFLAGS: 00000246 ORIG_RAX: 000000000000003b > RAX: ffffffffffffffda RBX: 00007f9e284bd3f8 RCX: 00007f9e2842f299 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000400 > RBP: 00007f9e284bd3f0 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 00007f9e2848a134 > R13: 0030656c69662f2e R14: 00007ffc819a23d0 R15: 00007f9e28488130 > > Signed-off-by: Wojciech Gładysz > --- > fs/exec.c | 42 +++++++++++++++++++----------------------- > 1 file changed, 19 insertions(+), 23 deletions(-) > > diff --git a/fs/exec.c b/fs/exec.c > index a126e3d1cacb..0cc6a7d033a1 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -953,8 +953,6 @@ EXPORT_SYMBOL(transfer_args_to_stack); > */ > static struct file *do_open_execat(int fd, struct filename *name, int flags) > { > - struct file *file; > - int err; > struct open_flags open_exec_flags = { > .open_flag = O_LARGEFILE | O_RDONLY | __FMODE_EXEC, > .acc_mode = MAY_EXEC, > @@ -969,26 +967,7 @@ static struct file *do_open_execat(int fd, struct filename *name, int flags) > if (flags & AT_EMPTY_PATH) > open_exec_flags.lookup_flags |= LOOKUP_EMPTY; > > - file = do_filp_open(fd, name, &open_exec_flags); > - if (IS_ERR(file)) > - goto out; > - > - /* > - * may_open() has already checked for this, so it should be > - * impossible to trip now. But we need to be extra cautious > - * and check again at the very end too. > - */ > - err = -EACCES; > - if (WARN_ON_ONCE(!S_ISREG(file_inode(file)->i_mode) || > - path_noexec(&file->f_path))) > - goto exit; > - This still needs to be left here to catch any bad actors in the future. Thanks, Josef