From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCA5C3DA64 for ; Thu, 1 Aug 2024 17:45:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27966B008C; Thu, 1 Aug 2024 13:45:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD7426B0092; Thu, 1 Aug 2024 13:45:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6C16B0093; Thu, 1 Aug 2024 13:45:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F40B6B008C for ; Thu, 1 Aug 2024 13:45:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6532C160E9E for ; Thu, 1 Aug 2024 17:45:52 +0000 (UTC) X-FDA: 82404404544.02.5A3579F Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf14.hostedemail.com (Postfix) with ESMTP id 45038100005 for ; Thu, 1 Aug 2024 17:45:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722534308; a=rsa-sha256; cv=none; b=dcUiOCGsIFFhJp1+bpwgVuydQgDLQakyWVVHs4JAQHBuXWxKTm03tJcgT3jZf3aNNZ02Gv pL8xN/vlm6UyZvAmCJ9VkAM21ueTCYylepQrKmfRiwNgrKi9G4X2ghmPmCSY1/S9Z2lZ4m u/+GC6j9ko+DaJSYaI4F7wYcOSIsavc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722534308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLu4NzQwsCQ54ETRdpz0jqWlpzr14tfbsTxoZyMkfUs=; b=ksjqa+nMqzmwalIZxHqrzMx+ZV3KKr84wSsSI7vPUA0vYWOxk3JFKQ15uH6DGr/cFlsmBS fClRoLbm+I/YBfB/h/m8uw06ys36vIFyWS5ct5lx8wAkHTp40vuvbmELdN3klbYL+4ZAGm Sl2gKRkCfyGjksrsJBa1Z1xQb//TS9Q= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WZbsX1GyPz6K6Y1; Fri, 2 Aug 2024 01:43:12 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 41BE0140A86; Fri, 2 Aug 2024 01:45:48 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 1 Aug 2024 18:45:46 +0100 Date: Thu, 1 Aug 2024 18:45:46 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 04/26] MIPS: sgi-ip27: drop HAVE_ARCH_NODEDATA_EXTENSION Message-ID: <20240801184546.00000ba6@Huawei.com> In-Reply-To: <20240801060826.559858-5-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-5-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Queue-Id: 45038100005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ab1tk6uchdgwpkqtpcj3h5wa5ajya8u6 X-HE-Tag: 1722534350-355076 X-HE-Meta: U2FsdGVkX189+YfY5WfmbniuthXNo1Ylsx7bOGx36A0Any33tFn/rkie5/7XG3YuUgDEocohYDpfwaF96HqBbTVKuIsZzCIbpbj84KWnAQH5RYRnP4g71RLV07YZQa7ImmOIQAP+sj3JaUmKP2JTMhRPHhIT8owZbY/Om3NIbMgGgeTLwp4wvVVrQ+RDWR//pOJO7PnBMIQSQblQriXZaOFzliuHYzyM++jD/6muWAf4fQHpuMBWuUuZj0f8p28Me0jGo74fXc8HCz3gKtq2T8sl6mVUJ2CeN18ng7hiDlYIrhZSIy4SMox+wtVtewfKxjQYC02p9YqiouT2UoxBMFIqaW47Eqaa5JT7DDbq6PR+Naeuy2n0kO0B9WaOTsIYXps0NMpMJV4HH5v2HBfEY4eI88vdNJsBtlM0XHCpieSheeOCVlfi9eBGoOHNA7Rlge3do87wVaABzEAfjOkRwiLaA0xMGTeeEMswtC0IywwEmx1OBP/HVdmWYUUtS2mnb89TDHi11wPazG8NVFoZVoYeWQ4LmgRKso1BwtBMQ/64eIzyN2+wlru9XLKH4GNvS7VyPBp6WvS6jB7u2+hZCN0uPGC/xFGMDu2Re6IFyupla3e1JtCWW9q5w6ER4bbagyb4KRE6C2iM4dUjhY3iewLJaEq0NKhUYibo3a9lIuCpTzQ/tlen6BVSC3KyIG6T1F7v5244GXI6drFUc8hapm6/vF3rl0AEWW7SS9GylXbhwALelM6NQNnIqoDTdigZLV1jrkw2HyuCpZ4nXiqFj9THMcEJDEAMuGMqS8LQxUDjR6tVrwRHmUQEb7o1maImGWdjJWAi6sOFdBHrgNfuEmOO9ebkPtn7Ivtezu0BfYlW7XfYddc9hKSTs64qNqe1AoXoJZy57Hz3mTqUV8oE2adw0j0zkI6ott4LBahR6XJjvJ6R6NHjAmZ2VlMG7qPjuJ7yaPB9nSjwM9IO+OL t0ztZwWc 4zkZ1jJ64LV7F0XClcZLRQWKca0dz04sadleyVw3eaVkbwnh6DBJk4D69rN+qFzTwNUF5r5k/T/QvqG5fKkkFDhhUhzN/p23HtT8CFpyeszIeRZ7IEAq88YIoDRNRLoJunxU3mtHqBjwU/1JPXJFFWG8UXSIeGzZxJ4wSYmw+3rkMvRDdGtUAIACZWbhZkysalWIttq8WOJoTg+B033z30Raabkp3QuacZrEo2obzgnNV0G67RSelPsfuHXUc10reNhUB9f4sDZ/xdM84zJ7e7gQjCHQDEaaeccPXZ+ZZFTgr10jLqxWOSJv0Ik2FisjLuWZM02f3sncO2B3i8YGKVMUx5SUApBVKbqHjYkeeFfVfPjKoN5AIHVEhdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:04 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Commit f8f9f21c7848 ("MIPS: Fix build error for loongson64 and > sgi-ip27") added HAVE_ARCH_NODEDATA_EXTENSION to sgi-ip27 to silence a > compilation error that happened because sgi-ip27 didn't define array of > pg_data_t as node_data like most other architectures did. > > After addition of node_data array that matches other architectures and > after ensuring that offline nodes do not appear on node_possible_map, it > is safe to drop arch_alloc_nodedata() and HAVE_ARCH_NODEDATA_EXTENSION > from sgi-ip27. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron > --- > arch/mips/Kconfig | 1 - > arch/mips/sgi-ip27/ip27-memory.c | 10 ---------- > 2 files changed, 11 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 60077e576935..ea5f3c3c31f6 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -735,7 +735,6 @@ config SGI_IP27 > select WAR_R10000_LLSC > select MIPS_L1_CACHE_SHIFT_7 > select NUMA > - select HAVE_ARCH_NODEDATA_EXTENSION > help > This are the SGI Origin 200, Origin 2000 and Onyx 2 Graphics > workstations. To compile a Linux kernel that runs on these, say Y > diff --git a/arch/mips/sgi-ip27/ip27-memory.c b/arch/mips/sgi-ip27/ip27-memory.c > index c30ef6958b97..eb6d2fa41a8a 100644 > --- a/arch/mips/sgi-ip27/ip27-memory.c > +++ b/arch/mips/sgi-ip27/ip27-memory.c > @@ -426,13 +426,3 @@ void __init mem_init(void) > memblock_free_all(); > setup_zero_pages(); /* This comes from node 0 */ > } > - > -pg_data_t * __init arch_alloc_nodedata(int nid) > -{ > - return memblock_alloc(sizeof(pg_data_t), SMP_CACHE_BYTES); > -} > - > -void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > -{ > - __node_data[nid] = (struct node_data *)pgdat; > -}