From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2141DC3DA4A for ; Fri, 2 Aug 2024 11:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB7466B0083; Fri, 2 Aug 2024 07:10:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A676C6B0088; Fri, 2 Aug 2024 07:10:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92ED06B0089; Fri, 2 Aug 2024 07:10:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 75D816B0083 for ; Fri, 2 Aug 2024 07:10:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F96FA7A01 for ; Fri, 2 Aug 2024 11:10:25 +0000 (UTC) X-FDA: 82407036810.02.6423B2A Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf17.hostedemail.com (Postfix) with ESMTP id 1BE0240014 for ; Fri, 2 Aug 2024 11:10:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722596946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e1swGBYUXwE8WUH+IW7UQj8lyIDOboX9MEucq1ypFRc=; b=qKfEyXRIumMFn6FrdoQU8gmo+aRt2sFIZgcXAubVPw0D5bVOVnaVyvBiNTK9FnDB8kpRHm aZX8swZh7lAOSkKxoHNNk47TldtQzXKP55Yq8DISyZGCNDTgOkHOGwJXJ8gCPTzOFLXtpC ZNx51cmaGlXdu3/FNlL3dncqFuU25cA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722596946; a=rsa-sha256; cv=none; b=cpkzP9usT3mjRYd7SuAXE5A6ihW7+Wp/EBjM364gtHI6pEuvUnJsdw8Zpv+cYZNxs9bMqM lu8OvtFK2xzEk76SFF1fNRwWuMxEV3sW9XjpzLuOS2hpwfO2ruzUqXNb4wnjB+i58k4ZMa zcGxDroOwyJ7aXQKmHNJtaCJBFf6Qd8= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb32l3LPdz6K9BV; Fri, 2 Aug 2024 19:07:43 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id CF3FF140A08; Fri, 2 Aug 2024 19:10:20 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 12:10:13 +0100 Date: Fri, 2 Aug 2024 12:10:10 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 21/26] mm: numa_memblks: make several functions and variables static Message-ID: <20240802121010.00000113@Huawei.com> In-Reply-To: <20240801060826.559858-22-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-22-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1BE0240014 X-Stat-Signature: mdxaaxz6815m9adfchcdo8arc4i3too3 X-Rspam-User: X-HE-Tag: 1722597022-129723 X-HE-Meta: U2FsdGVkX18ESjsrbRTOF/kr3E24Yj5eemONR0VqaMrkE0TuHu6dtUTeLk26B3RgSwPjLEs3gNiCJMa2ntMG3+EF4SUZA5H38DTUnZJwF73VCfpqZFrO07t++MVFdvUE9zkb0NYR9G4ctREIDoYdEPF0pd+CRL2UC8uVCHo/8E3ctlgz+N5rpPc2i5UQK7Dh3R+2LB+/3+FyoQl2O28qFZgJ+ohgCyHgp3tjcQ78EVvAGwNwC7WQ4sO9cDwQ/+N7n3IaxQrvuKnjt3IKFbCJBFSQ3nr9iRfETzxCJsQKEIiuHVHWRrWDdOOqs8SIE371qf9/PqYufO3Ed06k+8l7rpWtSc+uhOaU6uRHkzynC11yMeqhiBfs3MviN49zQ7VT5CjaSzRNjD5zPGX42KsaN/0ozeYTnyCKAjxDLGUyWqfqZxaZTtHYK5aXXpjxDprcoi/5nMmkrxWwGyW52yPESAJpbABvk66LYjGCG80cW4Yn5bQ87rNm6/35gGT6uNlfDCwrNgrMmsHqPFzhB1xXKsjAok3YQZMr3tzi/PqzhtjUVpsI7dFmqlUbpKQQW/+h835w/gpQRulun20W6LnHqTU/p+pROwDmfAwXBxZGPAHrm6AWGaHU81AEq3DoILvynVVpngSeO1XhEnymkcUkHamJA1XY1Gjse5tJ7ARijPV/LN7uepLqsoYsZMkTAu5Q0/bWVEdPfq5N1SQ/9gfK9WrnhemOjNF24Y5/JRXTqZ1AjL9BMCb3D1QOi83rBh53XTYsarYRfC9IchP44B2Zr+jEVQYJDfh+1fuFuPsIJrZk3cHbSlE/JcsOpt+7DO3u0ITZ2CQdfHJk2K6gsvwGfKnO8cMkYm1Te6XV+PpI8WiPkKxF+6T1b+Xp9DiGFy9jBc63rdBmm+ZqsaDxsgjbyPWTnrwm+kOWZfmqsKD53Y9N3XJeA1gRhCWgDoQcqH/UNklORbONyjaYHPgPNvZ ohOSCtoz /7WizFt87HsGvs+huGjnlhOKhLC1A6j0aSPEu/RX8oVHG71s1Z10soMsyL1yVoQoxZDEnSBP4dKcAIllGYbwZEwZsBZ/KESQqsZasHhfQhYKqVBZ08Tai9XAhXa4WhBgJljWJheI2aArFc3hzxjWhoAASuBAIxZ7+gqkcKwG9cLT47GSFOieCsI3p5JVY0WnzB6UA5G657QK+RFRgjZekAy1M2QPWHO7ImJFKPAatl+S6jySZ0M9eD0TsMlbOCFB3RuPZnlIiLApjSPnz9Z5p0wPSVYD0OXLWzGg2hQLtK16Tw7IOwlTEw6ewskTtOKyExpsBq66UZjqeFIktbKdYwu+THaUzXL2aOJmof7ijczBrDmBUJ3Cs7VcIA/Ts6iiefwqCH6hfui6N+rMFKHaqDJYBbKAU2U5MgIF5Tu7gGjnlpdI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:21 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Make functions and variables that are exclusively used by numa_memblks > static. > > Move numa_nodemask_from_meminfo() before its callers to avoid forward > declaration. > > Signed-off-by: Mike Rapoport (Microsoft) > Tested-by: Zi Yan # for x86_64 and arm64 Good. I was wondering why some of this internal detail was in the header. Much nicer after this. Reviewed-by: Jonathan Cameron