From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CAEC3DA4A for ; Sat, 10 Aug 2024 07:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BAE76B008A; Sat, 10 Aug 2024 03:04:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06B416B0092; Sat, 10 Aug 2024 03:04:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E752D6B0095; Sat, 10 Aug 2024 03:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA2216B008A for ; Sat, 10 Aug 2024 03:04:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 75F9E1C1CCD for ; Sat, 10 Aug 2024 07:04:09 +0000 (UTC) X-FDA: 82435446618.28.5B5D0A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3165B20021 for ; Sat, 10 Aug 2024 07:04:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=boIx7JIi; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723273373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Q8USz1pOAiaqRRWlGLIQAyb2HgqsoIpN9imeo5Mu3Y=; b=aq2tibz7VXhF3uLTf9gA2QusZkGGOkZvBmqZON5FzZbYSat3bswjkdA219RlgDzkJCTdPe IkRnifU2Rw/HwRySmkFI/YSF2VSTAaQFBIJ8qCDiq7vyaCvYrnzZmKZOZ+EJIW2IZ4yqtk hKEYgLNwNICWqy7jUqW1/kALppjmUKQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723273373; a=rsa-sha256; cv=none; b=d0G6Nwfkhu5YjlHbim8r0tjmj5sCK5o76ojBf3ZIUBWPMhh40mW51+Gnsf/UdJ1r6Rd52a a/QqUM8rb3pGpQPW8gUiUUYJAU8cCC7Uq2xdJVSyvvikOcV0wqel+ha3kKJFwr4BXYyjZi tJet63THv3lRNTFc+L8AqEiQ9GIfMUI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=boIx7JIi; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 05747616E4; Sat, 10 Aug 2024 07:04:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D772C32781; Sat, 10 Aug 2024 07:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723273445; bh=BX2RRXvGlkFKhS4XY9fYvxr6MZbwf9hH+dvqv87yCs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=boIx7JIi/GUawe8x0a3lPWZv5p3X0T1mqYUkK+sD5eAJsAUTY6a5u2dyUHS5ltBA6 bk3Mi3bvU14Sgp16HgF3Q8msLcJzWatN+PM5yBkdapPD2FvzWBPKYSI/uncO9OAZeV 39Bu6hJryH4Ks9KYk3jVAi9bAyqws/QgbUBgkB0A= Date: Sat, 10 Aug 2024 00:04:04 -0700 From: Andrew Morton To: Saurabh Singh Sengar Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ssengar@microsoft.com, wei.liu@kernel.org Subject: Re: [PATCH] mm/vmstat: Defer the refresh_zone_stat_thresholds after all CPUs bringup Message-Id: <20240810000404.b08cb06ebbba7e0de9bb8c72@linux-foundation.org> In-Reply-To: <20240709045750.GA32083@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1720169301-21002-1-git-send-email-ssengar@linux.microsoft.com> <20240705135911.4a6e38379ae95c3fc6bbe7e2@linux-foundation.org> <20240709045750.GA32083@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3165B20021 X-Stat-Signature: 7i3u9499zmohio9jsyogpsxdq63szjm4 X-Rspam-User: X-HE-Tag: 1723273447-611830 X-HE-Meta: U2FsdGVkX1+90rnaezgbiWbpJ7aslTH+GtkPNrahdle26Q4vEmZ08jjQxuZl1IlpwsH5LIB/K4S3boczjXlTWK0feqK3p7K7v65MtlZ/QKyWuy8R/RFHac7juCNhjYaBtW4wi42LUXd2aofGPLx59llmH5T2APMSBdNa7vh0FPBXicOFbFS2vfG9kIxbYkIolmIsnUB5pUhKspdO8kPTMTXt8VFY9VXsM00ExMzoKyYRUJb+e+1jIVD/Sm+JyeEJZeBYlSjNH+S1bOe8XLXPDithr3kzMcHgcbRO8XeLf+i3Evx76Rnv3N8jU2d8BYzAJVMrQFdyzQAq53/rjdQZC4epgVflj091h8IXSM4NsbZE7E2vhoC/waraX/rZh9JFAx/9Ejzax0nmy1X67H1z1nBQWZziCZQw1RC2xNA8+ZZmqPqVjkwmTOVhLVqMdDRYBZ4rxP42VJX26k2EC/eS+c2zoVpqSrLWtSEIdVY1eeNqxv+rZsQT2gVebXBBsqT2nxNGmqpdDZ7KT+J8TowalAi7Kgi+bHELuIG7ljm1nHMY9P6601FHA7xx9SyDWpa3aERbfEFhUu/E299q69o7HbWz+Rl+kyiv5Axn4LjIZ5sZmg54GbVBVr4PI/pFF+avbQms48MrQ2rlyiqMivgBcQKROpDeUPqO2raGo4kMk2aR/hhOEiuIgIFLBxeM7oESYouc4X+sBl6mYPlK5ov27X4eD2WSAYNAAikfYiaN4YqyEQFcROV5+J8KzWgMxy2nMzvN2XyqkF0UjN7iHMH7sMuAcwbmK4rzWC6gNb9FxHt/nCbFudjfGPWg/XVMi1vu8ZG1VJvIE9KDw2J4KLs3XK4hE27lfZxOjKzQ4gxy2zLdInweW+ORBgPYUJ5UyV9/nUPLXn8bBbQzZHMQi687wMXDSOIU9sjPoGNGE6Lv2JRgXejq7sMIPDxy/MpE9BvMypz5Nssdh4HywNVykU0 Efa9pDJs Zgrx2/4bk3bYqRLMEcdMPe6zECUI3EfmOCaWt2PVe8fKFOJh87fd4pCRRxRbq03Nm9EE+WWkNjzxkF/ZitwZ7W9xE9o8s1jdiqBVXluJQhEeDQH0ub3XVLRpB9mUlwQusJq46OrCnwbhiP31YuJ3z1Klc3Zjkksn/5EmgX75Wa42sU79st+wXu8vPLQeyzwS0eyH5ZbKqesi1kg8jGFaHP9VIRELsko7fuAAVyBR0SqoiuboKDjgY4gD5YQL+mGrymKqqORLFmSQ2rTDb56VWZBMFOz60SiKWDtEUt4DqF8lIZo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 8 Jul 2024 21:57:50 -0700 Saurabh Singh Sengar wrote: > > > No NUMA = 1024*2*1*512 = 1,048,576 : Here refresh_zone_stat_thresholds > > > takes around 224 ms total for all the CPUs in the system under test. > > > 16 NUMA = 1024*2*16*512 = 16,777,216 : Here refresh_zone_stat_thresholds > > > takes around 4.5 seconds total for all the CPUs in the system under test. > > > > Did you measure the overall before-and-after times? IOW, how much of > > that 4.5s do we reclaim? > > This entire gain is accounted in over all boot processi time. Most of the Linux > kernel boot process is sequential and doesn't take advantage of SMP. Again, if you were able to measure 4.5s without the patch then you are able to measure how long this delay is with the patch. Please share that number.