linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	 Vlastimil Babka <vbabka@suse.cz>,
	 Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 linux-kselftest@vger.kernel.org, jeffxu@chromium.org,
	oliver.sang@intel.com,  torvalds@linux-foundation.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Kees Cook <kees@kernel.org>,
	Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH v3 1/7] mm: Move can_modify_vma to mm/vma.h
Date: Sat, 17 Aug 2024 01:18:28 +0100	[thread overview]
Message-ID: <20240817-mseal-depessimize-v3-1-d8d2e037df30@gmail.com> (raw)
In-Reply-To: <20240817-mseal-depessimize-v3-0-d8d2e037df30@gmail.com>

Move can_modify_vma to vma.h so it can be inlined properly (with
the intent to remove can_modify_mm callsites).

Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 mm/mseal.c | 17 -----------------
 mm/vma.h   | 28 ++++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 17 deletions(-)

diff --git a/mm/mseal.c b/mm/mseal.c
index 15bba28acc00..2170e2139ca0 100644
--- a/mm/mseal.c
+++ b/mm/mseal.c
@@ -16,28 +16,11 @@
 #include <linux/sched.h>
 #include "internal.h"
 
-static inline bool vma_is_sealed(struct vm_area_struct *vma)
-{
-	return (vma->vm_flags & VM_SEALED);
-}
-
 static inline void set_vma_sealed(struct vm_area_struct *vma)
 {
 	vm_flags_set(vma, VM_SEALED);
 }
 
-/*
- * check if a vma is sealed for modification.
- * return true, if modification is allowed.
- */
-static bool can_modify_vma(struct vm_area_struct *vma)
-{
-	if (unlikely(vma_is_sealed(vma)))
-		return false;
-
-	return true;
-}
-
 static bool is_madv_discard(int behavior)
 {
 	switch (behavior) {
diff --git a/mm/vma.h b/mm/vma.h
index 6efdf1768a0a..e979015cc7fc 100644
--- a/mm/vma.h
+++ b/mm/vma.h
@@ -361,4 +361,32 @@ struct vm_area_struct *vma_iter_prev_range(struct vma_iterator *vmi)
 	return mas_prev_range(&vmi->mas, 0);
 }
 
+#ifdef CONFIG_64BIT
+
+static inline bool vma_is_sealed(struct vm_area_struct *vma)
+{
+	return (vma->vm_flags & VM_SEALED);
+}
+
+/*
+ * check if a vma is sealed for modification.
+ * return true, if modification is allowed.
+ */
+static inline bool can_modify_vma(struct vm_area_struct *vma)
+{
+	if (unlikely(vma_is_sealed(vma)))
+		return false;
+
+	return true;
+}
+
+#else
+
+static inline bool can_modify_vma(struct vm_area_struct *vma)
+{
+	return true;
+}
+
+#endif
+
 #endif	/* __MM_VMA_H */

-- 
2.46.0



  reply	other threads:[~2024-08-17  0:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-17  0:18 [PATCH v3 0/7] mm: Optimize mseal checks Pedro Falcato
2024-08-17  0:18 ` Pedro Falcato [this message]
2024-08-19 20:15   ` [PATCH v3 1/7] mm: Move can_modify_vma to mm/vma.h Liam R. Howlett
2024-08-19 21:00     ` Pedro Falcato
2024-08-21  6:31   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 2/7] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-19 20:22   ` Liam R. Howlett
2024-08-21  6:40   ` Lorenzo Stoakes
2024-08-21 16:15   ` Jeff Xu
2024-08-21 16:23     ` Pedro Falcato
2024-08-21 16:33       ` Jeff Xu
2024-08-21 17:02         ` Lorenzo Stoakes
2024-08-21 18:25         ` Liam R. Howlett
2024-08-21 17:00     ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 3/7] mm/mprotect: " Pedro Falcato
2024-08-19 20:33   ` Liam R. Howlett
2024-08-21  6:51   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 4/7] mm/mremap: " Pedro Falcato
2024-08-19 20:34   ` Liam R. Howlett
2024-08-21  6:53   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 5/7] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-19 20:32   ` Liam R. Howlett
2024-08-21  8:41   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 6/7] mm: Remove can_modify_mm() Pedro Falcato
2024-08-19 20:32   ` Liam R. Howlett
2024-08-21  8:42   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 7/7] selftests/mm: add more mseal traversal tests Pedro Falcato
2024-08-18  6:36   ` Pedro Falcato
2024-08-20 15:45     ` Liam R. Howlett
2024-08-21  8:47   ` Lorenzo Stoakes
2024-08-21 15:56   ` Jeff Xu
2024-08-21 16:20     ` Pedro Falcato
2024-08-21 16:27       ` Jeff Xu
2024-08-21 17:28         ` Pedro Falcato
2024-08-21 17:36           ` Pedro Falcato
2024-08-21 23:37   ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240817-mseal-depessimize-v3-1-d8d2e037df30@gmail.com \
    --to=pedro.falcato@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeffxu@chromium.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mpe@ellerman.id.au \
    --cc=oliver.sang@intel.com \
    --cc=shuah@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).