linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	 Vlastimil Babka <vbabka@suse.cz>,
	 Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 linux-kselftest@vger.kernel.org, jeffxu@chromium.org,
	oliver.sang@intel.com,  torvalds@linux-foundation.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Kees Cook <kees@kernel.org>,
	Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH v3 3/7] mm/mprotect: Replace can_modify_mm with can_modify_vma
Date: Sat, 17 Aug 2024 01:18:30 +0100	[thread overview]
Message-ID: <20240817-mseal-depessimize-v3-3-d8d2e037df30@gmail.com> (raw)
In-Reply-To: <20240817-mseal-depessimize-v3-0-d8d2e037df30@gmail.com>

Avoid taking an extra trip down the mmap tree by checking the vmas
directly. mprotect (per POSIX) tolerates partial failure.

Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 mm/mprotect.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 446f8e5f10d9..0c5d6d06107d 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -611,6 +611,9 @@ mprotect_fixup(struct vma_iterator *vmi, struct mmu_gather *tlb,
 	unsigned long charged = 0;
 	int error;
 
+	if (!can_modify_vma(vma))
+		return -EPERM;
+
 	if (newflags == oldflags) {
 		*pprev = vma;
 		return 0;
@@ -769,15 +772,6 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
 		}
 	}
 
-	/*
-	 * checking if memory is sealed.
-	 * can_modify_mm assumes we have acquired the lock on MM.
-	 */
-	if (unlikely(!can_modify_mm(current->mm, start, end))) {
-		error = -EPERM;
-		goto out;
-	}
-
 	prev = vma_prev(&vmi);
 	if (start > vma->vm_start)
 		prev = vma;

-- 
2.46.0



  parent reply	other threads:[~2024-08-17  0:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-17  0:18 [PATCH v3 0/7] mm: Optimize mseal checks Pedro Falcato
2024-08-17  0:18 ` [PATCH v3 1/7] mm: Move can_modify_vma to mm/vma.h Pedro Falcato
2024-08-19 20:15   ` Liam R. Howlett
2024-08-19 21:00     ` Pedro Falcato
2024-08-21  6:31   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 2/7] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-19 20:22   ` Liam R. Howlett
2024-08-21  6:40   ` Lorenzo Stoakes
2024-08-21 16:15   ` Jeff Xu
2024-08-21 16:23     ` Pedro Falcato
2024-08-21 16:33       ` Jeff Xu
2024-08-21 17:02         ` Lorenzo Stoakes
2024-08-21 18:25         ` Liam R. Howlett
2024-08-21 17:00     ` Lorenzo Stoakes
2024-08-17  0:18 ` Pedro Falcato [this message]
2024-08-19 20:33   ` [PATCH v3 3/7] mm/mprotect: " Liam R. Howlett
2024-08-21  6:51   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 4/7] mm/mremap: " Pedro Falcato
2024-08-19 20:34   ` Liam R. Howlett
2024-08-21  6:53   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 5/7] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-19 20:32   ` Liam R. Howlett
2024-08-21  8:41   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 6/7] mm: Remove can_modify_mm() Pedro Falcato
2024-08-19 20:32   ` Liam R. Howlett
2024-08-21  8:42   ` Lorenzo Stoakes
2024-08-17  0:18 ` [PATCH v3 7/7] selftests/mm: add more mseal traversal tests Pedro Falcato
2024-08-18  6:36   ` Pedro Falcato
2024-08-20 15:45     ` Liam R. Howlett
2024-08-21  8:47   ` Lorenzo Stoakes
2024-08-21 15:56   ` Jeff Xu
2024-08-21 16:20     ` Pedro Falcato
2024-08-21 16:27       ` Jeff Xu
2024-08-21 17:28         ` Pedro Falcato
2024-08-21 17:36           ` Pedro Falcato
2024-08-21 23:37   ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240817-mseal-depessimize-v3-3-d8d2e037df30@gmail.com \
    --to=pedro.falcato@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeffxu@chromium.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mpe@ellerman.id.au \
    --cc=oliver.sang@intel.com \
    --cc=shuah@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).