From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3827FC3DA4A for ; Mon, 19 Aug 2024 12:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C56D66B008A; Mon, 19 Aug 2024 08:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C05FE6B008C; Mon, 19 Aug 2024 08:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1C166B0092; Mon, 19 Aug 2024 08:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96B156B008A for ; Mon, 19 Aug 2024 08:49:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 52876A91AE for ; Mon, 19 Aug 2024 12:49:32 +0000 (UTC) X-FDA: 82468976184.25.E0F90DF Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id 59ECC40010 for ; Mon, 19 Aug 2024 12:49:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724071709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wPms98nUvNcyU9fD/cDSbBH3pNbbF3fet5rZkoCH57I=; b=DMg5Khu7Aizvi5tkG/S1jmSgaieSs4Y4DXIHp9/LYtvFOKKeu4gxf0NfvHJsvHSxhjDeWb YDAyIn+jU9jZIjdo9M8SYoi1RpM35wwpBAKOClyWa163UjJlv6hvbUyja0AzgkQ3Pz6KEz oyAl0e/L6VlzX8S8RR74kkb6AfAX8zo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724071709; a=rsa-sha256; cv=none; b=74dUalr+hafgkbHdEamWPwAtXJCfWR+aU2DqyPKeEaXQ8xSUG5ZCvBrtvPyiXZT4+T72IH W0qilWYbLdCv7i2EABU+V95QZnsDhAK60+djXBBNC1+v20yJ2lKq5X1q5B7ELqJI63VTKQ ksSShylOe9l4k/hC4ZdtdYZaJMCNUho= Received: by verein.lst.de (Postfix, from userid 2407) id 229CF68B05; Mon, 19 Aug 2024 14:49:25 +0200 (CEST) Date: Mon, 19 Aug 2024 14:49:24 +0200 From: Christoph Hellwig To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, Christoph Hellwig , Lorenzo Stoakes , Kees Cook , Eugenio =?iso-8859-1?Q?P=E9rez?= , Jason Wang , Maxime Coquelin , "Michael S. Tsirkin" , Xuan Zhuo Subject: Re: [PATCH v3 3/4] mm: BUG_ON to avoid NULL deference while __GFP_NOFAIL fails Message-ID: <20240819124924.GA7642@lst.de> References: <20240817062449.21164-1-21cnbao@gmail.com> <20240817062449.21164-4-21cnbao@gmail.com> <5654b71c-1d9d-4c48-b28b-664662da8897@redhat.com> <416ac265-ced2-4f90-a347-0a256edf7fdf@redhat.com> <54a4619d-e826-465e-9a0f-0a8f37798e15@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54a4619d-e826-465e-9a0f-0a8f37798e15@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: j5tycepr3istm193rb5abcmf1es6jgjs X-Rspam-User: X-Rspamd-Queue-Id: 59ECC40010 X-Rspamd-Server: rspam02 X-HE-Tag: 1724071770-719493 X-HE-Meta: U2FsdGVkX18vG/b5hEyzwlF45a4aBuK78pK9l19GxN5yx3JNpHqpDY2ciWGQv1B8pAAFFCDsQgCg7OXDJPAdzUTS6dDAW3b+SFk7MEUkf281ngCCaqnvB4OpdGw2alCp+tt2px0Qonjf14ekuBr3DLKPj9jGeX772/GcoXXR7VS3EOhuFhLTZb4pHaFXis+qtcr3xLUhLNLHhqtNZ2/qhNqBhU4nSwk2j/5ObvsRZ9bXDPqzlJO0v4wxVfO0TArV1x7h84GVy+n2Oe3HseYi6mhBFypLBYJbHuRNYqOZSRd7seydBhHEsbMlLj2gMFzz6aM4tJU6W7OqKhS4HY2uHsI0GEwtCnwMDMMDhiaUop/hso1CHVCKMHaGiQCcyfmnxBplkIdUjdWa0S3ZMoZ7wMpgLiDvAPHoFr36byLtSbN4fsIPvpOMB0CCZtT9uAuo8OZB6BtXm5uLTE8TZA683Zd9z20PL0LFT03YakgiIR/KPFExt0dH75dEAhUAPVx7UG1Jm9O2g7NQ39DCEpcOLIrxCFJyDBzci38pNaF5ZXf+z/6Y0k1QwFggLueQEpTY3tkozp4MseHjRKJ5EyayqZv2XJKtYr1+JRPFB3PxSdFBcF42Ul2+2X5KHN2I8rkSDbcy+VpnT5Tjz/MuikeSgLlcmq5eiMUf7kjvUtWFvu8+tn40b3qxgDkv5bK1ERWflThk7mmJC4cL4nAHHeU02V4/IJf70Ki8XcoltadRPP4FxUmhQdXWge7mqN/AB2hS/KI33HkZkdtHAAoL2swki2yC9Zd99qQvSgiQCumti4IE9/m7Odixuen8oi8s2tWzzU1GiknvWyCylPMxBNeR5Q/Jy1arfYdoGH5rs1Cp9aeGHavERdpTUpo4sAzBiJimXLiEBKSmRNthqFUo3bbKTrJQFDMV8bhdQwl75jMHakvu74Hveg8K1/6lEs4wI+RrLdMwVyKW/J7yAFEEfnl KDifLndY wPmNHzzquzQKv3ndkw9cm9agqCpHGPId1MC2fXx1aeYzt6VsaMiumkQ7znakYCQWnXUAS/Pm+kAfjqLVV54rapWsyY9/R1FGThTr5PpbEiZkM2rWh/X0LkTD6jD5OVILbJ6lmre49jCp7liKfppkISLdEQK9pf9wYi8Qu2EUKttnkkMPVaQmadkhDmgBj8erduLBr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 02:33:06PM +0200, David Hildenbrand wrote: > It should all be caught during testing either way. And if some OOT module > does something nasty, that's not our responsibility. > > BUG_ON is not a way to write assertions into the code. So you'd rather create exploits than crashing on a fundamental API violation? That's exactly what the series is trying to fix.