From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAC6C5320E for ; Sun, 25 Aug 2024 17:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D1AF8D000D; Sun, 25 Aug 2024 13:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840C58D0012; Sun, 25 Aug 2024 13:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6357D8D0011; Sun, 25 Aug 2024 13:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F3568D000D for ; Sun, 25 Aug 2024 13:41:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E743680802 for ; Sun, 25 Aug 2024 17:41:48 +0000 (UTC) X-FDA: 82491485496.02.8689880 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf13.hostedemail.com (Postfix) with ESMTP id 5D20D2000D for ; Sun, 25 Aug 2024 17:41:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qw+/s5HW"; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724607665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UgT4seMUoWzFGf2JNTaPprqxOJXGFm2F3/YSXwmhsJQ=; b=dCEw51VHke2/PRXVG+92CVdsT0e9O3LNvZf7CYKsIySDbkzj5cqFH/YifAeIhHl+xrskWD 9QTdR/x3u0w6T5P/7H2yO8nwxglFcoevXI8km7mwjDuyEQHsd5GXMUbsemAZWKXN9hSZBJ CPHvUvdGt5+ovlOyF7iTW/ithTDfkco= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qw+/s5HW"; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724607665; a=rsa-sha256; cv=none; b=CTTBIYe239TO8kg6UBOc3EdetOPw7+uLX8KyIpZRAOit3lc+Syl7CSfbSRYFQmOlWSb2zq o8S3+ykdB9IxzPYc0yxkiHylAAtUhTodxIqHiHYTGNOWc6hYz9g0Dt0clYpbQGS/LvJMwq 4ogNX04mB4s0W2MyWF3DnJvuzuc4oMk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 78494A403D8; Sun, 25 Aug 2024 00:06:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3B39C32781; Sun, 25 Aug 2024 00:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724544398; bh=s9ZUymRC5N50hCwelOFwDegTY8GnrkT1qUjyrttceIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qw+/s5HWsZk5eRGie+x3BFqiFk/iZXsmlDUMOd7YFj5cCVLMfNKHFW4Go+GZg/+ni XlWk5yJ0AdkiGpR3bD6wazE/bY916z9mJS88G4JSSJGZl8xvCJ9BGpjj/Kgcu8V746 N3eVxc6FHwaa9PtB7k2r6Tvfdb/mIq04ppnZfmzjjdvvCxZTUk0IRncg+MeVgghyaL 89PNUJ7rDxW+0fgHXVLkYa0pqSROjyYsFkj4VVcq92lvabgZFm8Tz0aDBcIPE06hn+ Ns27HYjmpKUpb7a2/Yhl1T0zpZiI1Xe1tKdMojloGlLtaRe50w1FyywWA6d+2X9aDt 9ahxbRyfkLr8w== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, kernel test robot , Linux Memory Management List Subject: Re: [akpm-mm:mm-unstable 357/379] mm/vma.h:114:19: error: use of undeclared identifier 'USER_PGTABLES_CEILING' Date: Sat, 24 Aug 2024 17:05:10 -0700 Message-Id: <20240825000510.136384-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5D20D2000D X-Stat-Signature: zmiboeegiya3xe8x5upweuc3d3s1co4m X-HE-Tag: 1724607707-937503 X-HE-Meta: U2FsdGVkX195kvWwyBCLlokcCNBn8u5Wr1eh01NPw0F/2l53AemVpgKNC85lmlRY0De5rwohr3WXKFV/ZAK+Bkiam2PZW94Mk17sLb5mk5pNBJ0DYwUXM5POvle9SNaJP9BIaeUiDQrljDqFbSV3gqfvNIMjsoeH/MFGvcsqBIEJpBOlSD0t3Qf89pDvzn4uc71Y6hFSuHi5bTyVlZXPF5wqCba/nqcYiFOK2Y8Nlj6OPmemkJ+DnbdhoxkV5kfFGqsNXCNd2QbSNJdcDOsUgXeZwvEP1Q+ODgUZ9YSXMOsUYjtMNmUiBEC6qtD0PJ49wMGpcQ6PJYVHAWQjRU81xDCunR10VacwJOYD6okLO6OgNSMUQTbpfvh5HzJKLqgdnKuLWsC0NF0bMe9dbrfchlN0Fjjm/cJBOG8nP3FBmzr+9J0xwn5ZZR0uadNIJWqWsyuyQL/HR/E3n91MH6iVBQMTN3J2slvnEcEbxTvopULVG0m7f+KapxhT0BGp8bJV+SDo1U83YPkNRG3xSlm+e9ihNXBHHMM+suJGWhKVyT28/pdIB1f+mWCCYe02f9f8N35t6nOPMTHIJBGyhejD4GI//nLMS6SoRGBKxVkI8KR+7x0d71jRvwh/K1UyMzK/6Bk9oljywfH2O4OQabgEm9Nw2AvxSecArYJrAwD337qbPD/FyR16Ln80sx2UvgW1fDRIlBps21AOMwWTnMR6GsGXAmuoWKhm8RJxoOTvyscm+oIhmquBreO0qjNjahE5Px1HA+312dVV4J4D0aGzzvfSAYpPbhBn1UkPeQQ7Ar5OKkdUI+BF69sRNK7M8cWcQtl7x6MoPnZqp+Kt35515qaOF1+bNfCIvXNnOwollBmYXKNFlfe3coLK/mRu9Lgil0CBSL8qvKwvPrZNb/B3eF8gHrCxiCJHMjC940hnmanTvNQYM+BSL1rAUZez3AdNFNNjn8zZH71wgefRCqj hjeVx1y/ zkFhcojFjwhKqjpoEuvTIscxGVULOC6nNwwYaIkn+Zl+veJBJkpi/nE39dP7Zlb5/hm5Rz0N4ctQNxMmWgZjX7do4qEbXKhhR2riGyj+OyTtb+Tubu5q/E7YQjhiiUClhH80m5wE/Qr3cQVyn76/d/rxKr0eFoZFmCjrA/GQ+fAT8oqS876Kax9r+Rvo36ZkLf+s90f9WmTCP608j0lDuoyj6rHogqRYJuM8PdjpxoSvCiQ9XZ8j6wYLvBX1VeURr68HM6Zx+vjDD7LnmGm5okxlm4fwxdMJS6EY6YJVZs6kHdGPHx7vYsqpeymltPjMxRkpTgaQhdwpWKnhR7EJ8ysgIhjKc+uZ45pZPJqvGUOafAA/LkHnvrd/ZDjm5mN69mmbbEyem0baX32AlyNlw9s5JhQkBXn0xRjFs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Sat, 24 Aug 2024 20:43:25 +0100 Lorenzo Stoakes wrote: > On Sat, Aug 24, 2024 at 11:14:17PM GMT, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > > head: b659edec079c90012cf8d05624e312d1062b8b87 > > commit: ca39aca8db2d78ff82356defba75d14ce78a67b9 [357/379] mm/vma: track start and end for munmap in vma_munmap_struct > > config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20240824/202408242348.uGvgH9tt-lkp@intel.com/config) > > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 08e5a1de8227512d4774a534b91cb2353cef6284) > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240824/202408242348.uGvgH9tt-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202408242348.uGvgH9tt-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from mm/filemap.c:15: > > In file included from include/linux/dax.h:6: > > In file included from include/linux/mm.h:2198: > > include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] > > 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" > > | ~~~~~~~~~~~ ^ ~~~ > > In file included from mm/filemap.c:52: > > In file included from mm/internal.h:13: > > include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] > > 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); > > | ~~~~~~~~~~~ ^ ~~~ > > include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] > > 49 | NR_ZONE_LRU_BASE + lru, nr_pages); > > | ~~~~~~~~~~~~~~~~ ^ ~~~ > > In file included from mm/filemap.c:52: > > In file included from mm/internal.h:22: > > >> mm/vma.h:114:19: error: use of undeclared identifier 'USER_PGTABLES_CEILING' > > 114 | vms->unmap_end = USER_PGTABLES_CEILING; > > | ^ > > 3 warnings and 1 error generated. > > [snip] > > Thanks for the report! > > This is a trivial issue, and can be fixed with the attached fix-patch. This also > resolves the issue reported in > https://lore.kernel.org/oe-kbuild-all/202408242304.1A1fXTgE-lkp@intel.com/ > > ----8<---- > From 565ad376b0a3aa5822ef479faadff271e90ba51c Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Sat, 24 Aug 2024 20:20:17 +0100 > Subject: [PATCH] mm: include linux/pgtable.h in vma_internal.h > > For some arches this is required in order to have access to > USER_PGTABLES_CEILING and FIRST_USER_ADDRESS. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202408242348.uGvgH9tt-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202408242304.1A1fXTgE-lkp@intel.com/ > Signed-off-by: Lorenzo Stoakes > --- > mm/vma_internal.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/vma_internal.h b/mm/vma_internal.h > index b930ab12a587..971b13e880c9 100644 > --- a/mm/vma_internal.h > +++ b/mm/vma_internal.h > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include > #include > -- > 2.46.0 Even after applying the above patch, I get similar errors when CONFIG_MMU is unset[1], as below. Maybe the case should also be handled? In file included from /lib/../mm/internal.h:22:0, from /lib/vsprintf.c:50: /lib/../mm/vma.h: In function 'init_vma_munmap': /lib/../mm/vma.h:113:21: error: 'FIRST_USER_ADDRESS' undeclared (first use in this function); did you mean 'IFLA_PERM_ADDRESS'? vms->unmap_start = FIRST_USER_ADDRESS; ^~~~~~~~~~~~~~~~~~ IFLA_PERM_ADDRESS /lib/../mm/vma.h:113:21: note: each undeclared identifier is reported only once for each function it appears in /lib/../mm/vma.h:114:19: error: 'USER_PGTABLES_CEILING' undeclared (first use in this function) vms->unmap_end = USER_PGTABLES_CEILING; ^~~~~~~~~~~~~~~~~~~~~ [1] https://github.com/damonitor/damon-tests/blob/master/corr/tests/build_m68k.sh Thanks, SJ