Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Shuah Khan <shuah@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mcgrof@kernel.org, gost.dev@samsung.com,
	linux-kselftest@vger.kernel.org, kernel@pankajraghav.com,
	Zi Yan <ziy@nvidia.com>, Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH] selftests/mm: do not try to split below filesystem block size
Date: Mon, 26 Aug 2024 16:53:44 +0200	[thread overview]
Message-ID: <20240826145344.33665-1-kernel@pankajraghav.com> (raw)

From: Pankaj Raghav <p.raghav@samsung.com>

There is no point trying to split pagecache thp below the blocksize of
the filesystem as that is the minimum order that pagecache needs to
maintain to support blocksizes greater than pagesize [1].

Set the lower limit for the splitting order to be the fs blocksize
order.

As the number of tests will now depend on the minimum splitting order,
move the file preparation before calling ksft_set_plan().

[1] https://lore.kernel.org/linux-fsdevel/20240822135018.1931258-1-kernel@pankajraghav.com/

Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 .../selftests/mm/split_huge_page_test.c       | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
index e5e8dafc9d94..187fe9107998 100644
--- a/tools/testing/selftests/mm/split_huge_page_test.c
+++ b/tools/testing/selftests/mm/split_huge_page_test.c
@@ -9,11 +9,13 @@
 #include <stdlib.h>
 #include <stdarg.h>
 #include <unistd.h>
+#include <math.h>
 #include <inttypes.h>
 #include <string.h>
 #include <fcntl.h>
 #include <sys/mman.h>
 #include <sys/mount.h>
+#include <sys/stat.h>
 #include <malloc.h>
 #include <stdbool.h>
 #include <time.h>
@@ -404,9 +406,10 @@ void split_thp_in_pagecache_to_order(size_t fd_size, int order, const char *fs_l
 
 int main(int argc, char **argv)
 {
-	int i;
+	int i, min_split_order = 0;
 	size_t fd_size;
 	char *optional_xfs_path = NULL;
+	struct stat filestat;
 	char fs_loc_template[] = "/tmp/thp_fs_XXXXXX";
 	const char *fs_loc;
 	bool created_tmp;
@@ -421,8 +424,6 @@ int main(int argc, char **argv)
 	if (argc > 1)
 		optional_xfs_path = argv[1];
 
-	ksft_set_plan(3+9);
-
 	pagesize = getpagesize();
 	pageshift = ffs(pagesize) - 1;
 	pmd_pagesize = read_pmd_pagesize();
@@ -431,13 +432,19 @@ int main(int argc, char **argv)
 
 	fd_size = 2 * pmd_pagesize;
 
+	created_tmp = prepare_thp_fs(optional_xfs_path, fs_loc_template,
+			&fs_loc);
+
+	if (!stat(fs_loc, &filestat))
+		min_split_order = log2(filestat.st_blksize) - pageshift;
+
+	ksft_set_plan(3 + 9 - min_split_order);
+
 	split_pmd_thp();
 	split_pte_mapped_thp();
 	split_file_backed_thp();
 
-	created_tmp = prepare_thp_fs(optional_xfs_path, fs_loc_template,
-			&fs_loc);
-	for (i = 8; i >= 0; i--)
+	for (i = 8; i >= min_split_order; i--)
 		split_thp_in_pagecache_to_order(fd_size, i, fs_loc);
 	cleanup_thp_fs(fs_loc, created_tmp);
 

base-commit: 5771112c37523a2344b346d7fe613694a2566df9
-- 
2.44.1



             reply	other threads:[~2024-08-26 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 14:53 Pankaj Raghav (Samsung) [this message]
2024-08-26 14:59 ` [PATCH] selftests/mm: do not try to split below filesystem block size Zi Yan
2024-08-26 15:01   ` Pankaj Raghav (Samsung)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826145344.33665-1-kernel@pankajraghav.com \
    --to=kernel@pankajraghav.com \
    --cc=akpm@linux-foundation.org \
    --cc=gost.dev@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=shuah@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox