From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F6AC54744 for ; Tue, 27 Aug 2024 23:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10A0C6B0082; Tue, 27 Aug 2024 19:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BA076B0083; Tue, 27 Aug 2024 19:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEAAF6B0085; Tue, 27 Aug 2024 19:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D6CBC6B0082 for ; Tue, 27 Aug 2024 19:42:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8DAB480343 for ; Tue, 27 Aug 2024 23:42:23 +0000 (UTC) X-FDA: 82499651766.23.7DC3687 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id DB54240014 for ; Tue, 27 Aug 2024 23:42:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=O5JA68mO; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724802097; a=rsa-sha256; cv=none; b=R3qn0Zrk5/8GsSZWAHgvLVWprgNqW+kjrDdOm7kLv4ZFVNAbeMJBX+gMOZa/T979E/NTIQ OgDm8kbdUULRGaAF7c3PZKu1orAIkAwIaeZd++RCgwYrjD5QrTtaiE9deojiBrb0sxuftn pVwLSWJf0sdVL7e0PljsjUroNh3gUvA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=O5JA68mO; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724802097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8Ox3gOKfulhv3v7Wt+XhYn3mmlu/+DVLTp5ciErWWk=; b=s2fY1AlCcsdKSh8msAkttfrZIM/KFpZz4nHQ44J12IPa9ojQHYfdGTHloTSk2uYFh76D9U O+zoRn7TmyZvfewmqpq/6dmQj01GHFtqaa8DfI33i1H7SVvJ27rORjoAaNM6JVU8ebcyiq 2OhnVUGv6yd00Ezd5buPH3CPIBwBLq4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F10B3A418B5; Tue, 27 Aug 2024 23:42:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4747CC4AF60; Tue, 27 Aug 2024 23:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724802139; bh=PkPinK6GtuRFl5Q/O1ftstgZgoYWTnwkOR/Zk5lgJT4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O5JA68mOh4xXaS8Xhw6ckkzQc60NQgcKn7WQEr3fM/rULfLqVGY4j118Oo9uxvstD fyPG6pST8mdkoAnisnwfYqOv9HBPyZ05BgYh/1SpFlfUJzo59ms0gddgLSg6r7HDS7 Q3cnwodv45q3v75x3gd9iDLPESS0MCtXF37FZqTg= Date: Tue, 27 Aug 2024 16:42:18 -0700 From: Andrew Morton To: Hongbo Li Cc: , , , , , , , Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper Message-Id: <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> In-Reply-To: <20240827024517.914100-2-lihongbo22@huawei.com> References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-2-lihongbo22@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 3jooa11m1pmrpnhemyapgnq6be4kze44 X-Rspamd-Queue-Id: DB54240014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724802140-471741 X-HE-Meta: U2FsdGVkX1+BS8/wGKmI6dTuQA0txL+VdUDNqMcNkJrIXBLYtn+8PIaF1KOkd4+4zKjufn1jfbjMhxirdtZMl+NnVbZSgmuIeefX0hIUfG7TWAHROcq797GwiPw00m+DZPNbUVCp0cCoPEVV/Og2eWWJl/Ar19GxauufZWpQCq30IHl5lPrWdm4WcRw5/KGLNY1XiIAtxQ3Kyf15/LckPpT0OMN3WMJChw4kI4uRyN3qg9sliGIeTKO2UyI3dQUmW7thd8/b4+rDDNiYatddcxTXTr5dwl5xnbSEQ/IAp8gZ31hem5KQFxkjBR6FJCZoUz8rzrGljQ6Na85VAvcxYUTCqY0irJ1Hu+42cj5TnWTbwObWVhoOlQ9XvCKC4vFWq7nBwURcMl2gaUSx6U8RNaMVNeBJaXuMoFWXyR0XuY/3CLxu3qWh568YA2AliGL2NsC2rMom5oXSIXlWWZz4gfsgB2ewOMWXUV6B5AdMXEVFKC9KMzgRz/8EKmXdQTbvCyBCGsVEMa5hh9ejtnmHtKxTSqAm2NQiewSz4ToA2Lz/BD8D73hfRojZJD80ZMQVMAnitR+IMV55zlxIXxFutIAtY6BfdBwNIs4FAyZOXBuRcYHtvWFZYXmkY583PZw9Z+uyw1/c2OqepWEZXjHsAgDN7HStHhTtnSUxmlbfveg30dbZ3wv3zXjaR0aGofVhXV2Vd/uvMVVD/PCdXfaV6Tv0CZINWZ82JCdeXA4gEruQsUvUJm0zCobqAHEX3mVNIvWeuFK6LAaNzfcw/6g0IaSw/DwzrZydiD3v9dBkSrPqSM841VlG2hxSkHpO9ZnCuj6bXc4Z6mVic3al7AOIQKbN+TWCMJsLhqpBoOpLyOLsBDhmDMVSP1F6ibFgdHgHP8KCdvqKwgxVBYZde3u3cyCqaxpaHhsD0QVh1xbf4SdJV32ioakE4YJlDCKbbPbDXJ7CaeDWgS4/YDWBo9b diQyvpM+ PK0h8vcdQs3X0Fo0txEz8xMHh0gRhF09Y2e3mhZf1u+hcudA2IRBYpufUsAoWbciK/rgf4hcTdzpTvaReijq7nNB5oApLxW0jbcuCCt+hdA/JaM7Vy13IaWOntR8XHNMC/bffFzeWqujGokILP4UV1ieW2+acm0Gwwmc9O4Bb4ZzpcPMPyVRFO5vb0bjdqBzTLfnnMHznPQoF5UDQwWUW4aNowpTX5yoQX3MZyqQyRbKeLo7Jm+EMTD5zCodnKDwtx6KKjUk3AaxKa86g9iwdf8jL3oBoDo5xOwoW8eb0W2zgQMJpTZ3m2BtvLZlxZP6Qb5Sx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 27 Aug 2024 10:45:15 +0800 Hongbo Li wrote: > Add str_true_false()/str_false_true() helper to return "true" or > "false" string literal. > > ... > > --- a/include/linux/string_choices.h > +++ b/include/linux/string_choices.h > @@ -48,6 +48,12 @@ static inline const char *str_up_down(bool v) > } > #define str_down_up(v) str_up_down(!(v)) > > +static inline const char *str_true_false(bool v) > +{ > + return v ? "true" : "false"; > +} > +#define str_false_true(v) str_true_false(!(v)) > + > /** > * str_plural - Return the simple pluralization based on English counts > * @num: Number used for deciding pluralization This might result in copies of the strings "true" and "false" being generated for every .c file which uses this function, resulting in unnecessary bloat. It's possible that the compiler/linker can eliminate this duplication. If not, I suggest that every function in string_choices.h be uninlined.