From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF77CA0ED3 for ; Mon, 2 Sep 2024 21:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 294258D0113; Mon, 2 Sep 2024 17:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 243EA8D00E7; Mon, 2 Sep 2024 17:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1326E8D0113; Mon, 2 Sep 2024 17:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF9498D00E7 for ; Mon, 2 Sep 2024 17:52:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 72036C0426 for ; Mon, 2 Sep 2024 21:52:57 +0000 (UTC) X-FDA: 82521148794.19.867EAAC Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id C0BCC100003 for ; Mon, 2 Sep 2024 21:52:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xyjS5qj+; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725313951; a=rsa-sha256; cv=none; b=k3Q/vO8HNt0Z3NxlPK57gf7vcrZTL2WpxJHAebu9lt9wHZ46mdy2vte7YRYGm2wef62eLT qdNyypw2hYZ6PJ/LuS6ZgjyXbJFbt/Fy+L7rzF/6gn9zYAHIFT0CDWoEA7hqT1rQdmS4u9 mRrDmE8OgKrPB3kuzJ2/BuuuouNfW3Q= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xyjS5qj+; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725313951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OoX0HqXGEa/6F+BFe2n6RmTALXbOTCNYpG6EFWZz1ew=; b=288Y9QzImE/lhaYelcIG6qRS+Wh2GdWhJUxIBN3TuW9FzfExdta6rQ/+vj5+XcSCaS6S+Z AXRFozQYf4jIz5a8EmeVUUuuf/VhWkyIyFuFimTm30BxZwExBf/Z76ONZqOz8xwuvtCBcc mQe+BJ4gk2+2qAsfnOc3jEGrE/nFS7s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8F502A40143; Mon, 2 Sep 2024 21:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99BB1C4CEC2; Mon, 2 Sep 2024 21:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1725313973; bh=24vqQSqoLckxgOVc8ARaONcxfqOIrm8KRgBa6hQ2Oqo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xyjS5qj+O9H9mLCb46Pxw6v5dZusoW34qbCw/sihCiKqAsUL8CD2fpVpRkZ4B5exf TIcWChX6RQMCiyuwVSR4QE+JBJo+XmSmQjLte2kb4ldiKto3+o+GhC+dkb5TDCTGXd zJzlQKETOLTZt7dM7CSNCxppvoXXsQICuD4u/IwE= Date: Mon, 2 Sep 2024 14:52:52 -0700 From: Andrew Morton To: Kent Overstreet Cc: Michal Hocko , Christoph Hellwig , Yafang Shao , jack@suse.cz, Vlastimil Babka , Dave Chinner , Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2 v2] remove PF_MEMALLOC_NORECLAIM Message-Id: <20240902145252.1d2590dbed417d223b896a00@linux-foundation.org> In-Reply-To: References: <20240902095203.1559361-1-mhocko@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C0BCC100003 X-Rspamd-Server: rspam01 X-Stat-Signature: bj5p8w1jeoyycd63kpzz6y799gj89g6x X-HE-Tag: 1725313974-2714 X-HE-Meta: U2FsdGVkX18lvhrsw9aMOL6tb+BAormRxvSxmpOb5+rpMIiIt6Db8zkYG3beJ9oqz+xI/1e/NlXGl52ffUMn5FXXNhV2YAy8bLqAIRGfttgj/+ccIelNIo5OMDlhIp7mpgJ3h6muPtCL1Cv02P/AAt2N7FP6EyHZvDTNSGSsIN2V5w8CbRvyptL0FU0ywP68nURt/RkJakdvnGsYve7LY0Mv0FtdJD2NGqcM3co3Vt600UIv8+UuMU6UG2yB2JhFvHfK2uRfE761o0ipyDNeVacuZEfzEnv7iylXv1UwcDFVy60gH2IZVzW2rYZERwqd9lEC3KJS6j6qbajDetHFsDl7s7irw8sR8LUNMx+CfTisoJSzL15gInTigYZ8K3YHDYPJk2wd3I8p64WFDN5ZPytPn8LFLi6BAgh56LzZFgTRUqQeJDO5jfP+c0oAW2CqewqIIc5LcLQ/2aR/NA0LKHD1cFdaJ7eEOeuod/RjBreB5hK6XtRh6ZmgfPRcjIU4jeqBHVGLLxtVF2NZh2/P032rWJiFK5DRy/h8sENxAzS3MkV+M1sGAZo9HoVojAJcudQOi67RaMRW41X2JTGAyKxxNFALXV4WPpRqBIu2jfkff+YiHZXY2uSkbY3SBZKwOIYUsd8Y7c3CtYv2paDLWSLVz0HY+dtWymmSeuqmA/3tjjSJVQoOk0Zu1patzzXFygKM8Oi7RPppg7FDZSnwxEb0gjVTCHSO81es5wi0nr21TFxQEYNFNpyhKSK2L9xEKCHqgP9t7YkhcM8ehAaBF8TJyMn31S8MafsmlQ+42/b82XAuh/BF1VXQBImZuQbR6Ds+7RkYR7HAF8ZtvSpSOgHVlPt5sc9bVIe1eAJUuXEjii55Uud0sTlfEB3ybgvV/V4c13AG1XvoV7u6AI7dLQxOVaFicLwLNeAkZhlvOqZEBHLJZu5R8KfHjAQ04K6SDIiUc7ilWzYDuLmrn1A ImHUYGkl 6IiUQtxPgGg+F0WMTq0uzF4iUiqzztOsfKDzQ28XtsvC47H2PMxDJHl4G19F8F93SWfu2x9CHNU4wuamPYbniJ9Ih8NJ7+/vkx6JmDmmGe/zNViYv6CJXKgoFTE2RM/rzJogB9ZHjCnbbvR6umFbKkdDNmFosgjSzXh/4oeZz+qGTykS6GJ6fabYd2XPIC7hu/7opevC+2dBkfvyaRIBJ40byHVBZ6MRZfHSPl0sCd04Ilyyt3u92K3dcU3Xa985xO9P1JAg1pq5c1rftn/9dyRa+I5QD9FaFRNbaVm86WBDlI5wVnrL8CBGYnKyuX54wlW0KfQ2NJde/ew5TzPOe//3Q76IoRFYoeN9yJtmlKxREbbZCIMYi0pff+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Sep 2024 05:53:59 -0400 Kent Overstreet wrote: > On Mon, Sep 02, 2024 at 11:51:48AM GMT, Michal Hocko wrote: > > The previous version has been posted in [1]. Based on the review feedback > > I have sent v2 of patches in the same threat but it seems that the > > review has mostly settled on these patches. There is still an open > > discussion on whether having a NORECLAIM allocator semantic (compare to > > atomic) is worthwhile or how to deal with broken GFP_NOFAIL users but > > those are not really relevant to this particular patchset as it 1) > > doesn't aim to implement either of the two and 2) it aims at spreading > > PF_MEMALLOC_NORECLAIM use while it doesn't have a properly defined > > semantic now that it is not widely used and much harder to fix. > > > > I have collected Reviewed-bys and reposting here. These patches are > > touching bcachefs, VFS and core MM so I am not sure which tree to merge > > this through but I guess going through Andrew makes the most sense. > > > > Changes since v1; > > - compile fixes > > - rather than dropping PF_MEMALLOC_NORECLAIM alone reverted eab0af905bfc > > ("mm: introduce PF_MEMALLOC_NORECLAIM, PF_MEMALLOC_NOWARN") suggested > > by Matthew. > > To reiterate: > It would be helpful to summarize your concerns. What runtime impact do you expect this change will have upon bcachefs?