From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E543CD3427 for ; Tue, 3 Sep 2024 03:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5A268D0137; Mon, 2 Sep 2024 23:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B09DA8D0119; Mon, 2 Sep 2024 23:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D12E8D0137; Mon, 2 Sep 2024 23:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 80EF48D0119 for ; Mon, 2 Sep 2024 23:45:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2AB6F1A0185 for ; Tue, 3 Sep 2024 03:45:51 +0000 (UTC) X-FDA: 82522038102.30.F77EC52 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf12.hostedemail.com (Postfix) with ESMTP id 46A844000C for ; Tue, 3 Sep 2024 03:45:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gQnIAiil; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725335024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Km5PVUKhCxGTdG5gL3fi9jYPA6gpZatneH7uhUAa6l0=; b=hmnmk8xmvDBsaaDAbt0Vm53Ro7z+FAxCHZjKjFcKe1a8rdkgoSYLkN8H5/I4oWN3KE5M0S D2Tl549arAz/vshabnxtALpSO/AEhx+rl4YaRXz+q+7H0O3G9HAz+BzLz1DGW0s1d8NhoZ Kp0d2S+1VbuYEPzY0MHVrs4kn/yAvWE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gQnIAiil; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725335024; a=rsa-sha256; cv=none; b=MrMuyMo/sOXgRqaToG7XbwlI1bwNzcp3OJkWOWJr8whBeJUgAwO4cWauk/GPeH+NX2Emk5 BV2pqPE4UQu337OXpzAKmCTiiyjGcTbKOiF11u6LlK6RFIJNYohA6LYqXiJOuf/qYSjf9e 1GCxPdTPy8ynPWt82TrYYd+idw6PDnc= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-6c5bcb8e8edso3450421a12.2 for ; Mon, 02 Sep 2024 20:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725335148; x=1725939948; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Km5PVUKhCxGTdG5gL3fi9jYPA6gpZatneH7uhUAa6l0=; b=gQnIAiilOV/SQzL8Ls35hWlFUizVa+gmrZgBGaXeh7QRBZfeLMMdHd2hxQf5NrFVJN k83Rv3bchBu69RyESm3G4L6dE18nDo4v5hZA/m2WExhiYEOJA4zq3VTwx6yBOWcEoMgF UjO0LizOeNF5aosQ2ewWu8k45+EKiQ3Fbdjb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725335148; x=1725939948; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Km5PVUKhCxGTdG5gL3fi9jYPA6gpZatneH7uhUAa6l0=; b=tTq3k3SBFHe2BzRzePM+xe2dE06rQOvOkJPwKPxQxi3KZhCE9B2wwyohDf+8ESLxlV G0+84uklEAT5vHlA9QGFyM1b/LWdgBxd7L5PHaXvyds+SJaQWC9BNVsTSoYVXzXawfRo 6BAxDWUNEHxun2hdvBWigZ5ApKL299y2HhJACL1OQuEaIWQjuGTgMMwB5vTs1B9DZoFY XJJHYh5j6s8vBJIr1An20qhK9/C6uM2LA4K8CdclyxiI6D+4yRfI2tKYm3U5Jfhr6s3C j30Fq292sER49zkP4IA2JAlehSbZACN9jD4mLJLkOOPSVabNY1b+4CbgbTfl/uHKGwL7 UiaQ== X-Forwarded-Encrypted: i=1; AJvYcCVPYC4KCZDN82Uw1DkDmb+CiWJ+oKzB3g1mYMDk71S1nN+UV+Aqu9hxsLjcNcjVei55eRygzZmsdA==@kvack.org X-Gm-Message-State: AOJu0YzkF+IYod3Mf6Jn0lo7xkZVkCO+na/rlji3N7Ga87u/TTIgHldw vRlJogTmoPxCNAVEryaPG7tgWT9BeSemqrqzo2LWEJJ41bQYbhSiEjPLNVN97g== X-Google-Smtp-Source: AGHT+IF6K8JBsajQW0eAH1EmiEya4ZtXWiyNQ9qkJ5PAUuwlP6Gm7AvchdUNYhclKML3DqwhtiAR0g== X-Received: by 2002:a05:6a21:3984:b0:1c3:b144:2ee1 with SMTP id adf61e73a8af0-1cece045483mr12371543637.44.1725335147814; Mon, 02 Sep 2024 20:45:47 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:43a1:71e3:7464:e91b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2053e1261cbsm48358895ad.228.2024.09.02.20.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 20:45:47 -0700 (PDT) Date: Tue, 3 Sep 2024 12:45:42 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool Message-ID: <20240903034542.GD9738@google.com> References: <20240902072136.578720-1-alexs@kernel.org> <20240903033558.GC9738@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903033558.GC9738@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 46A844000C X-Stat-Signature: xjqb7xteq9j9puaknx8rbahi8nm7tcwz X-Rspam-User: X-HE-Tag: 1725335149-340855 X-HE-Meta: U2FsdGVkX19gk2ToJZKrHfoFSWivsnxTmNxfDOmhMcpU7e3dYEJ1XPeV033/2Tc5Ow/I6MO7bQyPZ7DQYlTNWm68jzGnrJIBWp0/RwPFBKZkLbfo3z7yeEKLez9tS66zsoKeX0MMufnYP0bTxgFdDAhHASBaUJqkb2QuvkoOEXn1YdGIeG8M3cyUXdnmmTNaAIa3cgj/IiplN0NmvVPip1CuvY2ZgS4nzTY9tkXjtYiL1tBNspSf5JLsJ/nHFtwsV10JYOJV8DbPTkl/uh9B/WEfVSBj8aiFo+2tGPOmZ00QowLoh4I5/DmQTDBf8OAaEYzVIj5SudCH2KtiiNGFP5htV5PVJNFANtNtu12zqPeOLIPTCNxp3yKrAqr3IGE34V6/bzggQamGK1Iem/LPZ587DWanRFvc4/imqMfPYloR9XxyvuLX5B9Onry/d/zd6TcAP/NspgkF8anZkJ8q7RSTbBhAdrqKzv4Isyw/vsfktSBdh/lqMtAWUF22tEuLRpXjEvGkAjzqB3Yy+9Lp5lwgGylLoLRs9cKI3/b0/fOjYanSCEPLO/RTa1WuRVrUr5bCKGwe1e3+JgH+aa6ynYTSDKodIP2ak8VLyfDf1+hM5uYMJejj8MBOes/P1ME13nxG2iW+uqVfe7XM5P15WG+ZRoQbwXLqh/Fwr3OtZ6JHO9nBNTwJWDHcTe6N1B+R58HoEBDI1L0ZlKBNwoyS0Vn0Jsz2KuzlRK91G1tgnEKuSpQNhLZAehFFh4vA5+EdI3gfo0/sZ814o1QHP6+BdpFfwS4Oy7Xx1S4c19mqQdt+/bsE8Y2A7Ree+DVuVK4CDPcyd6Pl27iCFbWmkxpCa7+/6C+DvoBy3BrXqX9CLgoMMIwXdWF+ukuqxFoLyURFIUzXb/82nH7bR6l8HXIKMPcH6xm2285l+YsZV1EMkkQPBcfgwsYEjcYaeiQALfpH19CnWLcFU08r8QgQmxm dP3u5YXg +mJWK/PMyT+9C1Oeh4lcScKm7yBDvL32FAEv31ZoIHRK2k9Ehkvv2jbLwIzun/s7IKxHPdliiBLJSgzaxHcMcZlVja2o/FzszTMKuveyckMSAT6isSb+KscnlPH9WOdq8LuALVPkI9aviRST7Jp1cdEaK4SHmX1g/XfgSCmNViJ8ooVbI3FCBjMrAzNqfvrJjEXVvPU0dX7fpoA7TGmQUNWV8xDIQDh/xnURSgGlUbHJ9r69LdlfU8EkeTZJujlRU87ejjZKIbNvWo2MsEFfFFKFh9vShUyNainylCQdFpOvUUMwffWiXQGdEWxUBTYyqEAvLOwByJW2tYa5oXBTN8NT6vrgFn/diHccssm6o0g+9timLnwpOFxBFIG0x9Qxp6r0Op/cYzd4cI4bvCuhHNTHBlc4rbyT9nHsZKry9gy7viNSvG62IYg89VM6PsgEpH2zWReNO3JtIZ58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000219, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/09/03 12:35), Sergey Senozhatsky wrote: > On (24/09/02 15:21), alexs@kernel.org wrote: > > The descriptor still overlays the struct page; nothing has changed > > in that regard. > > [..] > > This patachset does not increase the descriptor size nor introduce any > > functional changes, and could save about 122Kbytes zsmalloc.o size. > > Is this number accurate? Where does such a large saving come from? ./scripts/bloat-o-meter mm/zsmalloc.o-base mm/zsmalloc.o-patched add/remove: 0/0 grow/shrink: 2/6 up/down: 7/-843 (-836) Function old new delta obj_free 211 215 +4 zs_unmap_object 568 571 +3 zs_map_object 661 633 -28 SetZsPageMovable 135 86 -49 free_zspage 310 253 -57 __free_zspage 284 226 -58 zs_page_migrate 1304 1136 -168 async_free_zspage 1099 616 -483