From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E52FCD3420 for ; Tue, 3 Sep 2024 11:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A5848D015D; Tue, 3 Sep 2024 07:37:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956358D013C; Tue, 3 Sep 2024 07:37:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D1D8D015D; Tue, 3 Sep 2024 07:37:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 61AE18D013C for ; Tue, 3 Sep 2024 07:37:35 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1AF3EA0B4B for ; Tue, 3 Sep 2024 11:37:35 +0000 (UTC) X-FDA: 82523226870.22.8C7B142 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf01.hostedemail.com (Postfix) with ESMTP id E36BF4001D for ; Tue, 3 Sep 2024 11:37:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=j8UI95Lk; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725363430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BfQrKnI6k0uPhdUNQxC8mkW1lleMusSB/XuTcAchULs=; b=WlG2TnOtClB33TzjDx/U/JSs1jowDmzbZVALk4bj6L6xYsi89FnPmhSzjvwvQFpC0mv64P IWz16slUcPViXHwtb9JV+oXBIHmH2rnqBtkelov01xnW92Sc2DZ5kw1p0PcEFIT9TMnCpA NaOdL21HYRZjlaICdXMo5m7xouB7cjI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=j8UI95Lk; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725363430; a=rsa-sha256; cv=none; b=geaqFpIaRjapq9qTZhn6cXrM4V8kxZgHsdKVXull32eUAoqVKfs//LNGoSm9qCZPG8vnlW iHzfquoWaPB+lu7guC3I+PyYE+lZV6QSEadDvZcUp0oOTeh0ueFBr8dd0NlBH1vsQksMcb yxWETj+eFcemLHVTUwNaSUzpm33b0W8= Received: from cwcc.thunk.org (pool-173-48-102-194.bstnma.fios.verizon.net [173.48.102.194]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 483BawTE025595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Sep 2024 07:36:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1725363422; bh=BfQrKnI6k0uPhdUNQxC8mkW1lleMusSB/XuTcAchULs=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=j8UI95LkRX1+X4hhOkv7zycF8TDHoc0gw8WxWZhbnaXVAUNERctBG/cjABfYjoa6Q WQXKlVX8IkHFGmlrL7/JudzJX0iBJ2e8tEsf4m+LEt9G9DhXGhj+xhra1DsjK5qL7O OHtjVjTnWI5ZLbO8smRXfy3eyon6/zEOczpMftjZ8JMPipN7qB3x1ARPNzkSsaTGCc TmduoxriNoUAs7o6JDV0Ui7PBNoq75wEv0/vvFqUT/5yD0+gySlqzfptfEq7+inaLR 34BylYa/KnBNhwo7z37TPyYKmTn5u2quoEvRIgyXVIVKSHpdKbao7TSPYJZJcZl1EV er4kDOhMVGXqg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4FF9115C02C4; Tue, 03 Sep 2024 07:36:58 -0400 (EDT) Date: Tue, 3 Sep 2024 07:36:58 -0400 From: "Theodore Ts'o" To: =?iso-8859-1?Q?Andr=E9?= Almeida Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Gabriel Krisman Bertazi Subject: Re: [PATCH v2 2/8] unicode: Create utf8_check_strict_name Message-ID: <20240903113658.GA1002375@mit.edu> References: <20240902225511.757831-1-andrealmeid@igalia.com> <20240902225511.757831-3-andrealmeid@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240902225511.757831-3-andrealmeid@igalia.com> X-Rspam-User: X-Stat-Signature: tizjhrtgdaobwj4wzoy98ycpwz4u6w9a X-Rspamd-Queue-Id: E36BF4001D X-Rspamd-Server: rspam11 X-HE-Tag: 1725363452-378302 X-HE-Meta: U2FsdGVkX1/JCJG6PmKGsx30NA2z5zJ1CzkVDl+Iw3iy0eI/RzEH20E2JIItjmRp8yBWKM8AIOAqB4EAl39npqm6nXw9UItG52opJT0wr4bwJz4VEptFrdKrrGuP2kKc86j2Mpog/Dqac6wJDrBQpQeD9q7LGCyoUpnkAejViCbJ5RcyUVz1t+diF30CIfo2tlOd50bxtCl36LJSSLtePKrVuaAo+1uHgzWlwr64vTch+v+vTsM9CzBn8rqW7In30C/rFd6aQVt52EfWh0TYGVtrPF5mu83X9RNoBNFiH9C9d1Tt6oIjrJVeayj/gQlD3gpKnxrSkCqG7MH5RpK324UqUvo32//AiOLb5PwbHGFZ+t7Y6+mAfzBJrsOSgX9+Z4AZAWpUnYqg7x8AihYyHdjIH1MWd4Q2zXBu8wQVvtO+lkfehe9qqDuihYY8mbZX9Ci4gjIF5SRmJCSWWKgRqFcgTklhIpD3qbNAJuQE90l3hhQDaHpOAwo1RVh+0A2mVCbBNLiHW2p1FvhJNeYAVmiXinw6HURQQ4oowbA9AZ4eqZtA5O3eh+x+aCUBmtqCeQ2H7aKd9NYBmkWKOD9Z4B/XSYl3jOPHhAFjnZcySXuGPNajCgDRjRus+Ov6Nz5et1fKrDMiwcYAlwNky4N0CHF4VtmNIwECxg68eX6dE9zFoA6ZWKc3oUL2VNGwVw6Vdo8WOT6AIrkcuiK8GQx36iauyS4MlNgWn5e+hseekZCPnBT/CE80NlvCfKZQNwDw24L3bpKw7U5EtSl5ziHEwyxJlgOfHzd6beKKxEf01rxRVR1oVFcGfKD1PntNgzirFHZbJf4XeAPShajtLiI44X7pkB+AzKAFXJEFNVp2MDGpjeVucZyN5tSyyzmWHkVTe8gEzufQfEamncUVU/Ja2jUGQkFbnduwCUSKVBGeIXCDjOvOtXwjkTroNwOICeaKdeq97cjFXn+lSZDCwAf T1S7YPbk 8ZsOzvdwnhHaIoYxwEUJTgcafbVfJ9C9WEmYK7UJAL04SB1gdrwAMxzSyXFpWwqUuPA3cAlwjXTIS6UNVJPALdr8RwZSqZhLy1/Tho071o91A+Mfk5AVvBeZyt7+KpRkncScyZBWQIq+GvtoMGLb6UjyktPwc2ZzioqDWdo6b8EZUvANPYsgL78g8HunH9smNh+Pb3foYzW3GiuNAnodoXKSjvL2r7BYgxTkDMU73GTS170rZ6akcc9FKvIv2/dXayTZ0+/ZQ1a8KxAK6l7QeID00sByfQ+4CgSy3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I'd suggest using the one-line summary: unicode: create the helper function utf8_check_strict_name() so that it's a bit more descriptive. On Mon, Sep 02, 2024 at 07:55:04PM -0300, André Almeida wrote: > +/** > + * utf8_check_strict_name - Check if a given name is suitable for a directory > + * > + * This functions checks if the proposed filename is suitable for the parent > + * directory. That means that only valid UTF-8 filenames will be accepted for > + * casefold directories from filesystems created with the strict enconding flags. > + * That also means that any name will be accepted for directories that doesn't > + * have casefold enabled, or aren't being strict with the enconding. I also suggest wrapping with a fill column of 72 characters, instead of 80. - Ted