From: "Theodore Ts'o" <tytso@mit.edu>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
krisman@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-dev@igalia.com, Daniel Rosenberg <drosen@google.com>,
smcv@collabora.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/8] unicode: Fix utf8_load() error path
Date: Tue, 3 Sep 2024 07:40:34 -0400 [thread overview]
Message-ID: <20240903114034.GC1002375@mit.edu> (raw)
In-Reply-To: <20240902225511.757831-2-andrealmeid@igalia.com>
On Mon, Sep 02, 2024 at 07:55:03PM -0300, André Almeida wrote:
> utf8_load() requests the symbol "utf8_data_table" and then checks if the
> requested UTF-8 version is supported. If it's unsupported, it tries to
> put the data table using symbol_put(). If an unsupported version is
> requested, symbol_put() fails like this:
>
> kernel BUG at kernel/module/main.c:786!
> RIP: 0010:__symbol_put+0x93/0xb0
> Call Trace:
> <TASK>
> ? __die_body.cold+0x19/0x27
> ? die+0x2e/0x50
> ? do_trap+0xca/0x110
> ? do_error_trap+0x65/0x80
> ? __symbol_put+0x93/0xb0
> ? exc_invalid_op+0x51/0x70
> ? __symbol_put+0x93/0xb0
> ? asm_exc_invalid_op+0x1a/0x20
> ? __pfx_cmp_name+0x10/0x10
> ? __symbol_put+0x93/0xb0
> ? __symbol_put+0x62/0xb0
> utf8_load+0xf8/0x150
>
> That happens because symbol_put() expects the unique string that
> identify the symbol, instead of a pointer to the loaded symbol. Fix that
> by using such string.
>
> Fixes: 2b3d04787012 ("unicode: Add utf8-data module")
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
Nice catch!
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
next prev parent reply other threads:[~2024-09-03 11:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 22:55 [PATCH v2 0/8] tmpfs: Add case-insesitive support for tmpfs André Almeida
2024-09-02 22:55 ` [PATCH v2 1/8] unicode: Fix utf8_load() error path André Almeida
2024-09-03 11:40 ` Theodore Ts'o [this message]
2024-09-03 16:48 ` Gabriel Krisman Bertazi
2024-09-02 22:55 ` [PATCH v2 2/8] unicode: Create utf8_check_strict_name André Almeida
2024-09-03 9:04 ` kernel test robot
2024-09-03 11:36 ` Theodore Ts'o
2024-09-03 15:34 ` Gabriel Krisman Bertazi
2024-09-02 22:55 ` [PATCH v2 3/8] ext4: Use utf8_check_strict_name helper André Almeida
2024-09-03 11:37 ` Theodore Ts'o
2024-09-02 22:55 ` [PATCH v2 4/8] unicode: Recreate utf8_parse_version() André Almeida
2024-09-03 11:41 ` Theodore Ts'o
2024-09-02 22:55 ` [PATCH v2 5/8] tmpfs: Add casefold lookup support André Almeida
2024-09-03 16:08 ` Gabriel Krisman Bertazi
2024-09-02 22:55 ` [PATCH v2 6/8] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs André Almeida
2024-09-03 9:04 ` kernel test robot
2024-09-03 9:04 ` kernel test robot
2024-09-03 16:15 ` Gabriel Krisman Bertazi
2024-09-04 22:28 ` André Almeida
2024-09-02 22:55 ` [PATCH v2 7/8] tmpfs: Expose filesystem features via sysfs André Almeida
2024-09-02 22:55 ` [PATCH v2 8/8] docs: tmpfs: Add casefold options André Almeida
2024-09-03 16:38 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903114034.GC1002375@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=drosen@google.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smcv@collabora.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).