From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182A6CD3420 for ; Tue, 3 Sep 2024 11:41:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1E0A8D013C; Tue, 3 Sep 2024 07:41:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6F56B02F5; Tue, 3 Sep 2024 07:41:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8206D8D013C; Tue, 3 Sep 2024 07:41:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F5FB6B02F4 for ; Tue, 3 Sep 2024 07:41:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 090B6161293 for ; Tue, 3 Sep 2024 11:41:01 +0000 (UTC) X-FDA: 82523235522.23.5602D29 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf08.hostedemail.com (Postfix) with ESMTP id 40022160008 for ; Tue, 3 Sep 2024 11:40:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=noyAzaRN; spf=pass (imf08.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725363612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9uDcnDmRUAt/LFQyJrObeVyUY2/vhUilyf6vG2h3AhA=; b=B3Wye+oDSz0/BxLvLEc//eA7ZnZcotkfqqYOhWVuhl9qAVfsb4hoDO7QrZzgabUssLB6I6 /d9gw/1gBr7vdUcDc/FgiGHnZFrCTDfuPLQC99BexWPeBi85FYNv/cA1w7QU5vcjLini7j oJF4R9g6pWs424xWIwDimvqvuS5FKsc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=noyAzaRN; spf=pass (imf08.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725363612; a=rsa-sha256; cv=none; b=2LEI+CAWxTcolK5HnJR/5NpJOjqVp9eGtkmCsiYZn3Z04IaZBpDvqS/yiSWmdjppndRpC+ Vhcw+jM3/yuNTXMCUU5J6U5Omu9u6QW4t2wYfKjX1VwYYD6xWEi0gTpoej4dLsmEGPGwTK 0gH1kqFuLCNGOBTQXMo5dVPTuLxzo8g= Received: from cwcc.thunk.org (pool-173-48-102-194.bstnma.fios.verizon.net [173.48.102.194]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 483BeYf6027219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Sep 2024 07:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1725363638; bh=9uDcnDmRUAt/LFQyJrObeVyUY2/vhUilyf6vG2h3AhA=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=noyAzaRNdP+rfmt/qLz8IZCdb6ZHDvAYbbnbnkyvzgUoLtYVV6jM5aSrsOnDmndVW MwRj8APicIvs1lE+vu8kCOHWXd1ivqm31ojIrgHL3XzmLZvrAK3N8ZNplHERKHcxT/ LQlTJ2mgNQVw7LQaajBctkw0v+xjMiL/c7nw1GkQ3gvaI1Vu3F0vx6xz5y8OCI3u4/ l1ZeaZ3fVHXmRsBUrOCyaaaNaG2K7UHZr2aZF5+/r4zES3WbbqO8EffwAz6BfG3IAk uN7LCtOVq30LhxkNREorgSJkud+DLeUkDUT79BX0X2ddZwrtLy7Mg/efxsl89WkEUl r0n8NNJgbdH3g== Received: by cwcc.thunk.org (Postfix, from userid 15806) id B316C15C02C4; Tue, 03 Sep 2024 07:40:34 -0400 (EDT) Date: Tue, 3 Sep 2024 07:40:34 -0400 From: "Theodore Ts'o" To: =?iso-8859-1?Q?Andr=E9?= Almeida Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig Subject: Re: [PATCH v2 1/8] unicode: Fix utf8_load() error path Message-ID: <20240903114034.GC1002375@mit.edu> References: <20240902225511.757831-1-andrealmeid@igalia.com> <20240902225511.757831-2-andrealmeid@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240902225511.757831-2-andrealmeid@igalia.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 40022160008 X-Stat-Signature: 1nm3tg81prscpyztnz74e1finhg3en6j X-HE-Tag: 1725363659-625601 X-HE-Meta: U2FsdGVkX1860BGJ9Em4aqvxBUCwNbfDVYTRJw1bHUzh4n07i1mCyQ6UN6l+ElmuLRR3R1waP74aXGbVUCoLfmYZOm4t6zyiaAkYAxOdGVhpBO8Ldq61NBKdAeNCFIVJCFO4baAgysHkK3wL2HT11AwrZDGgSAEPFt/Jz+hIQeiJKOqdWhX7oHOPB97+P0XWpxLYWai00gnv97mKgD7y8rSZPvqus0jPiIv1i8qp3+NWBZ1YFdbyTIqNcjsy81i+Cl0f86GUNp/ud3P+ijsQ2gsanRoXyglyltE9IrDlK3fqycXVrzJzb7DLcrIMAaaiRsJcdDgH16aTaJj5CalFkjW3eDrLYXjk51nuwQ17TJvqpcJKvEybfE/T/hyv8HaLiq97vEqBqFNPOW9aDrmQBk/isGkBUzvHU/fXNU3eNi+r1O26iQumhwxr+1uf/ifTDb+Rp2WnaALSa++8kEbMzfdbr2kfjg5jycxGFRwCxZ6efDh/jrJPIT/g91inERZNpP0v9//jeKgXruPGp7Nhe3PJq7vyCTi5TVZR5Iq6CAV5riUxXPE4aCGAnLb1pz2MuJZSXFZB4rQ6IobOOs8ppyrXTlTyavSkxrGpNOpepx3+AKElIRq3U06uTV0hFEkNsUePJCL94++TBWH4g/SDpZfKMvtlt6hZx/kT6+WPGDTt4/22ty9mDOHt7yOQZeMsOrLwyzy8xWRAnsVU6kIzARhSHzUgcbBhYXYXE/oU/XpPHGSXOgzmuEJx4rM/jo/sPuQnpN9iOvL5FwVdoKOqcC2c0EJyuat4+v6sEvva36SBfaxtvjp2adI2BdqPVp2nWgXwJiTwinRly8+Wbm2EyCdmDq7pCklso0eyMXU0yKi7YNdww6QH6uMobLIRPEYBz+xsNbCCh6VWJBXg8/Cd4EzDW2CMcRzsTZZu3VS5hfy625gaqSRRLqrjLo+l8tuLI8L94lkvVhR1cfVPbYC YtQr3EkN evq9oeSfCRfdcXxP3oQve+9WU5yxr5ZmnAMZupRmJXjLb388RgTXVN9OYjDx5gN+chxaaBdZxh+icXX9VKUHVnxGVPp7i0kbJXNJxT14Z6rCJR1E/b1oAQGPqZPyzcPr8ZHVjUTWHrbUMlnS1cossYbrsUJd/6NKzGoRIqG1EC8GsRhCyHTZR2SeB6RWdazSsmBtG17cZ5z/GsHbwJ00kLb6vNUOsn0HWp88t7LOLrmmUxY9bwOIWlFFiYm2ap4YesFJhniK+Kl4kVvLFKuOrigNNSOEd4v1+LZqbnREco8R5H7ksVyAEECkxXM4U2XMoG4g4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 07:55:03PM -0300, André Almeida wrote: > utf8_load() requests the symbol "utf8_data_table" and then checks if the > requested UTF-8 version is supported. If it's unsupported, it tries to > put the data table using symbol_put(). If an unsupported version is > requested, symbol_put() fails like this: > > kernel BUG at kernel/module/main.c:786! > RIP: 0010:__symbol_put+0x93/0xb0 > Call Trace: > > ? __die_body.cold+0x19/0x27 > ? die+0x2e/0x50 > ? do_trap+0xca/0x110 > ? do_error_trap+0x65/0x80 > ? __symbol_put+0x93/0xb0 > ? exc_invalid_op+0x51/0x70 > ? __symbol_put+0x93/0xb0 > ? asm_exc_invalid_op+0x1a/0x20 > ? __pfx_cmp_name+0x10/0x10 > ? __symbol_put+0x93/0xb0 > ? __symbol_put+0x62/0xb0 > utf8_load+0xf8/0x150 > > That happens because symbol_put() expects the unique string that > identify the symbol, instead of a pointer to the loaded symbol. Fix that > by using such string. > > Fixes: 2b3d04787012 ("unicode: Add utf8-data module") > Signed-off-by: André Almeida Nice catch! Reviewed-by: Theodore Ts'o