From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19770CD37AB for ; Tue, 3 Sep 2024 18:27:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 966D28D01C9; Tue, 3 Sep 2024 14:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EE688D016E; Tue, 3 Sep 2024 14:27:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768B58D01C9; Tue, 3 Sep 2024 14:27:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 572FA8D016E for ; Tue, 3 Sep 2024 14:27:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F2F5F80878 for ; Tue, 3 Sep 2024 18:27:48 +0000 (UTC) X-FDA: 82524260616.06.101F255 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 1AE88140007 for ; Tue, 3 Sep 2024 18:27:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XnMPxhYx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725387961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d24OUKgm5JQW5fQKGEQedXZHagzGyggF2Py5ZgqPqAo=; b=KDbQ0kPmDd8NPpm+I/IDDbqxjumzShExRH9hg7Aw8bn49Sc6RqcKT0Y06bmGZmWYuk4j+y Cctmlctev0Cqx/xJeQP/wcFfmkvYX6snwA1KQI9H0zj3Sx+/sPPcgH2R7LvQFENMagSS4N gxUKRpcgd9LdbIX4bDpK75kAGPx3DV0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725387961; a=rsa-sha256; cv=none; b=08echojY4wZrwgOjAq1bxbBQHLiVDCclYbCtz83tXVF1x3a/3OlBVtRp6tv7Qlqle6F9w8 2Ip+CDPMs2G/sdZe/NXCRJd2SZBScOKcpz6kcXv/kgZqpFultdsrWirO2ZPHy0eLICQcqZ dWA8zgKU51ZSvR9Rt+dy797apJ4sP7g= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XnMPxhYx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725388066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d24OUKgm5JQW5fQKGEQedXZHagzGyggF2Py5ZgqPqAo=; b=XnMPxhYxo1gsqrUkIBV++Aojxl7liRmg9Gx4nEV4BsGoDsQzWytiklO4Z0Bc/MD8TiWYD2 SWZE10itSTLKxLzkwx5n373PKNfrlqE59oNq3CWIehkEgP6fjwLznZElThB7xQ6JLEte5K AWs61ugJZoUQQWCR7Tf19mpBciYQjJg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-LGAj98RNPu67JNz6csa9dA-1; Tue, 03 Sep 2024 14:27:43 -0400 X-MC-Unique: LGAj98RNPu67JNz6csa9dA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 017141955BEF; Tue, 3 Sep 2024 18:27:41 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.38]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id BB47C30001A4; Tue, 3 Sep 2024 18:27:35 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 3 Sep 2024 20:27:31 +0200 (CEST) Date: Tue, 3 Sep 2024 20:27:24 +0200 From: Oleg Nesterov To: Andrii Nakryiko Cc: Jiri Olsa , Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, peterz@infradead.org, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v4 4/8] uprobes: travers uprobe's consumer list locklessly under SRCU protection Message-ID: <20240903182724.GI17936@redhat.com> References: <20240830143151.GC20163@redhat.com> <20240830202050.GA7440@redhat.com> <20240831161914.GA9683@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1AE88140007 X-Stat-Signature: 4z5i4osws9bmftg88bu5nns4iqa3m8qu X-Rspam-User: X-HE-Tag: 1725388066-251930 X-HE-Meta: U2FsdGVkX1+apcQbtz6z4yJqvrcL5wapVWwIXd0XJg6RqjaX6GniHeMG42wVt41RI3rn+k+1rXCRoKMrk0H6tdB1niNUgxQqgD8+bqRTZjH8VTFr/wLg5yc6k4+FDB2FqXXm7sS4jncc8p9MnpBTSyNwbPlU8iIRudPM8CWxXJvAiehCMJDikEaOGeFZXDth9q67n0JBuyw0YLzmFFGTbRJQU/tcns1C6dxkxjNGRXVO4DBdbbfmBM8bR9qL6WXcx6ZhfwWJA0TqerkXA4ZL7AEi0/Eg3mFUoRtqLZ3CiJwyQPYg0Sc/e/FGqsLZ0riBV021e0YdWSXtSLmUz6pUZPAyQrImaAWjDDY9cwd0qcNuaAMTeAEjFAO2gaXMMxs9AB1ncuESkcEwPmeJ/mwZAGJlPAnA1ur78GbH+RUf5MC5mlO+ySGfX2H7zki3FQ6HsE61VkiJzZvhzgPwptU2G3xLsdFP35YW2paUAbPna1Pj1CErNrmI3yi1KoPHAxwZVhujry6pMDf9DaD32Bc/Dw9izCewyDRbu/qTjYGaRqqxYAGX2vQHqwoLOh9n2csSi9WKIXO+ju5Lva2TjjQHuOj4+/lxZAyQi2Nk+9OwMhQ+UfaJwnclHc0Eb+x6NAKxGX/1L/Csb1lmbRWiRavveZlY4b0Bx7ZF1MXg7hyFBeloObqmEd2kFef5SRF/CygfQzrCG8XIAoe15j4SuDuDOotZ0tMuEHrnQOoc7J3QJSF20prt54o/GJzJgllrQFanRY5z5y6e55diETnxAy8QXzUCXDBCl5OoghiMc1O/OgoY+R3T1ppR+DqWSSVtXDgVs3uDNQIDy6V1V1Ycxwfj41jNX/g+eVPMFP8Cuo51S1x0cUqqBLl8B253NzCbV270JiH7/iuoZpR3FoYrsdAIak8dwWYwQTbaL6lBYJ2lkbNHqS4ae0OmhB/saL5aSnHZWAUIVeMacTMKZ73meP0 MrF5ScJG M9vRXz8lnezlS6OaWJggZDyuZMZtpYi9IUj+Oq1KBTnQwOWJvB09zKqJqkQOthxWTmNm4yptxLBaWiOFsZgWziHurMHZ/j3yW/Qe2d5o3b76AXH1vHpv3B1oT+tDcwd44eWrPnsHBE4g0DhcX1qkClPSE7pHv1L/+eT98FGVax/2hPitcDDttwmqIQQ5KhDl/R0CfRiI3ikGhbMI7klUBlskFgOHwk71KGTvRc8l34AXE0bw51LenonaT/6pdhQDAiX5YjouYDE9ka5I4FvET6ck6EQNAP8G7sxAI/gx7OgHdBVTXtgdZf8R9nQTEg+4ptL4nU+pCvC4c38pYU3D9bcx5fFUJAIkbPW/E8UDRAVtkW0emSqAJC0ycKxLKkPeXi8Ch32mXd+pdj60fOjWGQgbJy3tjS8y4J07oko8TTToUAJU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/03, Andrii Nakryiko wrote: > > On Tue, Sep 3, 2024 at 10:27 AM Andrii Nakryiko > wrote: > > > > On Sat, Aug 31, 2024 at 9:19 AM Oleg Nesterov wrote: > > > > > > But. Since you are going to send another version, may I ask you to add a > > > note into the changelog to explain that this patch assumes (and enforces) > > > the rule about handler/filter consistency? > > > > Yep, will do. I will also leave a comment next to the filter callback > > definition in uprobe_consumer about this. > > > > Ok, I'm adding this: > > diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h > index 29c935b0d504..33236d689d60 100644 > --- a/include/linux/uprobes.h > +++ b/include/linux/uprobes.h > @@ -29,6 +29,14 @@ struct page; > #define MAX_URETPROBE_DEPTH 64 > > struct uprobe_consumer { > + /* > + * handler() can return UPROBE_HANDLER_REMOVE to signal the need to > + * unregister uprobe for current process. If UPROBE_HANDLER_REMOVE is > + * returned, filter() callback has to be implemented as well and it > + * should return false to "confirm" the decision to uninstall uprobe > + * for the current process. If filter() is omitted or returns true, > + * UPROBE_HANDLER_REMOVE is effectively ignored. > + */ Thanks, LGTM. Oleg.