From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF959CD342C for ; Tue, 3 Sep 2024 07:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C54C6B03B2; Tue, 3 Sep 2024 03:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 475D26B03B3; Tue, 3 Sep 2024 03:10:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33D7D8D013C; Tue, 3 Sep 2024 03:10:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17CA36B03B2 for ; Tue, 3 Sep 2024 03:10:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CCCDD409CB for ; Tue, 3 Sep 2024 07:10:00 +0000 (UTC) X-FDA: 82522552560.03.8913769 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id E8EDB1C0009 for ; Tue, 3 Sep 2024 07:09:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=STnHriJm; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725347374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mBrYBheCx9wkNXDMw7EicMa3H2OzuhbqLk8GF6LfcGE=; b=rG4o3jvB5W70vWduJJZ5TwiC8WOykc2YIXm2OwnQpw/0uqvUF7aUd6GWCVonwSiGSrF9Po LHwEpofKw3ZgXwbhwp/I2CsBy8Gv4arsSfyDFQ1Hve/oNYk9VM8ryg6NKasImeGpRoUWdb XBjwEWq/RHPTRUoq7aI2XERwMO2tff4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=STnHriJm; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725347374; a=rsa-sha256; cv=none; b=Td5Y8yy5jNIjvfoOmr9zM1fgQBR3HXRC2hX088HAJpfrFYjIMqlwHFY943LQsTSdzwzKUb VFrJd9GtkdnIELDgEir7tKZreyIJL8F3kuWIIcWMiUOuQNdW+n679qLWCg6FwgnwNpRhri MBslKFAJqxy/8huRL6LmvOUKTf3ulYI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6D4C55C57FA; Tue, 3 Sep 2024 07:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0A8DC4CEC6; Tue, 3 Sep 2024 07:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725347396; bh=YEgWiHXBuskcPndGXIwLrLW9HeAxJb4B1CgKB0BFHno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=STnHriJmfSwk3zd7FKQ9ObfXGV0wHnu1Gp9iLdbedkLQ5S8WiZ4sS1Y4nvq7uIZn4 2zf+kekIOdX8CdCQBcB/NO0NudqAqV428ExhJH16hX6+3uYSe9logxDogC9l2kwMtO EufZDOag7qHsBS9ih9W17bidAngDY9oRbWashrD4= Date: Tue, 3 Sep 2024 09:09:53 +0200 From: Greg Kroah-Hartman To: Andrey Konovalov Cc: Alan Stern , Marcello Sylvester Bauer , Dmitry Vyukov , Aleksandr Nogikh , Marco Elver , Alexander Potapenko , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+2388cdaeb6b10f0c13ac@syzkaller.appspotmail.com, syzbot+17ca2339e34a1d863aad@syzkaller.appspotmail.com, stable@vger.kernel.org, andrey.konovalov@linux.dev Subject: Re: [PATCH] usb: gadget: dummy_hcd: execute hrtimer callback in softirq context Message-ID: <2024090332-whomever-careless-5b7d@gregkh> References: <20240729022316.92219-1-andrey.konovalov@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 1hgj5auxyachcqcwc7gfzw99bzinhgsq X-Rspamd-Queue-Id: E8EDB1C0009 X-Rspamd-Server: rspam11 X-HE-Tag: 1725347397-250154 X-HE-Meta: U2FsdGVkX18B9a0itUomuM6tOV7rEaSssWs490Wp/hhTpIF39XL1MzEfCFQhWFxWZ5CrOk7T6p4NIPIGl8cGVD1RyqB8U5JjZ8VvdWnY9J7XbNMCdD0nhCVeEX1XYNHHSEcldk4VlKisKHq0Ixb5/zEF+C58ZUf4QG+BgI0/8VgHq8z7jrFONjRSxwXznLAZhewd4k50YWBY5xLnY/nwWiGgtuyeDmq4CYJElFnBMlOFj4TekkyyRJfmZY3AiHFmHIavMsQTCwBSEZ7Rcm5ck1WMvuS34sT7DFqLKQK/Px5eLJHbQp3pbyPKAjvrd0dZgDS07xqZFDZKY82WmhIooyOJcwNP9o3oQbeRdBXWFW/kV8rTCgPfi2ENPFksfE+kj7E4pmSDo4Sn9ryTLev/0Pczo59qGbVUw/yjcULEDMLaeMuhH9C0YpMZOCOwAYSV464l9VDF8FHI9JdCk91k4+2ZM7fLRc9h2VQqI8eMzMQ+VcgPXY0nLcmEJAl7aYeRqUj+8GcTbzsHYDGaea5GI81LrA1fQ1E8LlNhp3ZQpyo0KYvFFzCRo47kPMPGVKDonY0OBH21O55+RakjpzbBUCQqpb3T7Jt8MsrzrE0IsTfTyKEnNZbWi2R36XDha2KnJ2qzqW//TxkPNHPXSCYk3GsV3kU52uirGV0p9mkgZI0qNgWmAvFFTJ9T7V0y9L7A2v+HNI7SYfpurJ2t7cCvl11M8Bt+GrDkVQxvvPtyXI1SOSZkrIVlopMigQfbEsr6qhuPsBtwsqhZ4gaa5N0ob+4Stcccm6wKlzM9lYvVJBjzmViJurWapY6GeqUYeGavZVqEMH75GgwRI7NbUk08qYz0c1/gCGlKWCwvyhjJydsT81H4yM9M9+0raPQgBPsIXg6AywW388Lym5J/Ux1PYVwpWdk5dLjZyxrG5IfEMj+dpC9Fcd1ovaJjh9XCsGMo4ERO02Q81+TqVAXyGnb b8T3IHK7 cnzSDgKmp2cmHMhircAvxkzcyQSeb+GM6AFq2MlTKTEDbTC1T14AoRKG2dkAVaa7lrRq+P78XuwIqeNw1bN7diJhAojPLrapR5JAtQQPe+xDLMhwPRPOXo25qiLNi0VuofEuy2DG1b1hE0CRpQNTMG65f42YmjrU4qn/CdA4eE+jFcp/DobAc9tHSBP2Whswq7Fzuku8HY+8swILP84GtNLxSxD26lPdwME89mbjcTBpu9gpWm5fzYjnnm8+8VWPg9dTm657C1NDIVkHeOSYZB5dmo6FvRRR1gsGrvrNgYIritfOA/qZu7Jos3dwPTZov6hCvUrGLp8l7f1O34YqWQ6Vf+MxheRX99FKbA2tEn8/lpnbNYJ1R+vwLElzVTdWvVqwk50xTlvSrHpn/ZVBaJJtTnWF+esIyQ/eRWKNKs9nIuI4LG3QLbX6p57XI13JW5xw7DmzVQjanZ7fGu3rAu6lCtUz5XxNZ5Ajts3HRgXP5kVIDBbp4sZHkuuZ3PtDoAkHklh4R9VtOgjqCRvnTqKZEWFd431FNNf/NeeIkIqt34cB26s2iupokZbGOwZBeAMV2G4KBnSrmz21n55+tXI97JVyrnd1ZHqkwfJEYB9K+UYY0gcgBmics2HJzQ6SqQcQw7oKqQU1pKgUrZmTo8sGWmT7N3Jn6rOZrVdFW+rYrV98mBFyPTLarVGBGoPlRTDtAzDdp4e1XVAoiNWELgUrOXvVIzY9MTXelp52ukcOl1BTgne13rdREdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 02:02:00AM +0200, Andrey Konovalov wrote: > On Mon, Jul 29, 2024 at 4:23 AM wrote: > > > > From: Andrey Konovalov > > > > Commit a7f3813e589f ("usb: gadget: dummy_hcd: Switch to hrtimer transfer > > scheduler") switched dummy_hcd to use hrtimer and made the timer's > > callback be executed in the hardirq context. > > > > With that change, __usb_hcd_giveback_urb now gets executed in the hardirq > > context, which causes problems for KCOV and KMSAN. > > > > One problem is that KCOV now is unable to collect coverage from > > the USB code that gets executed from the dummy_hcd's timer callback, > > as KCOV cannot collect coverage in the hardirq context. > > > > Another problem is that the dummy_hcd hrtimer might get triggered in the > > middle of a softirq with KCOV remote coverage collection enabled, and that > > causes a WARNING in KCOV, as reported by syzbot. (I sent a separate patch > > to shut down this WARNING, but that doesn't fix the other two issues.) > > > > Finally, KMSAN appears to ignore tracking memory copying operations > > that happen in the hardirq context, which causes false positive > > kernel-infoleaks, as reported by syzbot. > > > > Change the hrtimer in dummy_hcd to execute the callback in the softirq > > context. > > > > Reported-by: syzbot+2388cdaeb6b10f0c13ac@syzkaller.appspotmail.com > > Closes: https://syzkaller.appspot.com/bug?extid=2388cdaeb6b10f0c13ac > > Reported-by: syzbot+17ca2339e34a1d863aad@syzkaller.appspotmail.com > > Closes: https://syzkaller.appspot.com/bug?extid=17ca2339e34a1d863aad > > Fixes: a7f3813e589f ("usb: gadget: dummy_hcd: Switch to hrtimer transfer scheduler") > > Cc: stable@vger.kernel.org > > Signed-off-by: Andrey Konovalov > > Hi Greg, > > Could you pick up either this or Marcello's patch > (https://lkml.org/lkml/2024/6/26/969)? In case they got lost. Both are lost now, (and please use lore.kernel.org, not lkml.org), can you resend the one that you wish to see accepted? thanks, greg k-h