From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6FE0CA0ED3 for ; Wed, 4 Sep 2024 08:58:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CC038D0241; Wed, 4 Sep 2024 04:58:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17C768D0239; Wed, 4 Sep 2024 04:58:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0434F8D0241; Wed, 4 Sep 2024 04:58:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D88AD8D0239 for ; Wed, 4 Sep 2024 04:58:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 845D9C0B7D for ; Wed, 4 Sep 2024 08:58:50 +0000 (UTC) X-FDA: 82526455620.22.CEE80DB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id E8D8480018 for ; Wed, 4 Sep 2024 08:58:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VNc+4Fm5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725440258; a=rsa-sha256; cv=none; b=0o91MvjBJXtclH4aRUxZigxtE6vToQLi8wSSkZAfQBM+iyoy+XZNGzjT8tFAjo5ElKmvEU MjL1t+fxrr/B/Chz8kLgXdd6JJ8mBRhtwkjaVb9tG1Mi7HsPZq9jmGcmXlOs5LRUXD9lEu dqVsJaRSBsQ3oYnyVbS0JlR4B+RMhIY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VNc+4Fm5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725440258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wsNKw713r+ze8vLPr30JutMPwkEodw03EznpfZ45lTs=; b=i+j9+1aH4E/in5+Jef4kTy/wVHU5gyoq5JA3YeVAns9I7x5Cq5FCcJ1AdTbU3D9k3W1l8h h548ns4ZWR50SoM3uRQnbW4vRnp34egFdhsXdWK9OqvVqi9lVCOLrQKVbTqCBGmHYe7fJ6 5qHkLJBHpskjZ2rCwTXJ7csl9GrOGfM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 12294A431DF; Wed, 4 Sep 2024 08:58:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AE2EC4CEC5; Wed, 4 Sep 2024 08:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725440327; bh=EtqRKArhzC9Y2UBCDEv3yc4n6+elGDXQTlG0Qw3Q5O4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VNc+4Fm53vgHPTWcFUca263vDcKYtSTlqrOnVIiYGIgsASPppHCj5sEBjmKChKq0i d3Q2l+oaT+OTkgKGfn4PvnPfPhq2+aLG85HwJMYQw9Tr5n/6cBbMiAaIX8q7BAMtcD WVSg+8uyg2bNbIxdgA2d1AzVygqUYyJjm9VRi6Kw5scChZad/gUl/JC8u+o4SFZt0N cu/avGNdr7VwLCqE6dZRdKsCsmlcOl44O7amgqMt9uTPrwkBJCkTTZzeAlkERd5Kk1 lrj5lOirxbil68kgaxWSxR2kT2WoTpbCBeuqmiuMu66EQRmfTsuUg8+JfFYFn38OqG hB+Fsw3P21cvA== Date: Wed, 4 Sep 2024 10:58:43 +0200 From: Christian Brauner To: Vlastimil Babka Cc: Jens Axboe , Jann Horn , Linus Torvalds , Mike Rapoport , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 09/15] sl*b: remove rcu_freeptr_offset from struct kmem_cache Message-ID: <20240904-quallen-stuben-2fefcb33e6b5@brauner> References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-9-76f97e9a4560@kernel.org> <79eb89f6-1e19-4785-b807-1e0459b6011b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <79eb89f6-1e19-4785-b807-1e0459b6011b@suse.cz> X-Rspamd-Queue-Id: E8D8480018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nd19pf6m1co4phox663k43mha4zk1pns X-HE-Tag: 1725440328-51646 X-HE-Meta: U2FsdGVkX1+tuI3LhYZwKINlDLevAaQH+6YRVvcpFf6Yp12yWGdVu0pX6GFe6DY6ikfSskdji1eFUYL3PCQ87OZ50p9+penM2yXHwWJTPcjYeL46U+P8xNvQ83OnafqM0Ir/f0Y8ylMENQQhZkSxV0idCpsibP7QF1nZcA7HH+n7K8wCGu6uTqq7zmdkAqJ3AnRxQo36wXcdScxxtScVHGDAiuwBrPklbPNEYmm7rUGSd7fiSnTyDflQ0FvqGboce3+361cflBXSZX9pAI3sQpQsT/bmIWMv71N8fUPhJV16zc9TDjXlpA3OBgAKzp9PU8Wq5qanB+AgUR9OCzlJLOgM1iRu6eftXnunC+9KeU3MzIlaPrb00/n0/lhW+PMf8DzKPDIkOixvmNNSV0PKafAAdwjslM1IHAeXQsxGWI2L4g6DqNH/XzIKk2AYay0QgselTzXyYavEXCxDMaWqs+5oOiWjbO8qNKzHQY7kx5EjsoO8+0VxG6zUhKOQb4pOhVlCLnu4CCuDEcZyDhF+7+kYCFmMUoMW8mJXh3w9GnrF8Rw6gVZu7E+p6/dJxLTSYdoWN95Ka2Hrdb07dXoYzoXn/lgFYxqWpJa23YM3N4KfOVTdZ/k/Es78ToIS2lUlthtiy/6YIGbvaxPv41+z9OmppVKOAuSzeR13VUQ7v5bk2IXCnSvOaj3DWcAW6bmBu+lzzDSFeJ6/MZVgnNkGpEdP7j5xy59RHaFIgywaE0zAj7NB1jdRvxOYm03A6wgWSsEcJsPly8P1ze5fZ6kHjuHCFf1dfi2x2SiD+rNp62Rf4+rDQv/SuTg6Wfm5CyEdE02dmz+sgZ9gqxVdvqNrkgETgzcbs3/23qzIv64qZUb7WKGwDOwM1W5/6U+E7gFsEO4oE/Y/Daw1WqF2RZ5F+sLmMiXr+jG9tkVBo/GKefR78xLfX8K8g4o2Klx4ZrRkNw7IbGrLU8h6y9T+Hpm AxWr8IrQ 8kuEY4ukRbTjbFRj5oxjdqSmP+ncR03abmHvJqioiXT6yyZjZqcMMjCw0x2A+bw1e9ycYGDlYbeWAfgN/48vdDkwuKRssEb9VfZ6K0Z+jDliRASzNWqSWVoDh893MK08oEWRksIlU+VjYHun0joZOQ4JOjJwAxr3Nnrxwh+XrlwNQwEnnNTh3W01quMcbeEX72cw9izxse+CLgnAu1i55Mk9PFKQ/rdTxHRQsF+AMy+aI2/EOjGwZAk0gO7M30tKyMRKq3KVw9ipttT/10KGRswAYje4eITiyzWDWaVFlw8AikA8E97eCLaRZ6XbFxoX4fsk2WYwgtwSXBEco/wAY7LBAnqC2++2GsMRp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 10:16:17AM GMT, Vlastimil Babka wrote: > On 9/3/24 16:20, Christian Brauner wrote: > > Now that we pass down struct kmem_cache_args to calculate_sizes() we > > don't need it anymore. > > Nit: that sounds like a previous patch did the "pass down" part? Fine to do > both at once but maybe adjust description that we do both here? Hm, maybe that was misleadingly phrased but my intention was to express that this patch passes it down and removes the now unneeded member from struct kmem_cache. I've rephrased this to: "Pass down struct kmem_cache_args to calculate_sizes() so we can use args->{use}_freeptr_offset directly. This allows us to remove ->rcu_freeptr_offset from struct kmem_cache." on the work.kmem_cache_args branch.