From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CAFCD4857 for ; Wed, 4 Sep 2024 16:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B6BA6B02B2; Wed, 4 Sep 2024 12:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13FF76B02B3; Wed, 4 Sep 2024 12:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0061B6B02B4; Wed, 4 Sep 2024 12:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D5F7D6B02B2 for ; Wed, 4 Sep 2024 12:53:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5F4741615C1 for ; Wed, 4 Sep 2024 16:53:09 +0000 (UTC) X-FDA: 82527650898.06.388C100 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id CBDD240020 for ; Wed, 4 Sep 2024 16:53:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sk8nuKUV; spf=pass (imf01.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725468762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=elpzjAhtI8GUE5qGx/aoSjcs3PBhkibSZi6OSmK5daQ=; b=EenIOFQE9sNsnRceW2XBP5MriRdpvyfu0prpreTTV/btmj2kqm/cCIIFZ562juO457T58Q pAab0Nv/on3Mvkmro/E1zJcm1bSAuPZlBC6a9V3PJJwxG/ePc2/VkSLkEkn1BtIvdRjelD FEDG+bFxIAyx9HW8ItNddFWy0oy4ZE4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sk8nuKUV; spf=pass (imf01.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725468762; a=rsa-sha256; cv=none; b=X26F3M6JF5nZXEyElg653july/R0dgKHZgn7YBAd9/uWfVlJZgwId3kl1RN8XfLlWYpEmR VMfqAHUsxS/hOLAgmSQt7r/37C2QHfXzvbMm+9PnF2GX3rGqrOayEMi5lXvgeRlvaDHJeo jkSLlB3ACwpmaMSbGyKbsszD1Ro4xNI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D620EA44519; Wed, 4 Sep 2024 16:52:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9D58C4CEC2; Wed, 4 Sep 2024 16:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725468785; bh=u1tfE+6LTF/AZPaX62ARJpFZTaHNZWfbhWhv90/bG3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sk8nuKUVpGPOYGgLAnFueUUTfsYVEYnDPrpSv0ecfRmwV4ID2QN+6CZJ52PZeMEyq PffZmkN9T3tcvABDERA/L7KuP7H8bebBjTBxS/80+7ZQoZ/mJTcpmqMsXFy19uLc5K LMioyZDfR5rkW+6LYJKFZaYxWLLOEkZ2i837+cd5rx0YUy3zxqPV1xP+Z1VzTCJocl 5qASXHEvlnPlb7v7ql6jHpsBWHUy3DEZKm/37slbHE/n6FuB+HqXWEu7RqRea4lAHC SiNfmh2JSl6Tpbudo2zc35pkpcISRqR3lipSVgE5e0I3mfNYSqnFdCUNzh/cpzx/zM QCNtmUd5TDutw== Date: Wed, 4 Sep 2024 18:53:00 +0200 From: Christian Brauner To: Mike Rapoport Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 02/15] slab: add struct kmem_cache_args Message-ID: <20240904-warfen-labyrinth-f16ea368a200@brauner> References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> <20240904-bauaufsicht-gewohnheit-a70bd9266986@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: kuof1subpzqutgifmk65ydphipxfogm8 X-Rspamd-Queue-Id: CBDD240020 X-Rspamd-Server: rspam11 X-HE-Tag: 1725468786-386306 X-HE-Meta: U2FsdGVkX1/ktWle3j+qcZxcEjno3aSI5DzpjHtaLbMj4ZjcxPH7GWUopKEKJ91R5fnN0LASd23aOTl6dr4LStoNCYAkcgnfx1Gq8AwILL+XOmrI3mya5v0GhtjATyFmemHZrTMC01dfGr5xM0F+WnoA0c/KZuzXPnq6pr7dfwLvAT9yKnG3brg9MNX4x6vU1USOmn6Jr6moF/lS9CmLuhI+BydQO84sWoReYCRLM/O7kH64kePcESXC4N09h70sQ7JxyXsT4AinUAbn8aD9wsirh6s6Pt9UeWTlO3YRef/JhuxU2lbsmCt7GW9E8gWxtkBqh6wEkoomcFymFZqd+do1Ak3T31GH+KW0klittTQETkXqWF7MDacZA6VOWrIGFsA/kvbUxGdb2V0Me+XJ5ISxJMU+uxz0d3wPfkynJRa7V7ADPyCoFRoO9QtRLrGzPThX7PQR/UWgCkjugr5vZoGCXQmfccpBzxCOKUw3BHHFfAjVMcNpaihzkFZ1fVADyEx3dDLx9UoNHjsiuGWwtfyvlMffrCVCsFRcxIw+Tb6TbTtMog2WoO28SjCUW24S/cZiudSnF1/AWhlFWc7C+JZ5ejHItGwS5XujOqMUwBpxKwtVNVocJJ2qSOn8UmKNgnZBMzakOP5DQ5sTnWk+c7nxhrC3glSjIZMRKVaLX1WZwlE3LONS5suFNVHY8Sytl+wn7FTyJI+tfmW7CqGQn+6qHPzmyz+GjEhuEDcaxFeNGIYnMBDhGzY6Vax79OT2WNuhOHZl92oQJw16VkUMmIT0skITOw0kBeRm+CqZqAGuYF5AE2dszdY1eS7D/KUSYArNcNBsqpiDAYDKR+If5L+8g0eSG/ck2v6chK1SrkKPC4vFfH3Q1PS8PCy+08MnRQkTQuEVFhjhtYpOUFld6+evgRmKGFX2JDVlJoBOMJGYgUh7ZX9MWpAbg81X5HnwAmlZKbjzUoKR68ACgCm StIToetc dCBj9Y4w7046n/UNrNVRjc6obGZm+LsFFiampRfZ6x5TQQJuiJWYoiKg8TGMJxtL/ilt9HkGnwYbJ/iDdutnmlv5CzXU4ORx8ObJ3hwthl3VXAMz1ya2owJ5fh31V/G/C7BXx5hX52WfFcf7MHvlxBirQ+4Rzxcj+XfqNJABJn+cSOpF778mp8yngVfWgNTFN3PztfxcleNEkAFtA4Ity2o2QQDg0IYvIBAXWS+cMbOQ+iZxwFtNF2F6pg3JThwTeYOno05mR3zlklAACn72AsInf7PGGmLcsrubFubNVC/jSKsZQi0X8wYLLDB7QQ28FSLWnOrHeQykD0VhVAfdXtjw7fgQ38xtogO2dryiA+yOH+PNQga3yV4/w3u7WwY3fU6zl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 07:16:07PM GMT, Mike Rapoport wrote: > On Wed, Sep 04, 2024 at 05:48:31PM +0200, Christian Brauner wrote: > > On Wed, Sep 04, 2024 at 06:16:16PM GMT, Mike Rapoport wrote: > > > On Tue, Sep 03, 2024 at 04:20:43PM +0200, Christian Brauner wrote: > > > > Signed-off-by: Christian Brauner > > > > --- > > > > include/linux/slab.h | 21 ++++++++++++++++ > > > > mm/slab_common.c | 67 +++++++++++++++++++++++++++++++++++++++------------- > > > > 2 files changed, 72 insertions(+), 16 deletions(-) > > > > > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > > > index 5b2da2cf31a8..79d8c8bca4a4 100644 > > > > --- a/include/linux/slab.h > > > > +++ b/include/linux/slab.h > > > > @@ -240,6 +240,27 @@ struct mem_cgroup; > > > > */ > > > > bool slab_is_available(void); > > > > > > > > +/** > > > > + * @align: The required alignment for the objects. > > > > + * @useroffset: Usercopy region offset > > > > + * @usersize: Usercopy region size > > > > + * @freeptr_offset: Custom offset for the free pointer in RCU caches > > > > + * @use_freeptr_offset: Whether a @freeptr_offset is used > > > > + * @ctor: A constructor for the objects. > > > > + */ > > > > +struct kmem_cache_args { > > > > + unsigned int align; > > > > + unsigned int useroffset; > > > > + unsigned int usersize; > > > > + unsigned int freeptr_offset; > > > > + bool use_freeptr_offset; > > > > + void (*ctor)(void *); > > > > +}; > > > > + > > > > +struct kmem_cache *__kmem_cache_create_args(const char *name, > > > > + unsigned int object_size, > > > > + struct kmem_cache_args *args, > > > > + slab_flags_t flags); > > > > struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > > > > unsigned int align, slab_flags_t flags, > > > > void (*ctor)(void *)); > > > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > > > index 91e0e36e4379..0f13c045b8d1 100644 > > > > --- a/mm/slab_common.c > > > > +++ b/mm/slab_common.c > > > > @@ -248,14 +248,24 @@ static struct kmem_cache *create_cache(const char *name, > > > > return ERR_PTR(err); > > > > } > > > > > > > > -static struct kmem_cache * > > > > -do_kmem_cache_create_usercopy(const char *name, > > > > - unsigned int size, unsigned int freeptr_offset, > > > > - unsigned int align, slab_flags_t flags, > > > > - unsigned int useroffset, unsigned int usersize, > > > > - void (*ctor)(void *)) > > > > +/** > > > > + * __kmem_cache_create_args - Create a kmem cache > > > > + * @name: A string which is used in /proc/slabinfo to identify this cache. > > > > + * @object_size: The size of objects to be created in this cache. > > > > + * @args: Arguments for the cache creation (see struct kmem_cache_args). > > > > + * @flags: See %SLAB_* flags for an explanation of individual @flags. > > > > + * > > > > + * Cannot be called within a interrupt, but can be interrupted. > > > > + * > > > > + * Return: a pointer to the cache on success, NULL on failure. > > > > + */ > > > > +struct kmem_cache *__kmem_cache_create_args(const char *name, > > > > + unsigned int object_size, > > > > + struct kmem_cache_args *args, > > > > + slab_flags_t flags) > > > > { > > > > struct kmem_cache *s = NULL; > > > > + unsigned int freeptr_offset = UINT_MAX; > > > > const char *cache_name; > > > > int err; > > > > > > > > @@ -275,7 +285,7 @@ do_kmem_cache_create_usercopy(const char *name, > > > > > > > > mutex_lock(&slab_mutex); > > > > > > > > - err = kmem_cache_sanity_check(name, size); > > > > + err = kmem_cache_sanity_check(name, object_size); > > > > if (err) { > > > > goto out_unlock; > > > > } > > > > @@ -296,12 +306,14 @@ do_kmem_cache_create_usercopy(const char *name, > > > > > > > > /* Fail closed on bad usersize of useroffset values. */ > > > > if (!IS_ENABLED(CONFIG_HARDENED_USERCOPY) || > > > > - WARN_ON(!usersize && useroffset) || > > > > - WARN_ON(size < usersize || size - usersize < useroffset)) > > > > - usersize = useroffset = 0; > > > > - > > > > - if (!usersize) > > > > - s = __kmem_cache_alias(name, size, align, flags, ctor); > > > > + WARN_ON(!args->usersize && args->useroffset) || > > > > + WARN_ON(object_size < args->usersize || > > > > + object_size - args->usersize < args->useroffset)) > > > > + args->usersize = args->useroffset = 0; > > > > + > > > > + if (!args->usersize) > > > > + s = __kmem_cache_alias(name, object_size, args->align, flags, > > > > + args->ctor); > > > > > > Sorry I missed it in the previous review, but nothing guaranties that > > > nobody will call kmem_cache_create_args with args != NULL. > > > > > > I think there should be a check for args != NULL and a substitution of args > > > with defaults if it actually was NULL. > > > > I think that callers that pass NULL should all be switched to > > KMEM_CACHE() and passing NULL should simply not be supported. And the > > few callers that need some very special alignment need to pass struct > > kmem_cache_args anyway. So there should never be a need to pass NULL. > > But you can't guarantee that some random driver won't call > > __kmem_cache_create_args("name", size, NULL, flags); > > At least we'd need > > if (!args) > return -EINVAL; Calling __kmem_cache_create_args() directly is a bug. That's why it's __*(). And we don't check for non-NULL @name either. In fact we almost never do such checks. Plus, if someone did: kmem_cache_create("foo", sizeof(foo), NULL, flags); they'd get a compile time error due to _Generic().