From: Dev Jain <dev.jain@arm.com>
To: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org,
kirill.shutemov@linux.intel.com
Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com,
catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz,
mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com,
will@kernel.org, baohua@kernel.org, jack@suse.cz,
mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org,
yang@os.amperecomputing.com, peterx@redhat.com,
ioworker0@gmail.com, jglisse@google.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Dev Jain <dev.jain@arm.com>
Subject: [PATCH v2 0/2] Do not shatter hugezeropage on wp-fault
Date: Wed, 4 Sep 2024 15:39:21 +0530 [thread overview]
Message-ID: <20240904100923.290042-1-dev.jain@arm.com> (raw)
It was observed at [1] and [2] that the current kernel behaviour of
shattering a hugezeropage is inconsistent and suboptimal. For a VMA with
a THP allowable order, when we write-fault on it, the kernel installs a
PMD-mapped THP. On the other hand, if we first get a read fault, we get
a PMD pointing to the hugezeropage; subsequent write will trigger a
write-protection fault, shattering the hugezeropage into one writable
page, and all the other PTEs write-protected. The conclusion being, as
compared to the case of a single write-fault, applications have to suffer
512 extra page faults if they were to use the VMA as such, plus we get
the overhead of khugepaged trying to replace that area with a THP anyway.
Instead, replace the hugezeropage with a THP on wp-fault.
v1->v2:
- Wrap do_huge_zero_wp_pmd_locked() around lock and unlock
- Call thp_fault_alloc() before do_huge_zero_wp_pmd_locked() to avoid
- calling sleeping function from spinlock context
[1]: https://lore.kernel.org/all/3743d7e1-0b79-4eaf-82d5-d1ca29fe347d@arm.com/
[2]: https://lore.kernel.org/all/1cfae0c0-96a2-4308-9c62-f7a640520242@arm.com/
Dev Jain (2):
mm: Abstract THP allocation
mm: Allocate THP on hugezeropage wp-fault
include/linux/huge_mm.h | 6 ++
mm/huge_memory.c | 171 +++++++++++++++++++++++++++++-----------
mm/memory.c | 5 +-
3 files changed, 136 insertions(+), 46 deletions(-)
--
2.30.2
next reply other threads:[~2024-09-04 10:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 10:09 Dev Jain [this message]
2024-09-04 10:09 ` [PATCH v2 1/2] mm: Abstract THP allocation Dev Jain
2024-09-05 8:20 ` Kirill A. Shutemov
2024-09-05 8:45 ` Dev Jain
2024-09-05 11:08 ` Ryan Roberts
2024-09-06 5:42 ` Dev Jain
2024-09-06 8:28 ` Ryan Roberts
2024-09-06 8:45 ` Dev Jain
2024-09-06 9:00 ` Ryan Roberts
2024-09-04 10:09 ` [PATCH v2 2/2] mm: Allocate THP on hugezeropage wp-fault Dev Jain
2024-09-05 8:26 ` Kirill A. Shutemov
2024-09-05 8:52 ` Dev Jain
2024-09-05 9:41 ` Kefeng Wang
2024-09-05 9:53 ` Dev Jain
2024-09-05 13:14 ` Ryan Roberts
2024-09-06 7:05 ` Dev Jain
2024-09-06 8:43 ` Ryan Roberts
2024-09-06 9:00 ` Dev Jain
2024-09-06 9:31 ` Ryan Roberts
2024-09-04 11:36 ` [PATCH v2 0/2] Do not shatter hugezeropage on wp-fault Ryan Roberts
2024-09-04 15:41 ` Dev Jain
2024-09-04 16:01 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904100923.290042-1-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).