From: Wang Yibo <lcnwed@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
trivial@kernel.org, Wang Yibo <wangyibo@uniontech.com>
Subject: [PATCH] mm: move bad zone checking before getting it
Date: Thu, 5 Sep 2024 17:52:16 +0800 [thread overview]
Message-ID: <20240905095216.7888-1-wangyibo@uniontech.com> (raw)
When flags from gfp_zone() has an error combination, VM_BUG_ON() should firt know it before use it.
Signed-off-by: Wang Yibo <wangyibo@uniontech.com>
---
include/linux/gfp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index f53f76e0b17e..ca61b2440ab3 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -133,10 +133,11 @@ static inline enum zone_type gfp_zone(gfp_t flags)
{
enum zone_type z;
int bit = (__force int) (flags & GFP_ZONEMASK);
+ VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1);
z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) &
((1 << GFP_ZONES_SHIFT) - 1);
- VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1);
+
return z;
}
--
2.20.1
next reply other threads:[~2024-09-05 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 9:52 Wang Yibo [this message]
2024-09-05 10:22 ` [PATCH] mm: move bad zone checking before getting it David Hildenbrand
2024-09-05 10:48 ` [PATCH v2 1/1] mm: move bad zone checking in gfp_zone() Wang Yibo
2024-09-05 13:13 ` David Hildenbrand
2024-09-06 3:35 ` [PATCH] mm: move bad zone checking before getting it Lucien Wang
2024-09-06 3:50 ` Lucien Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905095216.7888-1-wangyibo@uniontech.com \
--to=lcnwed@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=trivial@kernel.org \
--cc=wangyibo@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).