From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4304CCE7A96 for ; Thu, 5 Sep 2024 20:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E21F6B008C; Thu, 5 Sep 2024 16:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 691C36B0092; Thu, 5 Sep 2024 16:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 559AC6B0093; Thu, 5 Sep 2024 16:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3259A6B008C for ; Thu, 5 Sep 2024 16:30:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C738BA9612 for ; Thu, 5 Sep 2024 20:30:07 +0000 (UTC) X-FDA: 82531826454.25.BDEB978 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf29.hostedemail.com (Postfix) with ESMTP id 776DE12000A for ; Thu, 5 Sep 2024 20:30:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="DslEQ/Vj"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725568204; a=rsa-sha256; cv=none; b=rqd5m4t005hCzwinHjC5rHz+svXFvRj4O5gNNEi3gCz+A3vNr74cgnN8080fTji3ytKaXU N+X2d57vEpXGa6uzbRZwzfSLw6urmBmLUuBdLPv8kZ6ggGgOIpCwi0Z2ehDw13V9K7+CyS N8LD+9Pog2yVBJe6MiHTes5vxQYTx1Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="DslEQ/Vj"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725568204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y2gwSslBn1o5XE7V1hKr+mf0XEwKtgps4c+wZI4KB8E=; b=3BAxhSTIgNoFjYdsP/DuiFEj1Zjq0mLAxBIl42Sl5Y4ov3dJME9m+160wXtX/Lb0pMDMgl +vg+FwZWEXvCKVazglLUADG9wlU460xBzLD3dCd/Y29N1vJOEMXezNLyTRS/Sf78mO7OXK wB/zFaCl2EoNJfI6m8orOx2C4uhRwu8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725568204; x=1757104204; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dOaaWXnpAep/fcrnY3blbZqV6QssNr8BcJX8tx4Sc8o=; b=DslEQ/VjFldZg+xVkLZWksonU4iyZIV6iMVspUd/WPvP3LqJeVtRqacU JSN8vTv/WsLlAPvJU4H5gt9EqkKfrAg8ckV8110aUEFSfq4HK9KDukdwR 9Quphq+By0v79lYM7GgyWrUaCgRvHZoLFt+A3YH91YtBWQBdKA/w4qwGl hMNSMrwXZ0xvLLThKkgyDj5gA8UmulEqsItA7Ja40dypdy2uy14pHBEUD WppDeumSG7FwsVI0f88YxntFl+vGsOKEvrCRbIuOvbnjND78mxCwKeA5i tlvK2U6RHeGkQ3Eg6SAtnVo8R4P/bPaeeggsXplsjRBl+1TH2qktaH1ta Q==; X-CSE-ConnectionGUID: ACt62B7vT4aKCM2rwOO3uw== X-CSE-MsgGUID: r9S4AidURteN/siRCf02yQ== X-IronPort-AV: E=McAfee;i="6700,10204,11186"; a="24458459" X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="24458459" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 13:21:13 -0700 X-CSE-ConnectionGUID: RshIxymYTJC2+ySq2w1gfA== X-CSE-MsgGUID: VBrzC3xzROqAPfB0/CbGTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="65976414" Received: from lkp-server01.sh.intel.com (HELO 9c6b1c7d3b50) ([10.239.97.150]) by fmviesa010.fm.intel.com with ESMTP; 05 Sep 2024 13:21:09 -0700 Received: from kbuild by 9c6b1c7d3b50 with local (Exim 4.96) (envelope-from ) id 1smIyY-000AHf-3A; Thu, 05 Sep 2024 20:21:06 +0000 Date: Fri, 6 Sep 2024 04:20:21 +0800 From: kernel test robot To: Jesper Dangaard Brouer , tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com, shakeel.butt@linux.dev Cc: oe-kbuild-all@lists.linux.dev, Jesper Dangaard Brouer , hannes@cmpxchg.org, lizefan.x@bytedance.com, longman@redhat.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V10] cgroup/rstat: Avoid flushing if there is an ongoing root flush Message-ID: <202409060400.Z4B69Z8T-lkp@intel.com> References: <172547884995.206112.808619042206173396.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172547884995.206112.808619042206173396.stgit@firesoul> X-Rspam-User: X-Stat-Signature: jigubu3auxhbbhtceu957pdo5s6s39kx X-Rspamd-Queue-Id: 776DE12000A X-Rspamd-Server: rspam02 X-HE-Tag: 1725568204-289054 X-HE-Meta: U2FsdGVkX18lz1GzPbfjoKK4uCtuNc1wUOi6w+/DWSlTHnDBl9hIS/Y7AH+ik94QdDv3RUxjAoZmHa3z8DvQ5ATr85gi+aph0hki3fIN7kL/SO+M70/GloP/DZ2j880ENg/3yHK3Bg/Z9ogKUAp1LOAy4aTGCl7OXEvnRnv0XQV+o98lyY7Z03YkJgCeyt49CCfvDc5JEi+BeqKDwIaDFGPwVcVtPi8K4Y3e4qD6Kho5rbtkA8Gx6vX8EuNc1p5hLsPViwBNNdmalhDzmHXH06KSc+Q/xypqTTOw1kr8IpDD9Po+ND3NMZ/T9xZ21OM3F877DLf7bk6WCsuU31proSJifVeT3aCAW8RhnIWVIGFrQLLF2SzHhDIUfFdFxb6MpYKhHQA0C59aSmpqMUlFPW6fSn7wxF63Z3AVsWKj9Rd0M5KZquTpWEs20bBBIS81pK6n8fQ2adpzT2Hl87rqAiNd1d28NUY8eIssbJCIuZcXphzTuX69fBXGqZGZEQvRQRmZLZWI+nX4pFXm1XkreB1AE9K7ZqmQLR2o+kdiwsgcVvK3T82OPmfThRgwUgh5+zpQSrZHX0uDVZ73i7mdyWP4bCgyXTUzfISsddx2UrmyowmdNkNuwhytbb+mXLQIIqrwjcIBLCTEPQ8fz9Hz/uB/XlY2lusUCw7yj7+/dxMKjY+HESBBxq7jqNn6Jz35cbr7vqP3V8yJKljefcKiZ9aamnDVmG/C4+N79tHHN7bpobiiNVFer4LfmXlhIxPbAfWkD5PnIBCoU1mD+fM5KV6b9dX/F8YLLAEiVoPzwy1l+1S6uoZO7XSJN/alry6BD1rZC47kP17JGTXg+kxp6VeY3jta6DP6W1Eq58ShJkfWwLMEj1Fn4NFnx2VD0PpoC8el7U3SvPAmYXjgthquYp2kf96pUAt7ZOwTNLgs0PaBycpx9V8pSVHXrVuCAan98kl04NUc4l+El8op7jX KHntX2x5 aQYIVtpDpmytDJZlx71I2qRJtnlvfXcrliu+DMm8SD0w2F3WaJqGKOY6/efuSRP1TMm7Z39QcV68vOw1bdtzYbdVHASCG/fygrJeN051+WbRoxTsi9rq/94qfhOnwRone35ECywI/ldtkXFu+OZt4QWAsaxGg7v0Ei3LVPtp8KiHXLfSur+dXiF4vHR6MNIGx8EbbdDrR7xeARLEq8+xSB3nxs1Rx2D4Q6l8RHnqB1QgUZ2SH+qgEkianZuWIRnfGTtAlOfp0ezLGFBI5zUXOISCbsLeAoNm2k+XXsLuydj00WnHdNfj8M6PJknZjk75+MRg9ukCKScz7NkODQroCZUUxnqbVYscq1K194rNt1oyH5/3INtlFW4Xl2lYWy1OAMpH2Jgtz+486Y3UNn76hRRBQUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jesper, kernel test robot noticed the following build warnings: [auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on axboe-block/for-next akpm-mm/mm-everything linus/master v6.11-rc6 next-20240905] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/cgroup-rstat-Avoid-flushing-if-there-is-an-ongoing-root-flush/20240905-034221 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next patch link: https://lore.kernel.org/r/172547884995.206112.808619042206173396.stgit%40firesoul patch subject: [PATCH V10] cgroup/rstat: Avoid flushing if there is an ongoing root flush config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240906/202409060400.Z4B69Z8T-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240906/202409060400.Z4B69Z8T-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409060400.Z4B69Z8T-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/cgroup/rstat.c:321: warning: Function parameter or struct member 'strict' not described in 'cgroup_rstat_trylock_flusher' vim +321 kernel/cgroup/rstat.c 308 309 /** 310 * cgroup_rstat_trylock_flusher - Trylock that checks for on ongoing flusher 311 * @cgrp: target cgroup 312 * 313 * Function return value follow trylock semantics. Returning true when lock is 314 * obtained. Returning false when not locked and it detected flushing can be 315 * skipped as another ongoing flusher is taking care of the flush. 316 * 317 * For callers that depend on flush completing before returning a strict option 318 * is provided. 319 */ 320 static bool cgroup_rstat_trylock_flusher(struct cgroup *cgrp, bool strict) > 321 { 322 struct cgroup *ongoing; 323 324 if (strict) 325 goto lock; 326 327 /* 328 * Check if ongoing flusher is already taking care of this. Descendant 329 * check is necessary due to cgroup v1 supporting multiple root's. 330 */ 331 ongoing = READ_ONCE(cgrp_rstat_ongoing_flusher); 332 if (ongoing && cgroup_is_descendant(cgrp, ongoing)) 333 return false; 334 335 /* Grab right to be ongoing flusher */ 336 if (!ongoing && cgroup_is_root(cgrp)) { 337 struct cgroup *old; 338 339 old = cmpxchg(&cgrp_rstat_ongoing_flusher, NULL, cgrp); 340 if (old) { 341 /* Lost race for being ongoing flusher */ 342 if (cgroup_is_descendant(cgrp, old)) 343 return false; 344 } 345 /* Due to lock yield combined with strict mode record ID */ 346 WRITE_ONCE(cgrp_rstat_ongoing_flusher_ID, current); 347 } 348 lock: 349 __cgroup_rstat_lock(cgrp, -1); 350 351 return true; 352 } 353 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki