From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEE9ECE564 for ; Tue, 10 Sep 2024 05:23:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5E98D0017; Tue, 10 Sep 2024 01:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 656268D0002; Tue, 10 Sep 2024 01:23:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5888D0017; Tue, 10 Sep 2024 01:23:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 274368D0002 for ; Tue, 10 Sep 2024 01:23:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 81764A9AB6 for ; Tue, 10 Sep 2024 05:23:37 +0000 (UTC) X-FDA: 82547686074.22.019CEE9 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf22.hostedemail.com (Postfix) with ESMTP id 48A4CC0002 for ; Tue, 10 Sep 2024 05:23:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HedjSNza; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725945732; a=rsa-sha256; cv=none; b=kFiLkSSkYJEpDwd9JauB+M9IQ8M5d9SNm/hO5EW/wdX4m3mylNxj+04wv34/yCt8hT9WRl QBx53YD67MZFzznVcfGS8Azi0JSifgT7oKj8gauq092ko68wqu0K5L8jtlirbT16mvg6j+ uwPW79/dEWgqhL4gTJGdlyQH87+3HGk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HedjSNza; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725945732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u7R92BbnO0Rns+NeVAjK9nso/K+LylC3K3Hnpjlitgw=; b=eePemSxp09f8ff1jwBaTzsjOKBO9eF97ucScpmz5X+73a6PDm8CmhVVpEkoevZwTKSQDcS q0Tj3yVuXJBNxdgrkkcuFm09S4wi3tJA11nWkTyE4j7D2tYMmovXuUz7KTTWB1o9Ke9BkY c4JBCHrXiWVbVtdBkYFfEuSXWfa/yek= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725945814; x=1757481814; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a1hzRtjTM8om8Av4XmwcgCWu/d6ky3yRduDmqUZhR/w=; b=HedjSNzapzYcr797TPQU71isDI0P1JHmGuOL9deGP1pmGlwqhOk4BN+N jl6LtbCHAdWOBgLnCruUxpbrPmCaAq9ewTUvYh9SMVfS2OdbkjFuPRBt3 vvUHHMMKKBCOPuvW2XOTKBrSwKBh9Br9pp3fIf9zcnwIlvzNnGlG21pfr Wfv4oG7fX4BWagkBLuSm4UOf7B+YobWGSF2pzoXMOvOOiGS5Y8rET7vjf RaSbaLxgsB8SVYaJtzWNnipePL8ABoHt4rVTlIKPqg2Q9yh6uBsjtkvhV T31LxInVRbwITxFK7xpRuC/FkID9p3eidAvXfIqfzCT5izE2qUYkriZB/ w==; X-CSE-ConnectionGUID: 4qOn/C8+RuCEGu998JVdYA== X-CSE-MsgGUID: HgJ7Nu4sSmaiglaPw2OESg== X-IronPort-AV: E=McAfee;i="6700,10204,11190"; a="24823088" X-IronPort-AV: E=Sophos;i="6.10,216,1719903600"; d="scan'208";a="24823088" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 22:23:32 -0700 X-CSE-ConnectionGUID: KrswjazATYmJ5BvEBMCQEA== X-CSE-MsgGUID: twkkzW7bRV2l8dsTZyfdlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,216,1719903600"; d="scan'208";a="66609298" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa007.fm.intel.com with ESMTP; 09 Sep 2024 22:23:29 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1sntLb-00006Y-0e; Tue, 10 Sep 2024 05:23:27 +0000 Date: Tue, 10 Sep 2024 13:23:09 +0800 From: kernel test robot To: Jesper Dangaard Brouer , tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com, shakeel.butt@linux.dev Cc: oe-kbuild-all@lists.linux.dev, Jesper Dangaard Brouer , hannes@cmpxchg.org, lizefan.x@bytedance.com, longman@redhat.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V10] cgroup/rstat: Avoid flushing if there is an ongoing root flush Message-ID: <202409101356.VXPFCu6l-lkp@intel.com> References: <172547884995.206112.808619042206173396.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172547884995.206112.808619042206173396.stgit@firesoul> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 48A4CC0002 X-Stat-Signature: n7uc7azwirz9myyfsfhacnjp3yqka5dr X-Rspam-User: X-HE-Tag: 1725945814-794783 X-HE-Meta: U2FsdGVkX19LkEA1v+o64830AZTtw7Q3lzHdLHGcezE3fbrvNLhlGa1iYFb988K1PrWeZmtXD+/pecbD3eKVtL56wxyHjXUMcxmK1/rTodoOaKpKj2tHrE4nwuha3eS/LBLuhXxHFC9TAVx3QMIAYx4hPocCQ7zm1BypHCZtqnfTUTz6I5Oh2BhLjo0hQrw/1doCTmmsOtf3mv0cEIKb90mKtozeD+PkEpv+1wRtahaoOn+ufNvfTuPH+fv0El3QgzVrrXs5B+vf+rGhYB4wNdZuPhGuUoVLZszecCQ8pVdFwCth0LdlDVM5B6y6pzo/vCmjLXxavsbFLDceeXwiG+hYWUPTy2X+WxuIXUB7SQKAuBBuEMEnN3F1K5mi9qYQjHwOcG3aIIU8mXt/Gj94zNObIoU35xE/9hqHzsgPPslqyn4AYVbznFA+pJZbYdWtE3xHCoqMnqnEyBiddMivJyoPBilHFy5nwbZLzOv4Yth382MicPXwBDcp61yyzMyzzvUFw50cUukmca/iRxQGwkmU8MAxyy2AdCPvpiqtqUbnHAXZHhPGQ0SZNbFR3AdfTgZIMD3GHl/o9awIIIEb2/oST442ZWpOgOdym2q07pfzPllQAUTo9LeT5H5ssJA1pL395E+jRvZMpVom/dtqLWhxQq4e8U1U/gi6q+bXA4YaXY++JZW+JDeOsvYuTHomFBFSs/gbxKcKbF6x/IEYPFFt2WlIvGQH4FmRp+OdhsGwuxIV465KV+jcInS8YA1m7PAHbR3E0S+oQN+ry7+wQnNHcwXpNELN5UPLwlgxwWMeQWoxfRT2sE648/UuKkZhPmmWkRAZ/CDKxC85Fom7Ed7HBtyBN/Kfa4B4KbvBO+oXLTV9044erpH4sTudH4WjtjPLU4mZeAc/e0AXeCG8sCjIYax4OXpsLETk8XR9/6pStv3JGUGBx5SfgQmr6Rr61vy2Vlz5gQjQSNyRdcl hecyecuD W5C++8mgZnBBFqYXwC254k7nwkfeQwUY7AM8QbRlT1wGXNWIRKdsFrVfncHCOVAr/UMvbIxMh5UTAdWvlxRcYGFzrdmnBuaSHkTZfQ/eAyxL9lgr3k7BkK/QxWobp1s6WYSBciClVDx/tzbQpH3C8JqNLyWiYB87v2rzhlvxEiTguFP5uRVSm1tWnIY60deIC7hugtmsHUrmHDVL9AKK4eUei2JbTyTmWUlr5mgrhA2v7mUERX3Osad8MdoZ0hp0c4t91hgU/haz+QjBcHMe0mMgL2qryRnBEFsnl7/WXsafi0hRo+u+eScxayv4Skm13Av3tVK/PjP4OuSDMW4aInC/k2Wxd/68wuauSMNBOr3q8F/tYzxqBkcFKkinYsNwRu9HTws7Lhh6dosyWZlaQ9u7TFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jesper, kernel test robot noticed the following build warnings: [auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on axboe-block/for-next akpm-mm/mm-everything linus/master v6.11-rc7 next-20240909] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/cgroup-rstat-Avoid-flushing-if-there-is-an-ongoing-root-flush/20240905-034221 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next patch link: https://lore.kernel.org/r/172547884995.206112.808619042206173396.stgit%40firesoul patch subject: [PATCH V10] cgroup/rstat: Avoid flushing if there is an ongoing root flush config: hexagon-randconfig-r121-20240910 (https://download.01.org/0day-ci/archive/20240910/202409101356.VXPFCu6l-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce: (https://download.01.org/0day-ci/archive/20240910/202409101356.VXPFCu6l-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409101356.VXPFCu6l-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> kernel/cgroup/rstat.c:339:23: sparse: sparse: Using plain integer as NULL pointer kernel/cgroup/rstat.c:87:18: sparse: sparse: context imbalance in 'cgroup_rstat_updated' - different lock contexts for basic block kernel/cgroup/rstat.c:75:9: sparse: sparse: context imbalance in 'cgroup_rstat_updated_list' - wrong count at exit kernel/cgroup/rstat.c:320:13: sparse: sparse: context imbalance in 'cgroup_rstat_trylock_flusher' - wrong count at exit kernel/cgroup/rstat.c:300:34: sparse: sparse: context imbalance in 'cgroup_rstat_unlock_flusher' - unexpected unlock kernel/cgroup/rstat.c:373:9: sparse: sparse: context imbalance in 'cgroup_rstat_flush_locked' - different lock contexts for basic block kernel/cgroup/rstat.c:447:9: sparse: sparse: context imbalance in 'cgroup_rstat_flush_hold' - wrong count at exit kernel/cgroup/rstat.c:457:6: sparse: sparse: context imbalance in 'cgroup_rstat_flush_release' - wrong count at exit vim +339 kernel/cgroup/rstat.c 308 309 /** 310 * cgroup_rstat_trylock_flusher - Trylock that checks for on ongoing flusher 311 * @cgrp: target cgroup 312 * 313 * Function return value follow trylock semantics. Returning true when lock is 314 * obtained. Returning false when not locked and it detected flushing can be 315 * skipped as another ongoing flusher is taking care of the flush. 316 * 317 * For callers that depend on flush completing before returning a strict option 318 * is provided. 319 */ 320 static bool cgroup_rstat_trylock_flusher(struct cgroup *cgrp, bool strict) 321 { 322 struct cgroup *ongoing; 323 324 if (strict) 325 goto lock; 326 327 /* 328 * Check if ongoing flusher is already taking care of this. Descendant 329 * check is necessary due to cgroup v1 supporting multiple root's. 330 */ 331 ongoing = READ_ONCE(cgrp_rstat_ongoing_flusher); 332 if (ongoing && cgroup_is_descendant(cgrp, ongoing)) 333 return false; 334 335 /* Grab right to be ongoing flusher */ 336 if (!ongoing && cgroup_is_root(cgrp)) { 337 struct cgroup *old; 338 > 339 old = cmpxchg(&cgrp_rstat_ongoing_flusher, NULL, cgrp); 340 if (old) { 341 /* Lost race for being ongoing flusher */ 342 if (cgroup_is_descendant(cgrp, old)) 343 return false; 344 } 345 /* Due to lock yield combined with strict mode record ID */ 346 WRITE_ONCE(cgrp_rstat_ongoing_flusher_ID, current); 347 } 348 lock: 349 __cgroup_rstat_lock(cgrp, -1); 350 351 return true; 352 } 353 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki