From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C042EDE9B4 for ; Tue, 10 Sep 2024 20:19:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F279F8D00C0; Tue, 10 Sep 2024 16:19:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED8A08D0056; Tue, 10 Sep 2024 16:19:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79598D00C0; Tue, 10 Sep 2024 16:19:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B99778D0056 for ; Tue, 10 Sep 2024 16:19:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6774A40AA2 for ; Tue, 10 Sep 2024 20:19:33 +0000 (UTC) X-FDA: 82549943826.25.FC1D1D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 48DDFC0011 for ; Tue, 10 Sep 2024 20:19:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fAnOMtGg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725999487; a=rsa-sha256; cv=none; b=i5VqoJ3tsf5mQh2vJTNpfdq17ZXlvVDVjzHd9q/Ucncb/qTXn+HaKBMKhFT1BzPzyMaF7T UJrYFZJ9r0OmbmyWKQTQMlxKCafp0yYkOKhTYo5Wnr61jANM4G7bfnQiAdQ/qYbl9GX8pf 8k/zvOcsNt2ej0SgfajZaFRjJcXhf/U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fAnOMtGg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725999487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/Ek58qaXc13SAy2fWa0xfKNbuHUlKabbBtKkvuJifU=; b=5uBR4Z3gTNd8MN/NqzIDasyDgQoWrOiqiHplGx0HNWPV+OIvqpLpTFjQ4dFR74Btv4tHYt 0yb/MGVLWONWVBNhMDTK1Fq/55KCCB3DBHH8Eek1Vb3581UkVw1ZI22UrTW7z97a0N1u9C NWp/bShhtttMIrUPszLoUwAYsH15iwA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725999570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W/Ek58qaXc13SAy2fWa0xfKNbuHUlKabbBtKkvuJifU=; b=fAnOMtGg/vKj8V5YBuo9kuAU+OPPZ4RGrSp+3DRy823hdp3gigiPWOHQJ4GCj4JhdL6N+8 NHRAq46f1DZ3+1Nx8gbkziZpZoGMHn03mI0Al2ySBUoTNp7+2kqZCFXY4mZLYO5+ho5jh+ b0fcqrn9xQNTxuTwrZSwQIiUnQwp1mY= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-z6NwDCWgPRaewm-GF9dLJg-1; Tue, 10 Sep 2024 16:19:29 -0400 X-MC-Unique: z6NwDCWgPRaewm-GF9dLJg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a8a6fee3ab1so464354666b.3 for ; Tue, 10 Sep 2024 13:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725999568; x=1726604368; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W/Ek58qaXc13SAy2fWa0xfKNbuHUlKabbBtKkvuJifU=; b=fNVhcxPXp0xdHRQJIPL0FByWxN0p6fcYfHvH3EHOPmovS91WrLhfNkBRP7/GYJaRJY ggnwMq62ZSgNmmHWUy7hGcha2BMbMPoAyOXlvLBbDPXJL4WpkwnwxPSPUHWKnRvFf5GE cY43qcyzSf33sT4cuUX14S6pQ3Qma7Hqlipzacc3urQ4p755A4uZMLdZuihill7tIXJZ KO0xreEfasi1SxR0DafVGJP7WgVUo/omFSWSDFPJM8VF9TTaZK3t0jOZlN8v0yaJ7Xz1 hoNiFO/VLdT8agE315e4MIqKrmUXYZZzpj9hctBUrRPdhaUZLBNne+EEjjD67DaY+Uj6 wO7g== X-Forwarded-Encrypted: i=1; AJvYcCVc+KXmrd5eac3irEOB+UwmHc/+kN636JveaPs/X1JV0CTsK1AyesUC6dYpuQ7miUNPnxzIx1mEUg==@kvack.org X-Gm-Message-State: AOJu0YzFSvxSoPKVKlKiu/3CFjNXbZwQs+Ylrl4kkC+OTk4MGQYxUyAN g0SPIanC3HF8n5qY5qw2xOJ/OWLUUs9rfmfY40Ke96blJU7hpcN36jcjAzUpQ0OnN1nzvnNwnT9 rE9r5XQPRmIit6RIkFv21EWeovEJhF7bZVqjPOnT/5UnCoOWH X-Received: by 2002:a17:907:9812:b0:a88:b90b:bd5e with SMTP id a640c23a62f3a-a8ffaaacfa1mr185690266b.3.1725999568235; Tue, 10 Sep 2024 13:19:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIpn+zlExuTE3yAX+xjiMRNjjie27yYDse9XLe2ciVUQSSxwhcmURZ5WywfpEvPrJPhC6Cgg== X-Received: by 2002:a17:907:9812:b0:a88:b90b:bd5e with SMTP id a640c23a62f3a-a8ffaaacfa1mr185687666b.3.1725999567396; Tue, 10 Sep 2024 13:19:27 -0700 (PDT) Received: from redhat.com ([2a02:14f:176:f5ce:2d9:5bfa:9916:aa0a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25c62485sm519926966b.104.2024.09.10.13.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 13:19:26 -0700 (PDT) Date: Tue, 10 Sep 2024 16:19:19 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton Subject: Re: [PATCH v1 0/5] virtio-mem: s390x support Message-ID: <20240910161847-mutt-send-email-mst@kernel.org> References: <20240910191541.2179655-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240910191541.2179655-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 48DDFC0011 X-Stat-Signature: 377qgomoiw3o47bsmcukgwpm6ug9gbtd X-Rspam-User: X-HE-Tag: 1725999571-406561 X-HE-Meta: U2FsdGVkX1/wDA8avt7fNltbaiCa1LK+wuoi7+SFNpL8VtSMf75IfOXsuwpqXuixOFJWMLSHJkDg5lLa2EPixQE4t2upxFmEYjof1vW1Iwx2UDGdeEkEPWTxzERTZuhCk6UogxaEjaHhwalEWPhcCWJVw6+mbzrz1TKiyshKrGPzWsXsff6S8GfV/q2QhkyOYV72T/FISF/B1eGWSTvYH+75xWPayoqKy0R1IEbk1Si183cSLmCVmtaZIMi2NzTNvwuVPxwxpqJRu3XtN16zGxxtpwL+K+a1BcY8+gbWphRbOXYIye1y0mgb8MWcHSScLplI0Apr+hWWdlqrkscnZwe/CRymgp4h9i8DJYao97mg2mKr/Kh4w68hFtaXqr8s7slT/RtSWYWhhGDS+PmODSIZ214cVCqNtlHpp1vviEmQPV2V6LlW1l3AutFp5JZttnInk4TWUt13/+vdTNBxw8eQsxa59tY2hzMMk5l4MokPHYxN1/sItEdl2PPKO7s37C+5ETRF5TIVRgt2b/Ov2YDEOOtgo+3shuIs1/I1fwYSm3bPrw6r6SFEPP7hzU3+hPoDYEKcGona+50csAh76zS9Y/N2J/TpNueqFAzqmHrow9+jyzAdEwrGcUOYj4Z0U7ny4yQArzBwfN/XP1ZE0wX5UKBNbtLQTeY3K+eiZHfObtsmbTxnLQXBCwvy4rAjOVJe4WV4wXxlkpnarulyRkmrZVEbHQ6nrG2e8zcKdXpiYk3IsOXLVCorivrBomHQqLkxQhUatn9B13REhpjmFaDjzkhfPepZjR/q2Ylwp8HOaGjv2m4aLdW7LpenWElT+u6OzutR5ly2jP2ZJzhEEivqbxVKIi+bpU5npkt/I10vxP06I3NSX0VMCRjM7wMywO5eI0/SIMyqHNFFIu2d1GyxSfcvSao5f9fsdleQ4AKFfBCK/xIG8uNe65042bBpOHAzTJVBdqwY4rcW/4f FAPv+hun GFx2rk1qRRTYkyIX/zViem50wmw15e4zc/yEauwlrktZInUsin1rMfg40lydR/H2SmT60gakCUldWr83yLJd49L59WvpYkAXpBQ6EFy1OPQu6/GyQoC6WLwU6FPYohtym0FQs6pUMsYMJLlQgMPtpFmrhgcvaIcopGl7tvQkg/DJaI+kTYOBPLIbfEBTeZspHuu2suw5MFJ99sX6yyuf5ZGIibS4cyBrEAwl+aaqHn9dH4rNvWvnrf3fLs16OSNdsWwViDmnJdSfwjqj6ya4Fbk8vIrYazmUOt4qg5udpuMqJXnt3OrGzaX+u1V7vOu2+GglNRYnLaxDdOU+O4RyNGIS5hDTfHfazJG8y/+7lm0u9FfL/omni5urd+M/YEQ2ogeyGnH+89oxRdPBGIunbZxwPc99kA9XFPe8evMLdldoEmA/Ggr8YIhQrZFJoMG4jvVdJYnY6Wx912BuYSfxDbJbD4h/AYZTQ7NtoSZ837W72tHTdxPZvFWHCtlACZ30a4nJnFPqcODqc+iUmTOo5yg1avxXjA8/E0qm7ujbxsvoyeo4VnEuEnKR94BuPVmvVGPAzMxAJf6IXeG0RL5tfx7ELudhID4u7rzIWlZW7asuiSwZ6Gki3xdwfew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 09:15:34PM +0200, David Hildenbrand wrote: > Let's finally add s390x support for virtio-mem; my last RFC was sent > 4 years ago, and a lot changed in the meantime. > > This is based on mm/stable. > > I sent out the QEMU part earlier today [1], that contains some more details > and a usage example on s390x (last patch). > > There is not too much in here: The biggest part is querying a new diag(500) > STORAGE_LIMIT hypercall to obtain the proper "max_physmem_end". Once this > and the QEMU part will go upstream, it will get documented in [2] > > The last two patches are not strictly required but certainly nice-to-have. > > Note that -- in contrast to standby memory -- virtio-mem memory must be > configured to be automatically onlined as soon as hotplugged. The easiest > approach is using the "memhp_default_state=" kernel parameter or by using > proper udev rules. More details can be found at [3]. > > I have reviving+upstreaming a systemd service to handle configuring > that on my todo list, but for some reason I keep getting distracted ... > > I tested various things, including: > * Various memory hotplug/hotunplug combinations > * Device hotplug/hotunplug > * /proc/iomem output > * reboot > * kexec > * kdump: make sure we don't hotplug memory > > One remaining work item is kdump support for virtio-mem memory. I > am working on a prototype that will be fairly straight forward, > because the virtio-mem driver already supports a special kdump mode and > dracut will already include it in the initrd as default. With > holiday and conferences coming up I rather sent this out now. > > [1] https://lkml.kernel.org/r/20240910175809.2135596-1-david@redhat.com > [2] https://gitlab.com/davidhildenbrand/s390x-os-virt-spec > [3] https://virtio-mem.gitlab.io/user-guide/user-guide-linux.html > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: Thomas Huth > Cc: Cornelia Huck > Cc: Janosch Frank > Cc: Claudio Imbrenda > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio Pérez" > Cc: Andrew Morton It's mostly s390 changes, so should be merged through that tree. I acked the only virtio specific patch. > David Hildenbrand (5): > s390/kdump: implement is_kdump_kernel() > s390/physmem_info: query diag500(STORAGE_LIMIT) to support QEMU/KVM > memory devices > virtio-mem: s390x support > lib/Kconfig.debug: default STRICT_DEVMEM to "y" on s390x > s390/sparsemem: reduce section size to 128 MiB > > arch/s390/boot/physmem_info.c | 46 ++++++++++++++++++++++++++-- > arch/s390/include/asm/kexec.h | 4 +++ > arch/s390/include/asm/physmem_info.h | 3 ++ > arch/s390/include/asm/sparsemem.h | 2 +- > arch/s390/kernel/crash_dump.c | 6 ++++ > drivers/virtio/Kconfig | 12 ++++---- > lib/Kconfig.debug | 2 +- > 7 files changed, 64 insertions(+), 11 deletions(-) > > -- > 2.46.0