From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C2CCF319D for ; Wed, 2 Oct 2024 07:25:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D490440181; Wed, 2 Oct 2024 03:25:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55CD7440175; Wed, 2 Oct 2024 03:25:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424D5440181; Wed, 2 Oct 2024 03:25:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 18ADF440175 for ; Wed, 2 Oct 2024 03:25:57 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8343680A84 for ; Wed, 2 Oct 2024 07:25:56 +0000 (UTC) X-FDA: 82627827912.26.04EE9CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 8DCD78000E for ; Wed, 2 Oct 2024 07:25:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PShmL/P8"; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727853826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+6Ju5sOQPJKUz0yTIEr2+PumFGXW89G0ZVPqVTbN80=; b=KSH5pqTClwneOTYyHtYl1OAlZajhmbMj5Vldwm5i6lueApQ6ORygAnQIhgAcgDd/oNrcQX p3tWXZ9DPd0G3sISl7UIH7DU4qvDMsezZt3TMVJmKXnq3aR2Rzbm85R43M0A7GByzGXIwv m5ITD8U8jUjJvfOucNePfJW1EXPvBiI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727853826; a=rsa-sha256; cv=none; b=n8KwTLYAbteKEyBz1E9doYwtIDPZpUEv3jQJo7XMxKmOT0Aalej8plwzrvAd2kLyEFl5As 4m0IOLM50mj6SbAPlJYJcfjZEGGxvt/wr8CVHzo3RJaq60+0nOEKqVwUN/Fl0ucJfar81b 5UnCxhULXlRJitG0ukl9yOcyUKWmyeU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PShmL/P8"; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727853953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X+6Ju5sOQPJKUz0yTIEr2+PumFGXW89G0ZVPqVTbN80=; b=PShmL/P8qsai8cJGctG2J/W9wu6bwdpSvsISPupmyv9/XKUIAt5pj8Q71mWTH5pvjbzssp oz1IiQn6mm61tYmjz0jUadNoQDlQjFY01f8hfZ86pAdWmOXaBH3vXdXgceyAq4fhWcY0NL DpQXn4SGuxIv5cV3iRDEJ9T3sMS20vg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-NKM0WuwcORu4JEE4-zijow-1; Wed, 02 Oct 2024 03:25:48 -0400 X-MC-Unique: NKM0WuwcORu4JEE4-zijow-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C59F9195608B; Wed, 2 Oct 2024 07:25:44 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.196]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 68A7A19560A2; Wed, 2 Oct 2024 07:25:38 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 2 Oct 2024 09:25:30 +0200 (CEST) Date: Wed, 2 Oct 2024 09:25:23 +0200 From: Oleg Nesterov To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, peterz@infradead.org, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, mingo@kernel.org Subject: Re: [PATCH v2 tip/perf/core 5/5] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution Message-ID: <20241002072522.GB27552@redhat.com> References: <20241001225207.2215639-1-andrii@kernel.org> <20241001225207.2215639-6-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001225207.2215639-6-andrii@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8DCD78000E X-Stat-Signature: rs4oxm87jfon5jxedyu5453n3gn77co7 X-HE-Tag: 1727853954-307203 X-HE-Meta: U2FsdGVkX1+gYHcVK2Cy4R9U3x47gUysJoMp/9VtOnlrujlHJf9c/mBbgTgyG4ENN4c50a8bMiWtXGnw/dRtJj6YmIRqpIHA4u/iqOqiADMgHG3Knhr/q8XE+s2W3kR3SA2kxqy7o/f39cQ2MO3iKzx8c51trORWNFaeQ26nDXkpbgvht3hU1A/8qYiQ2tQyUhJfotoJ52qyNOcKGFs5pqtBLyKR6OhrxtKKIRkGSW9EOroe0kffVzNaiAAJ/SaKfXI/6U6UFeaJK7XLjEOvJKhdmJEtIxnaJuPzyEbdHGxCNuYVvH9fMhBk6CIKMbhPwXujXIIHviiPQJDBTXWRa5tqRbRosoRnBOrOoj1qTnQ0TPs+YIrh/zzek0QYHJwYEJFx6ZoX0NPOGFSON4unVxTdSYld8MATnjttzRqYjnxC/8HnptIA90WFXOxHLODTG7ALo6W+SMx8jWnQkPlkQdMKOdyU8u/D9epRqHtvDDauHgdyCGWPwOxaNrrEOi3gXlzD2gEXUwjmMB3Cz3BEEAzTcPjDgyj7Li3WvpQZ5Abko10l8YvIarVPZHSZxjVngSt7t4mf+flyPyz0q2G9rE16cB+HsXLLXwfVadoh+DB8CBQLXVtaVJkkV41O2qXbw2xAAgjoR5a1Zux+31NsWiWcxPGtu9QwB2OcTTcSFGZvv4vobDix/jSEMIRnUMHFVYpBsiylaG2LHp/d34ANOBDV0Ouk/TLhfrnzSXkQo9SOs71jLiSJjNFOcW4h5JG2eeIRdUgXkjAEab2WPr5DNIgTYUOooaP+3D1TPEWLVSdvL8bTEnpivkfoEWVwm/XqK/BaiFfthKVCZDcgLhNVa+C4rVPveBKYjxk4rmykQDLGlCUZkXH+9soFEV4+AlRFiH8FafvC3s3tVfVuTtSqgBtEKhDcbAADzc0lM3dXTu+dstGwZaMzoeweEI04dCWwG8/iyHSA3/Ke/Trh6nJ VwG9Ey1a mrfsuFM7/Hou+ILLI2pGRLDj2iXxk/2YPelqDEi01vN2Yqgya79gU809mkhlxaVBR9nxnKXJk43oPLwlAiFuINpVgbDsB2lcwHUub+s+06jKg1PyEVWMWo/4ntFRSzcNNaH1QxrTnC4E8H3uyEtXEP2HUve/7gcRxuba17QfI7Jq0jrBbPLkXWA6AV0CtjX3VOcip/8F8hrVSFRvkNfKjsAM9LDJduc77qtrZLll5iOuYjTYh7Ep3DXYcSymg0RMSeuid4+BerFCtrHfE7joF+Lf+Oj51IV8MNBXEGySBgX9ldtuDIvCGFYplbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/01, Andrii Nakryiko wrote: > > +static struct uprobe *find_active_uprobe_speculative(unsigned long bp_vaddr) > +{ > + struct mm_struct *mm = current->mm; > + struct uprobe *uprobe = NULL; > + struct vm_area_struct *vma; > + struct file *vm_file; > + loff_t offset; > + long seq; > + > + guard(rcu)(); > + > + if (!mmap_lock_speculation_start(mm, &seq)) > + return NULL; > + > + vma = vma_lookup(mm, bp_vaddr); > + if (!vma) > + return NULL; > + > + /* vm_file memory can be reused for another instance of struct file, > + * but can't be freed from under us, so it's safe to read fields from > + * it, even if the values are some garbage values; ultimately > + * find_uprobe_rcu() + mmap_lock_speculation_end() check will ensure > + * that whatever we speculatively found is correct > + */ > + vm_file = READ_ONCE(vma->vm_file); > + if (!vm_file) > + return NULL; > + > + offset = (loff_t)(vma->vm_pgoff << PAGE_SHIFT) + (bp_vaddr - vma->vm_start); LGTM. But perhaps vma->vm_pgoff and vma->vm_start need READ_ONCE() as well, if nothing else to shut up KCSAN if this code races with, say, __split_vma() ? > + uprobe = find_uprobe_rcu(vm_file->f_inode, offset); OK, I guess vm_file->f_inode is fine without READ_ONCE... Oleg.