From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EC9CF8852 for ; Sat, 5 Oct 2024 00:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B501D6B0365; Fri, 4 Oct 2024 20:06:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE018D0001; Fri, 4 Oct 2024 20:06:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953996B0366; Fri, 4 Oct 2024 20:06:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6D6F78D0001 for ; Fri, 4 Oct 2024 20:06:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C09DB1A06C5 for ; Fri, 4 Oct 2024 23:59:55 +0000 (UTC) X-FDA: 82637590350.21.60A3511 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf25.hostedemail.com (Postfix) with ESMTP id EA0BFA001A for ; Fri, 4 Oct 2024 23:59:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=naqRsyca; spf=pass (imf25.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728086352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=46mMRKZQHdD1t82UOfgZQSNIcTqIIAaYNJHUFuDX3yk=; b=jRiZCC9n6terBzRStC9EcD/sD2aF2uOY6YHpamlBoJcE8DrBiD33QY9eNPT08i51mH3Orv 9jfSya7oFZhFIPRO3hejqmjbalSXdIP0FB/sjb1yTK96yHqvfrDd8DayogjrzQAu3ZNTaF fpEyrg8PFwLTxvZeDmEZk6uY5cGHh/4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=naqRsyca; spf=pass (imf25.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728086352; a=rsa-sha256; cv=none; b=ztQWwVlJC9ob6jx7Vqh0mdQyAXcjAAr/Pqmp7ilQFuRmVu2fmQoRXwgvR7NPkpd3RXa9I1 lLFC9LIYQYqZuZcp86Ro5zFAjuk1lZaQZQSwjgpLfopv/R7TzXrJnOG2WuN0IYDq8r0rM7 rsD/N15Si195RRgYuhMyozuFrojog+M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728086393; x=1759622393; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nr4GUGUStXtqD14t7ZevxhYCeurvOELE6qLbAsqBJvQ=; b=naqRsycaESNGnSx7jtZ+NAL5ZXtV+RNfALhPFRY3Pp+yO9fU45LPZGww tonjpIchDiMswv6TcUEjWtdbOPyNyqvbTENCJ0W+/BM6S0xxcrYm1CiHp G+DKReN457EV/FelGnaujG+oofYg05OQMIgOdZ2iBKsNj74hBjeRB1kEW jS6lKgWmUmiaqZ5vFyrR3KXiBn+JUO4aZ4wdMx+fpK5aUiLTMC4kEu9OI uzXgR8k0by6RMnwJOsh2K15RPKDMyjqMY9UchKIdcfsDGHqkiXjg7F7ot Di3LHTY4zykP/8NmATSvtAUkJI6UkOiq/kdq5X8329YnavRkIh4PQl0b3 Q==; X-CSE-ConnectionGUID: 7/9Gw1cqSfOVFnIXjBnFCg== X-CSE-MsgGUID: jOFDHvdkReapbgO91UGyEA== X-IronPort-AV: E=McAfee;i="6700,10204,11215"; a="27456452" X-IronPort-AV: E=Sophos;i="6.11,178,1725346800"; d="scan'208";a="27456452" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2024 16:59:52 -0700 X-CSE-ConnectionGUID: r4hSBamkQvqDiGw8qBDzCg== X-CSE-MsgGUID: kSuRW7wQSN++WA4YrXARVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,178,1725346800"; d="scan'208";a="75290556" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 04 Oct 2024 16:59:46 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1swsD2-0002M1-0Q; Fri, 04 Oct 2024 23:59:44 +0000 Date: Sat, 5 Oct 2024 07:59:27 +0800 From: kernel test robot To: Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, peterz@infradead.org, oleg@redhat.com Cc: oe-kbuild-all@lists.linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, mingo@kernel.org, Andrii Nakryiko Subject: Re: [PATCH v2 tip/perf/core 5/5] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution Message-ID: <202410050745.2Nuvusy4-lkp@intel.com> References: <20241001225207.2215639-6-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001225207.2215639-6-andrii@kernel.org> X-Rspam-User: X-Stat-Signature: r9eweggzeepz3tfxf45d7fd41cfkuons X-Rspamd-Queue-Id: EA0BFA001A X-Rspamd-Server: rspam11 X-HE-Tag: 1728086392-658302 X-HE-Meta: U2FsdGVkX1/BVhk4lq5ETLE6LYTVqB/BuhbPMnFUbeOoJBVW62cpjopGNTDwbkD/xzQHNFiSmulmJX6+dPgQ6ss9BtBzSyGpm9Of1ZKACA3h5DW8r5qdc3IIYj3jR9uuV0bWfWMYtlR8amvVJi7/vENdxMTBSXP1kIlQycz4zANREoRPuqufXr2fUb24zDcSd5LvG/8NXq3bt9XXZKNFQbf4rQJYsxJTdKD1Z3fng/pGOlLE2EzCFo/grBqio6Z+HTg2Bidlvz22fKLy3f2I/wfqo07Ditm5NECgxlRkemiJ9A4aPA5acwg8bBlgsnivrpM6Bh+AQI8iotKqUgC8yr80gtbOZZ0tGMPngsJEEW02Z/w3L6irPv113+K1WhMt9g/loEOyBec6EEoWOvQ+GgV1JS5iuI4LvJmEJJqdJiafE4WMTNzuujpmEZW2ydNsuIY8ubsOyvCa5ZjsQcegrjsopJ2jRLwel4PpHdaP3XqXCLPai763mW7QPOYwhXjy1A0Pu6AA52OlLlefNtsP4aX8FCKKx01t/w+Um2SeROGUCDczdAGLgxNe/QNiCd56lmrtf8QwlZB6ozlXU2NH4jmCl/8oghozfpMJTlKh1mxhjAlZKPTaB3cM9Jo78lOpC4gfdBuzxnyt3IxTRTqW8upW+yVgIacMYMPgvS2A1IDBjnkbKKUTWHpONx8ZN4JBmp2MdiRK8L8ahgp1DpKdd/u19XEda7B4Cx6eXpYEZA4uNkYVTyOsFdyNiA/bykCjqUNBAAZ3IfNaQ4KMUVY+HWMZf7H+CAc2np9gBTMFqtQjXqC0rt3YMdKNGErxkzqnL815GO2ixWyJwVaZqMzXLO7yXdbkrUpkXCdPsLogkUSfQexfaqzl76GfV2Sn0bjV7HIS8i/PK3Bq/CNO8KXga9d8settKYMEXm170JcUmTqGDujjIYb5xVL6/Zs0v3+y1coJSpCxl0c1Fz7qZOC R7zEkrsO y97mmR8dbYVvL4OrrgDN5U8ObKxP6Gh0unHbNgOEd9ohXm+qXfNLCZMB6kJAVSlM9jva/HwKZIhJaPkmlz67ZEDUK7HVWKFaIFMbi+PDcURh+X5bRYpK18mc2ENHax0wbYnVuM6yv+aYMnq+C5VX4fuK1LNqZ1rIPQIoycGfyNtlYRQDz7dt1cWLGmPK9wEXUCHBVBmB0AYfrSTIvNB9OS5L3codQ9ljKg2cSCa5I3vKixmmtnFubwk8bcjJtWjv+5ftFf9y78ECh8XJw7ZplAlCNxt0jz1WqqVkKHMi7ihwZgHekfPZuN2JI1qoI4bB13p1llXqYQ0IMb6E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrii, kernel test robot noticed the following build errors: [auto build test ERROR on tip/perf/core] url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/mm-introduce-mmap_lock_speculation_-start-end/20241002-065354 base: tip/perf/core patch link: https://lore.kernel.org/r/20241001225207.2215639-6-andrii%40kernel.org patch subject: [PATCH v2 tip/perf/core 5/5] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20241005/202410050745.2Nuvusy4-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410050745.2Nuvusy4-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410050745.2Nuvusy4-lkp@intel.com/ All errors (new ones prefixed by >>): kernel/events/uprobes.c: In function 'find_active_uprobe_speculative': >> kernel/events/uprobes.c:2098:46: error: passing argument 2 of 'mmap_lock_speculation_start' from incompatible pointer type [-Wincompatible-pointer-types] 2098 | if (!mmap_lock_speculation_start(mm, &seq)) | ^~~~ | | | long int * In file included from include/linux/mm.h:16, from arch/loongarch/include/asm/cacheflush.h:8, from include/linux/cacheflush.h:5, from include/linux/highmem.h:8, from kernel/events/uprobes.c:13: include/linux/mmap_lock.h:126:75: note: expected 'int *' but argument is of type 'long int *' 126 | static inline bool mmap_lock_speculation_start(struct mm_struct *mm, int *seq) { return false; } | ~~~~~^~~ vim +/mmap_lock_speculation_start +2098 kernel/events/uprobes.c 2086 2087 static struct uprobe *find_active_uprobe_speculative(unsigned long bp_vaddr) 2088 { 2089 struct mm_struct *mm = current->mm; 2090 struct uprobe *uprobe = NULL; 2091 struct vm_area_struct *vma; 2092 struct file *vm_file; 2093 loff_t offset; 2094 long seq; 2095 2096 guard(rcu)(); 2097 > 2098 if (!mmap_lock_speculation_start(mm, &seq)) 2099 return NULL; 2100 2101 vma = vma_lookup(mm, bp_vaddr); 2102 if (!vma) 2103 return NULL; 2104 2105 /* vm_file memory can be reused for another instance of struct file, 2106 * but can't be freed from under us, so it's safe to read fields from 2107 * it, even if the values are some garbage values; ultimately 2108 * find_uprobe_rcu() + mmap_lock_speculation_end() check will ensure 2109 * that whatever we speculatively found is correct 2110 */ 2111 vm_file = READ_ONCE(vma->vm_file); 2112 if (!vm_file) 2113 return NULL; 2114 2115 offset = (loff_t)(vma->vm_pgoff << PAGE_SHIFT) + (bp_vaddr - vma->vm_start); 2116 uprobe = find_uprobe_rcu(vm_file->f_inode, offset); 2117 if (!uprobe) 2118 return NULL; 2119 2120 /* now double check that nothing about MM changed */ 2121 if (!mmap_lock_speculation_end(mm, seq)) 2122 return NULL; 2123 2124 return uprobe; 2125 } 2126 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki