From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5F8CF07C3 for ; Thu, 10 Oct 2024 08:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C007E6B0083; Thu, 10 Oct 2024 04:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB11F6B0088; Thu, 10 Oct 2024 04:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51746B0089; Thu, 10 Oct 2024 04:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 828986B0083 for ; Thu, 10 Oct 2024 04:30:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1C405140A93 for ; Thu, 10 Oct 2024 08:30:48 +0000 (UTC) X-FDA: 82657021902.11.BE2BE3E Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf18.hostedemail.com (Postfix) with ESMTP id 8ACC41C0009 for ; Thu, 10 Oct 2024 08:30:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RnatPFyy; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728548979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xjRgM2erkgK9qh8AbT3u9Jz1xqlQ+SHokymxxsnkwPs=; b=8dJOCoJMXBIoibJcM2H6R06+50/BMygw/2zAKfY+/sKK4RTuxdIi447Nbr86MUED9thXtw 6p4wV+1iJhZMCBe3evGuWl6+lTOhnJWxJzJpeKGIF9rypnRRgb9XZG6kGNNgqSo5ugmLzH dtdBNc3ZQtA9cQUwvCDhhqph2ksulTs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RnatPFyy; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728548979; a=rsa-sha256; cv=none; b=4AsKQ/rhI1EkRLkMmNCc8CaaYucdQaxck/rkAgoGJPQRypU0ORmnVoUlldZzhHLe7CqQS+ vjx49uAMfXkJPrfchHBcAD6qYvxXYHLu+eb/DK1inISs0TCU/dxmu3hZqwcB2ZJYsPFFdZ HJpqZNFYdZo5jCG/r48wfdwFjdlduDI= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2e2d73e6a9fso246226a91.2 for ; Thu, 10 Oct 2024 01:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1728549047; x=1729153847; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xjRgM2erkgK9qh8AbT3u9Jz1xqlQ+SHokymxxsnkwPs=; b=RnatPFyygJ9cr+N+Gsn42AU6VDKg6eSJNcOhlZpX7oJiKj0Zgp4eBTKcKAxKZUL6Ii 1rgnPgwUeHQsM0R2AnvSJhdQ/PS6/Y53xX4LQVK2qviCoRCkHwzeFpgMPI2/fp0kxidU tcZbXtFsvpQf3XhHSuTjcuRmwWOJTCP9xYoTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728549047; x=1729153847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xjRgM2erkgK9qh8AbT3u9Jz1xqlQ+SHokymxxsnkwPs=; b=HGnX4o8kw79QezEi196waOzr4X4/BUpJeaj0SmgWtAoAX4U4zmiVBkPUx9dwycI0kh hj/NXE6kqWtq4UzEx9M++WvY9FJbHeIeHzoCDsxvvT9pvoGUUDqbehYFQImYgAUH8lPR f/mTvrgfNCVdcG5jcAxl/h6zJrFAOWJD1E2d/N3hqht75MOqTZLxeWTTqA5XF8vRXSH4 WqywidPr5vaEZHFvh7j6M5+lnWbXtiW3jGStHO1yjCbq1XUPA5Ms40D0M4flPxl2mUf5 tGd8Akt4azoAUgHLhAHG91Z68ZgCtnfMetoJhqEB8du7gEUEEHEDGyZbCJDGdrWsxcn1 G4xA== X-Forwarded-Encrypted: i=1; AJvYcCUfl5GQKhOSLjIW6Yt8CiyxcHx41hgWfe16/tfxv8DyBBwiAdsX+9bt8rDL2FQ8a9z3fx6ZSjptNg==@kvack.org X-Gm-Message-State: AOJu0YyF8vJl6jmjTpM5cISZkjwkcvxsfsiNCMXcPI9JcRS0E4wJ9AKN IBtSS28pq+hhkufzj7wnovxZMfdkcOiT0wrpKhRTRN3ImaEHvUsRXe/bZ5aVnQ== X-Google-Smtp-Source: AGHT+IGiHJLVn7EEJZoiHDg1IHJwEmo5BKI2W3X+EqMqHJDA19Xi8bq+M3epyy60EICvZVegJa7iQQ== X-Received: by 2002:a17:90a:178e:b0:2e2:cc47:ce1a with SMTP id 98e67ed59e1d1-2e2cc47ce65mr2245610a91.1.1728549047177; Thu, 10 Oct 2024 01:30:47 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c13a:abb0:1c8:a3c3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2d5f0a424sm730808a91.28.2024.10.10.01.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 01:30:46 -0700 (PDT) Date: Thu, 10 Oct 2024 17:30:33 +0900 From: Sergey Senozhatsky To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Bisected: [PATCH v5 8/8] x86/module: enable ROX caches for module text Message-ID: <20241010083033.GA1279924@google.com> References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-9-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009180816.83591-9-rppt@kernel.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8ACC41C0009 X-Stat-Signature: jwxdeyspmq8f49erojzcjzqit6egshis X-HE-Tag: 1728549048-11422 X-HE-Meta: U2FsdGVkX1/vaU6fsbzSLK2Mvz09uEAsnURWTuwURC5Lv/lJCDbI7/1KtalHy3I82ylxsKb+14NfUPuIUMRMif8k9hniqzB531G9STgMnUfXo+JMVmF9bsl6tGRR0sVJMHwiXnvhg8eRVhmmgootNoadftybxE2MODxXl/9/sm8CO+V7iUXM0WBXFZj4TnHs/TR3V46ewVbNupRNkBTmWMWA55yux74Umkqy1G9Qv57lA+8wDIBoLgnoR2k+Yiqsksqk/P+p0OQ0mvQ7vOPZTuKst6mPi1w0Jysvai0sAYHfdGDaLXKkMpN9QGc+0gMRtlbaOlObNAfqsVPNu57QKXzhrqxJaJeWKOJU1M3MDiNIaMobha02OKVhcVLpV7rkxZ/MNjUw2VkHPqgirSt/d8Bw8N0w38kuPvwi7kI338BC3Lgwz+QyAG5r4VTANRjQk8pqrDijZ2+OLoEuzmnDjuU2XxeguAUNEh3SJwcZk0uNqNDgEcz0CKunO6OPwTo1cJnaEQqTfhAfhSgz7Q/MDzUD0s7Pqz8fS5eldPoykkcwgtWuvezcLwAsGmnHvRDQBt52CuJjHRWX/yrE1lpouSNNoNZLQN1dGecEQrVuGIX8cKUPFYwCwygfVb+KJxqYInQKaNm5EYnfcwyT+bsydae1YHEUrX7bwbOSou70DxcHUcULI8JdMk1FiBBhI1k74WE6gxJ1XeZEaVrbB8hnvHr8We9F0a7ma79NuWC6GMB0XyXxrO4/+mUL6xvO9/ldx4pwthp7zYKpI/0D0EzgaMUzVs2Uo7ZrwqpjpCcu+PuI91Jet8PF8IP9DjGFn8CbX61t50ZtkgCY70xvZ283rGbS15RKZU5vd8odTCKm6MwDXmvwNDlDxn+FnNBVedspTL68s09wr/k3SOj9WRHmVghODftrKhFu+dohNIDPceEsaORVSgSiibyRXV1a6ALb/mn7Yp6R4YGcxWN7afe smVssE29 wn7dGX0kxuxwYyvMTKKsFnFyghCQPawNnq1fOf48OcdWo4505CQx1ILoTyKqTOpzQPIl4tdgfxchsLBlp3vVXwfAK0DwbkWRFCEjHEeKCGC0QD+fBRUmmnvmKyMmeXyi0qZW4KnFcVtVEQ5ukv0HcyzeC8XywfKFoxLjQs+e5MRdvjA/ztIkkdYyy9LGebjUeZenD1bmYUe/K9w9FZqRCBCg/VCJbRmp/AUJsN7xC0DFpAGn4CQ+tBtWlxoULyd2o4VpHj2CNfGVt617QwPR/tHYoDpb3qa2zWEarNvZ+4JKRpU6MCsYN5efSvl9BY00cM+xCuaue3sLpYON948zlHVviUAgMKpDo6N/eLEMsg/5YjzjdsaSasRqKAVyBFmBZJdrw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/10/09 21:08), Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module > text allocations. > With this modprobe disappoints kmemleak [ 12.700128] kmemleak: Found object by alias at 0xffffffffa000a000 [ 12.702179] CPU: 5 UID: 0 PID: 410 Comm: modprobe Tainted: G N 6.12.0-rc2+ #760 [ 12.704656] Tainted: [N]=TEST [ 12.705526] Call Trace: [ 12.706250] [ 12.706888] dump_stack_lvl+0x3e/0xdb [ 12.707961] __find_and_get_object+0x100/0x110 [ 12.709256] kmemleak_no_scan+0x2e/0xb0 [ 12.710354] kmemleak_load_module+0xad/0xe0 [ 12.711557] load_module+0x2391/0x45a0 [ 12.712507] __se_sys_finit_module+0x4e0/0x7a0 [ 12.713599] do_syscall_64+0x54/0xf0 [ 12.714477] ? irqentry_exit_to_user_mode+0x33/0x100 [ 12.715696] entry_SYSCALL_64_after_hwframe+0x4b/0x53 [ 12.716931] RIP: 0033:0x7fc7af51f059 [ 12.717816] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 8f 1d 0d 00 f7 d8 64 89 01 48 [ 12.722324] RSP: 002b:00007ffc1d0b0c18 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 12.724173] RAX: ffffffffffffffda RBX: 00005618a9439b20 RCX: 00007fc7af51f059 [ 12.725884] RDX: 0000000000000000 RSI: 000056187aea098b RDI: 0000000000000003 [ 12.727617] RBP: 0000000000000000 R08: 0000000000000060 R09: 00005618a943af60 [ 12.729361] R10: 0000000000000038 R11: 0000000000000246 R12: 000056187aea098b [ 12.731101] R13: 0000000000040000 R14: 00005618a9439ac0 R15: 0000000000000000 [ 12.732814] [ 12.733362] kmemleak: Object 0xffffffffa0000000 (size 2097152): [ 12.734800] kmemleak: comm "modprobe", pid 410, jiffies 4294880489 [ 12.736334] kmemleak: min_count = 2 [ 12.737228] kmemleak: count = 0 [ 12.738043] kmemleak: flags = 0x5 [ 12.738917] kmemleak: checksum = 0 [ 12.739783] kmemleak: backtrace: [ 12.740606] kmemleak_vmalloc+0x29/0xc0 [ 12.741532] kasan_alloc_module_shadow+0xbe/0xe0 [ 12.742649] execmem_vmalloc+0x116/0x220 [ 12.743596] execmem_alloc+0xfb/0x3d0 [ 12.744479] load_module+0x1e84/0x45a0 [ 12.745383] __se_sys_finit_module+0x4e0/0x7a0 [ 12.746452] do_syscall_64+0x54/0xf0 [ 12.747319] entry_SYSCALL_64_after_hwframe+0x4b/0x53 [ 12.748772] kmemleak: Not scanning unknown object at 0xffffffffa000a000 [ 12.750364] CPU: 5 UID: 0 PID: 410 Comm: modprobe Tainted: G N 6.12.0-rc2+ #760 [ 12.752441] Tainted: [N]=TEST [ 12.753165] Call Trace: [ 12.753760] [ 12.754279] dump_stack_lvl+0x3e/0xdb [ 12.755165] kmemleak_load_module+0xad/0xe0 [ 12.756165] load_module+0x2391/0x45a0 [ 12.757068] __se_sys_finit_module+0x4e0/0x7a0 [ 12.758135] do_syscall_64+0x54/0xf0 [ 12.759099] ? irqentry_exit_to_user_mode+0x33/0x100 [ 12.760292] entry_SYSCALL_64_after_hwframe+0x4b/0x53 [ 12.761508] RIP: 0033:0x7fc7af51f059 [ 12.762372] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 8f 1d 0d 00 f7 d8 64 89 01 48 [ 12.772361] RSP: 002b:00007ffc1d0b0c18 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 12.774957] RAX: ffffffffffffffda RBX: 00005618a9439b20 RCX: 00007fc7af51f059 [ 12.776635] RDX: 0000000000000000 RSI: 000056187aea098b RDI: 0000000000000003 [ 12.778283] RBP: 0000000000000000 R08: 0000000000000060 R09: 00005618a943af60 [ 12.779949] R10: 0000000000000038 R11: 0000000000000246 R12: 000056187aea098b [ 12.781619] R13: 0000000000040000 R14: 00005618a9439ac0 R15: 0000000000000000 [ 12.783319]